* [PATCH] net/axgbe: remove freeing buffer in scattered rx
@ 2022-09-08 12:42 Bhagyada Modali
2022-09-08 13:57 ` Namburu, Chandu-babu
0 siblings, 1 reply; 3+ messages in thread
From: Bhagyada Modali @ 2022-09-08 12:42 UTC (permalink / raw)
To: chandu, ferruh.yigit; +Cc: dev, stable, Bhagyada Modali
Removed freeing of mbuf in scattered Rx as it should not be freed in rx.
Fixes: 965b3127d425 ("net/axgbe: support scattered Rx")
Cc: stable@dpdk.org
Signed-off-by: Bhagyada Modali <bhagyada.modali@amd.com>
---
drivers/net/axgbe/axgbe_rxtx.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c
index 8b43e8160b..d4224992ee 100644
--- a/drivers/net/axgbe/axgbe_rxtx.c
+++ b/drivers/net/axgbe/axgbe_rxtx.c
@@ -458,14 +458,11 @@ uint16_t eth_axgbe_recv_scattered_pkts(void *rx_queue,
memset((void *)(&desc->read.desc2), 0, 8);
AXGMAC_SET_BITS_LE(desc->read.desc3, RX_NORMAL_DESC3, OWN, 1);
- if (!eop) {
- rte_pktmbuf_free(mbuf);
+ if (!eop)
goto next_desc;
- }
first_seg->pkt_len = pkt_len;
rxq->bytes += pkt_len;
- mbuf->next = NULL;
first_seg->port = rxq->port_id;
if (rxq->pdata->rx_csum_enable) {
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] net/axgbe: remove freeing buffer in scattered rx
2022-09-08 12:42 [PATCH] net/axgbe: remove freeing buffer in scattered rx Bhagyada Modali
@ 2022-09-08 13:57 ` Namburu, Chandu-babu
2022-09-08 14:54 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Namburu, Chandu-babu @ 2022-09-08 13:57 UTC (permalink / raw)
To: Modali, Bhagyada, Yigit, Ferruh; +Cc: dev, stable
[Public]
Acked-by: Chandubabu Namburu <chandu@amd.com>
-----Original Message-----
From: Modali, Bhagyada <Bhagyada.Modali@amd.com>
Sent: Thursday, September 8, 2022 6:12 PM
To: Namburu, Chandu-babu <chandu@amd.com>; Yigit, Ferruh <Ferruh.Yigit@amd.com>
Cc: dev@dpdk.org; stable@dpdk.org; Modali, Bhagyada <Bhagyada.Modali@amd.com>
Subject: [PATCH] net/axgbe: remove freeing buffer in scattered rx
Removed freeing of mbuf in scattered Rx as it should not be freed in rx.
Fixes: 965b3127d425 ("net/axgbe: support scattered Rx")
Cc: stable@dpdk.org
Signed-off-by: Bhagyada Modali <bhagyada.modali@amd.com>
---
drivers/net/axgbe/axgbe_rxtx.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c index 8b43e8160b..d4224992ee 100644
--- a/drivers/net/axgbe/axgbe_rxtx.c
+++ b/drivers/net/axgbe/axgbe_rxtx.c
@@ -458,14 +458,11 @@ uint16_t eth_axgbe_recv_scattered_pkts(void *rx_queue,
memset((void *)(&desc->read.desc2), 0, 8);
AXGMAC_SET_BITS_LE(desc->read.desc3, RX_NORMAL_DESC3, OWN, 1);
- if (!eop) {
- rte_pktmbuf_free(mbuf);
+ if (!eop)
goto next_desc;
- }
first_seg->pkt_len = pkt_len;
rxq->bytes += pkt_len;
- mbuf->next = NULL;
first_seg->port = rxq->port_id;
if (rxq->pdata->rx_csum_enable) {
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/axgbe: remove freeing buffer in scattered rx
2022-09-08 13:57 ` Namburu, Chandu-babu
@ 2022-09-08 14:54 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2022-09-08 14:54 UTC (permalink / raw)
To: Namburu, Chandu-babu, Modali, Bhagyada, Yigit, Ferruh; +Cc: dev, stable
On 9/8/2022 2:57 PM, Namburu, Chandu-babu wrote:
> -----Original Message-----
> From: Modali, Bhagyada <Bhagyada.Modali@amd.com>
> Sent: Thursday, September 8, 2022 6:12 PM
> To: Namburu, Chandu-babu <chandu@amd.com>; Yigit, Ferruh <Ferruh.Yigit@amd.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Modali, Bhagyada <Bhagyada.Modali@amd.com>
> Subject: [PATCH] net/axgbe: remove freeing buffer in scattered rx
>
> Removed freeing of mbuf in scattered Rx as it should not be freed in rx.
>
> Fixes: 965b3127d425 ("net/axgbe: support scattered Rx")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bhagyada Modali <bhagyada.modali@amd.com>
>
> Acked-by: Chandubabu Namburu <chandu@amd.com>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-08 14:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-08 12:42 [PATCH] net/axgbe: remove freeing buffer in scattered rx Bhagyada Modali
2022-09-08 13:57 ` Namburu, Chandu-babu
2022-09-08 14:54 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).