* [PATCH] app/testpmd: fix slave port reset action
@ 2022-10-12 7:43 Qiming Yang
2022-10-13 17:42 ` Singh, Aman Deep
0 siblings, 1 reply; 3+ messages in thread
From: Qiming Yang @ 2022-10-12 7:43 UTC (permalink / raw)
To: dev, andrew.rybchenko; +Cc: Qiming Yang, stable
As stop action has been forbidden in secondary process, so
the reset action should also not be allowed.
Fixes: a550baf24af9 ("app/testpmd: support multi-process")
Cc: stable@dpdk.org
Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
app/test-pmd/testpmd.c | 18 ++++++++++--------
doc/guides/testpmd_app_ug/run_app.rst | 1 +
2 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 5b0f0838dc..6ce3cdabd9 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3333,14 +3333,16 @@ reset_port(portid_t pid)
continue;
}
- diag = rte_eth_dev_reset(pi);
- if (diag == 0) {
- port = &ports[pi];
- port->need_reconfig = 1;
- port->need_reconfig_queues = 1;
- } else {
- fprintf(stderr, "Failed to reset port %d. diag=%d\n",
- pi, diag);
+ if (is_proc_primary()) {
+ diag = rte_eth_dev_reset(pi);
+ if (diag == 0) {
+ port = &ports[pi];
+ port->need_reconfig = 1;
+ port->need_reconfig_queues = 1;
+ } else {
+ fprintf(stderr, "Failed to reset port %d. diag=%d\n",
+ pi, diag);
+ }
}
}
diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst
index abc3ec10a0..7657b4afad 100644
--- a/doc/guides/testpmd_app_ug/run_app.rst
+++ b/doc/guides/testpmd_app_ug/run_app.rst
@@ -600,6 +600,7 @@ as follows:
- ``dev_configure``
- ``dev_start``
- ``dev_stop``
+- ``dev_reset``
- ``rx_queue_setup``
- ``tx_queue_setup``
- ``rx_queue_release``
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] app/testpmd: fix slave port reset action
2022-10-12 7:43 [PATCH] app/testpmd: fix slave port reset action Qiming Yang
@ 2022-10-13 17:42 ` Singh, Aman Deep
2022-10-17 7:50 ` Andrew Rybchenko
0 siblings, 1 reply; 3+ messages in thread
From: Singh, Aman Deep @ 2022-10-13 17:42 UTC (permalink / raw)
To: Qiming Yang, dev, andrew.rybchenko; +Cc: stable
On 10/12/2022 1:13 PM, Qiming Yang wrote:
> As stop action has been forbidden in secondary process, so
> the reset action should also not be allowed.
>
> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Acked-by: Aman Singh<aman.deep.singh@intel.com>
> ---
> app/test-pmd/testpmd.c | 18 ++++++++++--------
> doc/guides/testpmd_app_ug/run_app.rst | 1 +
> 2 files changed, 11 insertions(+), 8 deletions(-)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] app/testpmd: fix slave port reset action
2022-10-13 17:42 ` Singh, Aman Deep
@ 2022-10-17 7:50 ` Andrew Rybchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Rybchenko @ 2022-10-17 7:50 UTC (permalink / raw)
To: Singh, Aman Deep, Qiming Yang, dev; +Cc: stable
On 10/13/22 20:42, Singh, Aman Deep wrote:
> On 10/12/2022 1:13 PM, Qiming Yang wrote:
>> As stop action has been forbidden in secondary process, so
>> the reset action should also not be allowed.
>>
>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
>
> Acked-by: Aman Singh<aman.deep.singh@intel.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-17 7:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-12 7:43 [PATCH] app/testpmd: fix slave port reset action Qiming Yang
2022-10-13 17:42 ` Singh, Aman Deep
2022-10-17 7:50 ` Andrew Rybchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).