From: Dong Zhou <dongzhou@nvidia.com>
To: <viacheslavo@nvidia.com>, <matan@nvidia.com>
Cc: <dev@dpdk.org>, <rasland@nvidia.com>, <xuemingl@nvidia.com>,
<stable@dpdk.org>
Subject: [PATCH] net/mlx5: fix thread workspace memory leak
Date: Thu, 13 Oct 2022 12:34:02 +0300 [thread overview]
Message-ID: <20221013093402.24572-1-dongzhou@nvidia.com> (raw)
The thread workspace push/pop should be paired. In the "flow_list_create"
routine, if error happened the workspace pop was missed. This patch shares
the workspace pop for all return paths.
Fixes: 0064bf431899 ("net/mlx5: fix nested flow creation")
Cc: xuemingl@nvidia.com
Cc: stable@dpdk.org
Signed-off-by: Dong Zhou <dongzhou@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
drivers/net/mlx5/mlx5_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index e4744b0..6fb1d53 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -7028,8 +7028,8 @@ struct mlx5_list_entry *
rte_errno = ret; /* Restore rte_errno. */
ret = rte_errno;
rte_errno = ret;
- mlx5_flow_pop_thread_workspace();
error_before_hairpin_split:
+ mlx5_flow_pop_thread_workspace();
rte_free(translated_actions);
return 0;
}
--
1.8.3.1
next reply other threads:[~2022-10-13 9:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 9:34 Dong Zhou [this message]
2022-10-18 11:48 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221013093402.24572-1-dongzhou@nvidia.com \
--to=dongzhou@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).