From: Stephen Hemminger <stephen@networkplumber.org>
To: Ivan Malov <ivan.malov@oktetlabs.ru>
Cc: dev@dpdk.org, "Jiang, YuX" <yux.jiang@intel.com>,
Chas Williams <chas3@att.com>,
"Min Hu (Connor)" <humin29@huawei.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
stable@dpdk.org, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH] net/bonding: fix device configure reentrancy
Date: Tue, 1 Nov 2022 12:32:35 -0700 [thread overview]
Message-ID: <20221101123235.7d321376@hermes.local> (raw)
In-Reply-To: <20221101161853.2702425-1-ivan.malov@oktetlabs.ru>
On Tue, 1 Nov 2022 19:18:53 +0300
Ivan Malov <ivan.malov@oktetlabs.ru> wrote:
> diff --git a/drivers/net/bonding/eth_bond_private.h b/drivers/net/bonding/eth_bond_private.h
> index d067ea8c9a..7171516d0d 100644
> --- a/drivers/net/bonding/eth_bond_private.h
> +++ b/drivers/net/bonding/eth_bond_private.h
> @@ -184,6 +184,8 @@ struct bond_dev_private {
>
> void *vlan_filter_bmpmem; /* enabled vlan filter bitmap */
> struct rte_bitmap *vlan_filter_bmp;
> +
> + bool kvargs_processing_is_done;
> };
Minor nit: why not use existing hole in data structure after slave_update_idx?
next prev parent reply other threads:[~2022-11-01 19:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 16:18 Ivan Malov
2022-11-01 19:32 ` Stephen Hemminger [this message]
2022-11-06 9:35 ` Andrew Rybchenko
2022-11-02 3:35 ` Yuan, DukaiX
2022-11-06 9:37 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221101123235.7d321376@hermes.local \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=stable@dpdk.org \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).