From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1534A0543 for ; Sat, 5 Nov 2022 18:13:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD3E942D23; Sat, 5 Nov 2022 18:13:22 +0100 (CET) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mails.dpdk.org (Postfix) with ESMTP id D90FE400D5 for ; Sat, 5 Nov 2022 18:13:20 +0100 (CET) Received: by mail-wr1-f48.google.com with SMTP id bs21so10901560wrb.4 for ; Sat, 05 Nov 2022 10:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mvQF37KomOJORNCofzjN2qGKNzKn+hRTGjmDfa9dZHo=; b=f+2u8FXvkrGRKBszXOHa8JEYAkkuby+/BIQkzTwD8xqDV5hVa+cs0i08N3/SLqpsIq dPa6boqqs6+7lKYJI9Wx2E8/+Qxl6HZ15kKjMldgvbQIDcMuHW+mRADGNVZgfSidoJnw aDW0CUKk+yVjkXJtxh1XNYIkXyh5xDkFEB0pyDFxT/SFWNpblNF/Zq8xXgPKSRQrqyBa OpLdy+y/s4gRoPpKkVUqB4dkQs8nteqjuEUIUwa5lffwbJ+IEJoy+SuBOMI8V3sIF8d8 EtDyRXLzAe1wTO6SqGL/e5F/GE1fN4E4WUuHUA0SIDphhm90qr8HFqWy/xdoEZDCv+A0 8VWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mvQF37KomOJORNCofzjN2qGKNzKn+hRTGjmDfa9dZHo=; b=TE4QNzhEHYx2MLfTuzdOyodXnpNfkGE6L2CUBcppp/j5oKV0fJWx9wCOnlbYowKAft DSubmSkkfw8wWtGFWDauUOd79007IjK+IBTS5sJ1I+XKuT+OFpQGQo+Oqt6Sy1bU+gPk snrDpPN9Cxn0pU5Cs2rR8IdEg8KeDUIkfNvnxJSjDvTE0Sz+5LGdDBUfqhT1ibESqHjc vc2QFb65G865OICJHovJE8+70xf5d/MlhDXxWclBE89RicJpBzJzhja9dplFy9I6WB9K Jl1EfAY5icLKI9quVIujWkfqFxGm4ztr5/6kC/C6fryDERyTFxh0d80BrsUazhkDEcKV 19Sg== X-Gm-Message-State: ACrzQf2fuvBS9j0blCyC6cH911tmPdiUAAl7W09EnZ8QmPAwqGY5mn2P 3oAu8YocZwtg40KPu4d4rufQ5oGS5r0= X-Google-Smtp-Source: AMsMyM64M2zEYxx9E+AF7x6hHTuUUbGB8KmsmQBxTg66TgRXN5XddZXi5hs5D12mZCwvbuD9Uo1tqQ== X-Received: by 2002:adf:fd0a:0:b0:238:bb45:7d87 with SMTP id e10-20020adffd0a000000b00238bb457d87mr8981297wrr.592.1667668400640; Sat, 05 Nov 2022 10:13:20 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id n13-20020a05600c500d00b003b47e75b401sm6199165wmr.37.2022.11.05.10.13.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Nov 2022 10:13:20 -0700 (PDT) From: luca.boccassi@gmail.com To: Olivier Matz Cc: Wenjun Wu , dpdk stable Subject: patch 'net/ixgbe: fix broadcast Rx on VF after promisc removal' has been queued to stable release 20.11.7 Date: Sat, 5 Nov 2022 17:11:28 +0000 Message-Id: <20221105171146.1520039-29-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221105171146.1520039-1-luca.boccassi@gmail.com> References: <20221103092758.1099402-100-luca.boccassi@gmail.com> <20221105171146.1520039-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/07/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/c548e48860b1475d19d8b6c8b43ee619a0d9c14b Thanks. Luca Boccassi --- >From c548e48860b1475d19d8b6c8b43ee619a0d9c14b Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Thu, 29 Sep 2022 14:09:00 +0200 Subject: [PATCH] net/ixgbe: fix broadcast Rx on VF after promisc removal [ upstream commit 8260929205e5a2666f9db697f749a2d23273bb86 ] After a VF requested to remove the promiscuous flag on an interface, the broadcast packets are not received anymore. This breaks some protocols like ARP. In ixgbe_update_vf_xcast_mode(), we should keep the IXGBE_VMOLR_BAM bit (Broadcast Accept) on promiscuous removal. This flag is already set by default in ixgbe_vf_reset_event() on VF reset. A similar patch was accepted in Linux kernel (see link). Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=803e9895ea2b Fixes: 0355c379b71f ("net/ixgbe: support VF promiscuous by PF driver") Signed-off-by: Olivier Matz Acked-by: Wenjun Wu --- drivers/net/ixgbe/ixgbe_pf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c index 8ee83c1d71..7e75a114de 100644 --- a/drivers/net/ixgbe/ixgbe_pf.c +++ b/drivers/net/ixgbe/ixgbe_pf.c @@ -757,9 +757,9 @@ ixgbe_set_vf_mc_promisc(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf) switch (xcast_mode) { case IXGBEVF_XCAST_MODE_NONE: - disable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE | + disable = IXGBE_VMOLR_ROMPE | IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE; - enable = 0; + enable = IXGBE_VMOLR_BAM; break; case IXGBEVF_XCAST_MODE_MULTI: disable = IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-05 17:11:11.228705745 +0000 +++ 0029-net-ixgbe-fix-broadcast-Rx-on-VF-after-promisc-remov.patch 2022-11-05 17:11:08.734943930 +0000 @@ -1 +1 @@ -From 8260929205e5a2666f9db697f749a2d23273bb86 Mon Sep 17 00:00:00 2001 +From c548e48860b1475d19d8b6c8b43ee619a0d9c14b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8260929205e5a2666f9db697f749a2d23273bb86 ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index c73833b7ae..c5ef940533 100644 +index 8ee83c1d71..7e75a114de 100644 @@ -30 +31 @@ -@@ -747,9 +747,9 @@ ixgbe_set_vf_mc_promisc(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf) +@@ -757,9 +757,9 @@ ixgbe_set_vf_mc_promisc(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)