From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAF5DA0544 for ; Fri, 11 Nov 2022 12:40:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A14734014F; Fri, 11 Nov 2022 12:40:12 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 8AB7E40141 for ; Fri, 11 Nov 2022 12:40:11 +0100 (CET) Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id C1C0B3F0C8 for ; Fri, 11 Nov 2022 11:40:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1668166810; bh=7tK9YBeScKUMniNjYVS4bNkLV5HxEyCrfBo5+R5mX98=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sCAlSthLpAsbUY3f9y2dCT7OK2fM9DTTUCT18FosnkYqg6p9pfNAg3V/EiIgA0E9H 2GZwLqyc1hGFg6W0BXMRX4z6WNiv4qKbVgTOuVWiLz2XSE4OYO4hlD+uuY5oWFTZMq A56Anwno2f8AmI4WRDbJuL1TdUgs829nxUh0Pbt83Um5opLwiD+LFMxmESzNWDMZLV woW2/4pJElwnxUVwmYjZnfyUl05pjT/DaW9Ysvb85ATZwI5LG9QWEm6GINRSfVL3oh xjU71NVSeKBXKzizFYVPEoFYOQKQj/usqpot3kPKl2HeTtWpGUDuHoPGcToWY0U9eW TYIPkuHgcNLHQ== Received: by mail-ej1-f70.google.com with SMTP id hp16-20020a1709073e1000b007adf5a83df7so2909656ejc.1 for ; Fri, 11 Nov 2022 03:40:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7tK9YBeScKUMniNjYVS4bNkLV5HxEyCrfBo5+R5mX98=; b=K2nDhLpe5QYai1yfDtKMlInNZ+XhVUTSycD1RCogGAwmWsNHnaVrst0hh+J4tFLlei zIeJZFBwGpq74cKph8RqCnSdKM9V3KOYAwj8VpLHh5SozM/oY7DqevoebTplHIIZ67gW /QBujsT5BID3IWvIVrMG2WuDJ8xgceXgK8xshuz/AmE4VQjkSB0C2JpTJcbMoqTCpycG ihWBD/FGz6gUn/7+08vmJzboSu6i1miyxq+qWzmvOvEilRdut3YTroABNubCjArx1gwx dNPHkbYFUI1AU+H/0SLELCO2TAkiHurgUT18JHajQOFJL1qcS3zmh14OAxOxrSgidD1E L/Dg== X-Gm-Message-State: ANoB5pkIrwkZ0TnM5JHdcMFGwo+uJjsqJqPm3Ys2C6NzDmvsaq74HdYR pQwAhczPcRqcNip5+gPwUkcmhQ3MU+uIRYfxlR4pcAZKmn3HE5mPIe0gIcrugoYuJxdQmIoRINV lcWdZ1W0hGjNQb9YBZjVotlE7 X-Received: by 2002:a05:6402:e93:b0:461:e598:e0bb with SMTP id h19-20020a0564020e9300b00461e598e0bbmr1154370eda.21.1668166810096; Fri, 11 Nov 2022 03:40:10 -0800 (PST) X-Google-Smtp-Source: AA0mqf7UXJSyB4mjfJ8y7BJ6pS/wY6eOcQa4YYERRcdiTgCuFqESFpQJC/SlVBsFrnuRdp+ASd1Kxg== X-Received: by 2002:a05:6402:e93:b0:461:e598:e0bb with SMTP id h19-20020a0564020e9300b00461e598e0bbmr1154357eda.21.1668166809898; Fri, 11 Nov 2022 03:40:09 -0800 (PST) Received: from localhost.localdomain ([2a02:6d40:39af:c100:1891:6c61:50fd:e567]) by smtp.gmail.com with ESMTPSA id s6-20020a170906bc4600b007815ca7ae57sm751435ejv.212.2022.11.11.03.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 03:40:09 -0800 (PST) From: christian.ehrhardt@canonical.com To: Steven Zou Cc: Qi Zhang , dpdk stable Subject: patch 'common/iavf: avoid copy in async mode' has been queued to stable release 19.11.14 Date: Fri, 11 Nov 2022 12:38:36 +0100 Message-Id: <20221111113904.1549618-19-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221111113904.1549618-1-christian.ehrhardt@canonical.com> References: <20221111113904.1549618-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.14 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/18/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/033e89575192d23d38db7262021e4654379ec63c Thanks. Christian Ehrhardt --- >From 033e89575192d23d38db7262021e4654379ec63c Mon Sep 17 00:00:00 2001 From: Steven Zou Date: Mon, 5 Sep 2022 09:42:06 +0800 Subject: [PATCH] common/iavf: avoid copy in async mode [ upstream commit c60fad56266fef1f5f6e08c062806e137713e9da ] If cmd_details are defined or async flag is set, don't copy the desc/buff back to temp. Fixes: e5b2a9e957e7 ("net/avf/base: add base code for avf PMD") Signed-off-by: Steven Zou Acked-by: Qi Zhang --- drivers/net/iavf/base/iavf_adminq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/base/iavf_adminq.c b/drivers/net/iavf/base/iavf_adminq.c index a41402e04e..43483c0ee1 100644 --- a/drivers/net/iavf/base/iavf_adminq.c +++ b/drivers/net/iavf/base/iavf_adminq.c @@ -807,7 +807,8 @@ enum iavf_status_code iavf_asq_send_command(struct iavf_hw *hw, } /* if ready, copy the desc back to temp */ - if (iavf_asq_done(hw)) { + if (iavf_asq_done(hw) && + !details->async && !details->postpone) { iavf_memcpy(desc, desc_on_ring, sizeof(struct iavf_aq_desc), IAVF_DMA_TO_NONDMA); if (buff != NULL) -- 2.38.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-11 12:35:05.465111763 +0100 +++ 0019-common-iavf-avoid-copy-in-async-mode.patch 2022-11-11 12:35:04.749191930 +0100 @@ -1 +1 @@ -From c60fad56266fef1f5f6e08c062806e137713e9da Mon Sep 17 00:00:00 2001 +From 033e89575192d23d38db7262021e4654379ec63c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c60fad56266fef1f5f6e08c062806e137713e9da ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -15 +16 @@ - drivers/common/iavf/iavf_adminq.c | 3 ++- + drivers/net/iavf/base/iavf_adminq.c | 3 ++- @@ -18,5 +19,5 @@ -diff --git a/drivers/common/iavf/iavf_adminq.c b/drivers/common/iavf/iavf_adminq.c -index 8b305c0fe3..56c8a519be 100644 ---- a/drivers/common/iavf/iavf_adminq.c -+++ b/drivers/common/iavf/iavf_adminq.c -@@ -788,7 +788,8 @@ enum iavf_status iavf_asq_send_command(struct iavf_hw *hw, +diff --git a/drivers/net/iavf/base/iavf_adminq.c b/drivers/net/iavf/base/iavf_adminq.c +index a41402e04e..43483c0ee1 100644 +--- a/drivers/net/iavf/base/iavf_adminq.c ++++ b/drivers/net/iavf/base/iavf_adminq.c +@@ -807,7 +807,8 @@ enum iavf_status_code iavf_asq_send_command(struct iavf_hw *hw,