From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E27B0A0544 for ; Fri, 11 Nov 2022 12:41:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE421427EB; Fri, 11 Nov 2022 12:41:31 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 571F440141 for ; Fri, 11 Nov 2022 12:41:30 +0100 (CET) Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 25387423E2 for ; Fri, 11 Nov 2022 11:41:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1668166890; bh=cm63SL5GL3/mQVoz+6HLCSSoXnDyRtWZYdh1xjmedmE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eHGuvxJXUGBGgAeDqX+FWRsNqRwXIT03rmMI+zmDBR6r+S+E4eerUwwd5hCJb0aUd 97OIEW/9u5fyGPB+U0JnS2i1UD4viZtmmiTaQQQ7OkV3Ry8DeV6q40YWtt3zIJw0AE dwk/k8eoluazxJrXc44hQ/tsmnRFXppkV0QW8a+cCU/LyKaUm6OI+DKVq4FmSphQM2 kN1gZXxgNYPF6D+5XC1wdJENxoaIXJlnH8hNnx2BaB3MmBWhoh40v5MtxBaWg9nBY5 gmEcZLrDZuP+fNYchinYaXeLawEj4mH2vVT4nEQrpLA0m7lH0uUh0kmNtg8AfS9Xh8 /rIxMoxJAkhkg== Received: by mail-ej1-f72.google.com with SMTP id qk31-20020a1709077f9f00b00791a3e02c80so2931910ejc.21 for ; Fri, 11 Nov 2022 03:41:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cm63SL5GL3/mQVoz+6HLCSSoXnDyRtWZYdh1xjmedmE=; b=kgksotg9SBNU3pN2kQ2jSu8hG9rh9VSu/i2bu7iQ/gBObNqV5t4+JLVojCgNwx6Z/Y wwY4C27/iwTeCglFdHlZqhvoQJ64XskMHbs268Xbc6iHOyppwXjHwnq47w9nURCX+H1W zeXipS1341jJR30ppICHZEBdGxXRp01r4XQs2v5z5H9p505UCdOoa5jYjs+Myb7PWyKS mRLYaGw89075sB4/oZ2DuvLZSN2EmkqR1I3+YcQlwR2ss8wlknekmIzwHvPOC/dTqhfw SoydBMSECZo2H6c6YMJeifs4Fez8fX3leTgGveca/L16Al2tiB7+v/21puQ5hwzH6z9l OZOw== X-Gm-Message-State: ANoB5pkBLvwM3TwkRFUCe1ELwZ4lWB5Z1Qi93VDAVnc06e7LmaQmH3Rq 1GLM8AbDPXbOCRITn+0fiJJrP87gWbxcCCYdqv7ERFqHeIRPGwqfRw42DZJ372QzA+EPkIeJZX4 aKCnQDoT42u556xoNwiEFwcFz X-Received: by 2002:a17:906:1187:b0:7ae:3b9d:1d5d with SMTP id n7-20020a170906118700b007ae3b9d1d5dmr1546621eja.328.1668166889475; Fri, 11 Nov 2022 03:41:29 -0800 (PST) X-Google-Smtp-Source: AA0mqf5lChGuFuyG9t/vXdVWbrtgS/CQH8et/SLm8pCK/k1O7tmSdoTYbqOZWxT8OnipLsKuG7S1DA== X-Received: by 2002:a17:906:1187:b0:7ae:3b9d:1d5d with SMTP id n7-20020a170906118700b007ae3b9d1d5dmr1546608eja.328.1668166889209; Fri, 11 Nov 2022 03:41:29 -0800 (PST) Received: from localhost.localdomain ([2a02:6d40:39af:c100:1891:6c61:50fd:e567]) by smtp.gmail.com with ESMTPSA id vu6-20020a170907a64600b007ae10525550sm790919ejc.47.2022.11.11.03.41.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 03:41:27 -0800 (PST) From: christian.ehrhardt@canonical.com To: Olivier Matz Cc: Wenjun Wu , dpdk stable Subject: patch 'net/ixgbe: fix broadcast Rx on VF after promisc removal' has been queued to stable release 19.11.14 Date: Fri, 11 Nov 2022 12:38:59 +0100 Message-Id: <20221111113904.1549618-42-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221111113904.1549618-1-christian.ehrhardt@canonical.com> References: <20221111113904.1549618-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.14 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/18/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/4a7d9e59c526d8f7004f90ffd1cf5c8724fd2a51 Thanks. Christian Ehrhardt --- >From 4a7d9e59c526d8f7004f90ffd1cf5c8724fd2a51 Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Thu, 29 Sep 2022 14:09:00 +0200 Subject: [PATCH] net/ixgbe: fix broadcast Rx on VF after promisc removal [ upstream commit 8260929205e5a2666f9db697f749a2d23273bb86 ] After a VF requested to remove the promiscuous flag on an interface, the broadcast packets are not received anymore. This breaks some protocols like ARP. In ixgbe_update_vf_xcast_mode(), we should keep the IXGBE_VMOLR_BAM bit (Broadcast Accept) on promiscuous removal. This flag is already set by default in ixgbe_vf_reset_event() on VF reset. A similar patch was accepted in Linux kernel (see link). Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=803e9895ea2b Fixes: 0355c379b71f ("net/ixgbe: support VF promiscuous by PF driver") Signed-off-by: Olivier Matz Acked-by: Wenjun Wu --- drivers/net/ixgbe/ixgbe_pf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c index 2e46e30b79..5a71eb061d 100644 --- a/drivers/net/ixgbe/ixgbe_pf.c +++ b/drivers/net/ixgbe/ixgbe_pf.c @@ -754,9 +754,9 @@ ixgbe_set_vf_mc_promisc(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf) switch (xcast_mode) { case IXGBEVF_XCAST_MODE_NONE: - disable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE | + disable = IXGBE_VMOLR_ROMPE | IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE; - enable = 0; + enable = IXGBE_VMOLR_BAM; break; case IXGBEVF_XCAST_MODE_MULTI: disable = IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE; -- 2.38.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-11 12:35:06.244654119 +0100 +++ 0042-net-ixgbe-fix-broadcast-Rx-on-VF-after-promisc-remov.patch 2022-11-11 12:35:04.801192217 +0100 @@ -1 +1 @@ -From 8260929205e5a2666f9db697f749a2d23273bb86 Mon Sep 17 00:00:00 2001 +From 4a7d9e59c526d8f7004f90ffd1cf5c8724fd2a51 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8260929205e5a2666f9db697f749a2d23273bb86 ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index c73833b7ae..c5ef940533 100644 +index 2e46e30b79..5a71eb061d 100644 @@ -30 +31 @@ -@@ -747,9 +747,9 @@ ixgbe_set_vf_mc_promisc(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf) +@@ -754,9 +754,9 @@ ixgbe_set_vf_mc_promisc(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)