From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E76EA0557 for ; Wed, 16 Nov 2022 11:40:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C65C42D17; Wed, 16 Nov 2022 11:40:25 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 8002242D13 for ; Wed, 16 Nov 2022 11:40:24 +0100 (CET) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 286833F129 for ; Wed, 16 Nov 2022 10:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1668595224; bh=d4DF89MhTk+M3OmOarFeRpH5dxdQRZwflvX4UiUoQio=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=peAdWRzIyxQIel+KZER855QJczb28H9fmQXqJI/nkMMTJxyc1LJ56xj+b8w/YNOIB DejgPXmFJ4exgiH6OvHCR3wjmKnJJe5Kszq65hKDHgteLG+ZwG/CAnY1LFdkQTeycw bLL/b8hLUYOalWUeQlqkf3nFS4g5AglusL2YYU+Wc4Xa94S98uqKqDtRoRaX8F/nqI edyNDJJxix4hGmp8sJzz39Z6IEGW0o8NbJH7EGAPEDpQdAl/EA/uj0sdiGN7BBU4q8 1COgdQHNEzCHSXY4pXI6j46aYtlBPighNYAHLWJ51bMuQ7bgI5nyQZ6R74yVsylAjA 23tBlI9EFg96w== Received: by mail-wm1-f69.google.com with SMTP id p14-20020a05600c204e00b003cf4cce4da5so371653wmg.0 for ; Wed, 16 Nov 2022 02:40:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d4DF89MhTk+M3OmOarFeRpH5dxdQRZwflvX4UiUoQio=; b=ORzC3h3haRwk8m5g2V2SYBUYArkM1NuSPGxycQDVIOeAeXjxA/EaSxqtcBdhq8luvd 8/sZC+UTlK/+OD7m+9sTkZt47zSvdgyTLw55YXlGVFFXSP3Xe+VjfafyvES/jjzfwn4I kY0NJTh3uBicr1V6Cv5LSKzDcZiKsP+5Au5tGWpPtxTRTx0pUYW3tYfN0mvvNUU6bUAT V1ZpmKa1+mDA4UG12bgFpi9EHI6mMAoSd278OghcbMNKw9jaIXoSOXDh9A0ZEy52sX6P rlJC1BxQV5Jgvbz/7p2lon/LIArTPAlxL9nl2uU6jSYJ2gVlNtEVEYtQ68Syq1W1eget QWbg== X-Gm-Message-State: ANoB5pm9tQXbrPU0xyfnWnwNjJnU2E9uFjQCBODEEEvwhTN4n/vh7gLt 7TgDpF8IjPrsQpDYHme15bHcCPjymRnxGTppfNPJQHuG4z3p+n9JoFm0jg13sB/44LFrLhgGxRW 6c+aAztY3bxDhOTkdXr+DXtRL X-Received: by 2002:a05:6000:18cb:b0:236:71fe:c9c5 with SMTP id w11-20020a05600018cb00b0023671fec9c5mr13106631wrq.677.1668595223374; Wed, 16 Nov 2022 02:40:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf6CtJ1TwIW5mr1BvgrFyLcjO1vtdaMlu05KmP/LWRmnk2sF8I1woP69a1RQ121cbb3RJQ9t7w== X-Received: by 2002:a05:6000:18cb:b0:236:71fe:c9c5 with SMTP id w11-20020a05600018cb00b0023671fec9c5mr13106618wrq.677.1668595223103; Wed, 16 Nov 2022 02:40:23 -0800 (PST) Received: from localhost.localdomain ([2a02:6d40:39e5:dd00:975:f38b:96af:696f]) by smtp.gmail.com with ESMTPSA id u7-20020adff887000000b0023538fb27c1sm14662469wrp.85.2022.11.16.02.40.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 02:40:22 -0800 (PST) From: christian.ehrhardt@canonical.com To: Stephen Hemminger Cc: Ruifeng Wang , dpdk stable Subject: patch 'app/testpmd: make quit flag volatile' has been queued to stable release 19.11.14 Date: Wed, 16 Nov 2022 11:39:58 +0100 Message-Id: <20221116104012.2975036-3-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221116104012.2975036-1-christian.ehrhardt@canonical.com> References: <20221116104012.2975036-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.14 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/23/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/2b7d18ba5301b56e88aa5fb204223cfde0ae9be1 Thanks. Christian Ehrhardt --- >From 2b7d18ba5301b56e88aa5fb204223cfde0ae9be1 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 8 Nov 2022 10:07:43 -0800 Subject: [PATCH] app/testpmd: make quit flag volatile [ upstream commit 4c243bd4a8762163a7a1ba321bc8b8ff924c6358 ] Since f_quit is set in a signal handler it needs to be marked volatile. Otherwise, compiler is allowed to optimize the loop because it can assume the value never changes. The flag can also be made local to the file it is used in. Fixes: d9a191a00e81 ("app/testpmd: fix quitting in container") Signed-off-by: Stephen Hemminger Reviewed-by: Ruifeng Wang --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 379f867caa..9028b2d95a 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -208,7 +208,7 @@ uint16_t stats_period; /**< Period to show statistics (disabled by default) */ * In container, it cannot terminate the process which running with 'stats-period' * option. Set flag to exit stats period loop after received SIGINT/SIGTERM. */ -uint8_t f_quit; +static volatile uint8_t f_quit; uint8_t cl_quit; /* Quit testpmd from cmdline. */ /* -- 2.38.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-16 11:36:50.545917278 +0100 +++ 0003-app-testpmd-make-quit-flag-volatile.patch 2022-11-16 11:36:50.396775352 +0100 @@ -1 +1 @@ -From 4c243bd4a8762163a7a1ba321bc8b8ff924c6358 Mon Sep 17 00:00:00 2001 +From 2b7d18ba5301b56e88aa5fb204223cfde0ae9be1 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4c243bd4a8762163a7a1ba321bc8b8ff924c6358 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 7381dfd9e5..295856f1a8 100644 +index 379f867caa..9028b2d95a 100644 @@ -24 +25 @@ -@@ -231,7 +231,7 @@ unsigned int xstats_display_num; /**< Size of extended statistics to show */ +@@ -208,7 +208,7 @@ uint16_t stats_period; /**< Period to show statistics (disabled by default) */