From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C39C8A0557 for ; Wed, 16 Nov 2022 11:40:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C01AF40F16; Wed, 16 Nov 2022 11:40:38 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 9624740E03 for ; Wed, 16 Nov 2022 11:40:37 +0100 (CET) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 6BAB23F0A2 for ; Wed, 16 Nov 2022 10:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1668595237; bh=6xWlieTeAkMLQpNgAbt1xY3Tac9+OofIVpZlEbB6w4I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jarCi7GxgF51X+F5pNc+s2VR/ldGC+N4gnxtXrs8PnhU6FqVservnOb1oNTr0RQGS YRaR9pD0oynmr5zg3L5Ym/+xxeQE0IPrX7HkdYI3XsHY6RNU9O4zZi82Ow4+C/L52O wS4VODZYpu4+VDssZa+GX0WKnUfCaZgVkaSFpvGkB+OomrpjEjsIShox2fvDwbW/3w 95/FEYjHx4Zqmth9bdbr/99qe75ID3Jcg8K36X6sXFAEa08dSm6u1sgskG9mEmkWbP dIuT5qgrRwLnc6QD7nXgHxZmtB2hHlkc+8C5brCUy4wEoee1LrRdBfax1ZggjDE+Xg veYC0BuKqjlaQ== Received: by mail-wr1-f69.google.com with SMTP id i14-20020adfa50e000000b0023652707418so3578751wrb.20 for ; Wed, 16 Nov 2022 02:40:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6xWlieTeAkMLQpNgAbt1xY3Tac9+OofIVpZlEbB6w4I=; b=hfL7xanRFuCjt6+fY/OZg0/MqhUkNRrEpXsb8H3Xzpq2qQhCn1cwIl+ss//Q1BF6ea i7E5hI8ET+T9lq39/8rODN1JfPf6BQZTAHIzu1mSbv0C6Gm5shUDMGpBfjL2qabTbzjO Oy+ViQedr9D571ZVHT1aIlsZFgUI0Cmg2u8GGc4fKVX6qC/0OGfogrXLWGXS00kJ3FLx g8rqKUy7oP/t7hmu/G+6yRaVejG9nCquwe7hYa0URvCOhMh8mU9P1/YWp7PWWMKHJraQ g1ZLe2WrWsgt+htOaZhhHIalTItB6ZqcXB3GXPpRdpvjxcpyhXAU6kRrsdhd0SLMdSGW r43Q== X-Gm-Message-State: ANoB5pmzsSQVU9owQKnlFH7m3XjAw/fUrZR0i+2AxiMzDCjJN/CCma8k I2sHgEavhzvKtbNyRBJyFWpPLsXxpPSD1XC/1NlGCL6Tp7JTx4Frl5Igq+T8qGSWQPvh6unnJrY QpcVVKYdNXt0NsjlDcUgUhL6d X-Received: by 2002:adf:eed2:0:b0:236:64e6:8c04 with SMTP id a18-20020adfeed2000000b0023664e68c04mr13349458wrp.579.1668595236876; Wed, 16 Nov 2022 02:40:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf7c8lTCEqQwhNJiDhdauZWXns6s2aWpshwQ+zna8283elFWiQ3P8SFOIfUczMWm+Ta99moviw== X-Received: by 2002:adf:eed2:0:b0:236:64e6:8c04 with SMTP id a18-20020adfeed2000000b0023664e68c04mr13349448wrp.579.1668595236632; Wed, 16 Nov 2022 02:40:36 -0800 (PST) Received: from localhost.localdomain ([2a02:6d40:39e5:dd00:975:f38b:96af:696f]) by smtp.gmail.com with ESMTPSA id bt14-20020a056000080e00b002417e7f0685sm14359743wrb.9.2022.11.16.02.40.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 02:40:36 -0800 (PST) From: christian.ehrhardt@canonical.com To: Jerin Jacob Cc: dpdk stable Subject: patch 'power: fix some doxygen comments' has been queued to stable release 19.11.14 Date: Wed, 16 Nov 2022 11:40:01 +0100 Message-Id: <20221116104012.2975036-6-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221116104012.2975036-1-christian.ehrhardt@canonical.com> References: <20221116104012.2975036-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.14 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/23/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/52d2c5707971b114dac6ac5c3e8e051612f7e1a3 Thanks. Christian Ehrhardt --- >From 52d2c5707971b114dac6ac5c3e8e051612f7e1a3 Mon Sep 17 00:00:00 2001 From: Jerin Jacob Date: Wed, 9 Nov 2022 20:24:10 +0530 Subject: [PATCH] power: fix some doxygen comments [ upstream commit 58794bf8d2d577b18e8bd430fd6419274678b34e ] Fix following syntax error reported by doxygen 1.9.5 version. lib/power/rte_power.h:169: error: rte_power_freq_up has @param documentation sections but no arguments (warning treated as error, aborting now) Fixes: d7937e2e3d12 ("power: initial import") Signed-off-by: Jerin Jacob --- lib/librte_power/rte_power.h | 55 ------------------------------------ 1 file changed, 55 deletions(-) diff --git a/lib/librte_power/rte_power.h b/lib/librte_power/rte_power.h index 04dc4cb1da..14ed6c1cf2 100644 --- a/lib/librte_power/rte_power.h +++ b/lib/librte_power/rte_power.h @@ -153,14 +153,6 @@ typedef int (*rte_power_freq_change_t)(unsigned int lcore_id); * Scale up the frequency of a specific lcore according to the available * frequencies. * Review each environments specific documentation for usage. - * - * @param lcore_id - * lcore id. - * - * @return - * - 1 on success with frequency changed. - * - 0 on success without frequency changed. - * - Negative on error. */ extern rte_power_freq_change_t rte_power_freq_up; @@ -168,30 +160,13 @@ extern rte_power_freq_change_t rte_power_freq_up; * Scale down the frequency of a specific lcore according to the available * frequencies. * Review each environments specific documentation for usage. - * - * @param lcore_id - * lcore id. - * - * @return - * - 1 on success with frequency changed. - * - 0 on success without frequency changed. - * - Negative on error. */ - extern rte_power_freq_change_t rte_power_freq_down; /** * Scale up the frequency of a specific lcore to the highest according to the * available frequencies. * Review each environments specific documentation for usage. - * - * @param lcore_id - * lcore id. - * - * @return - * - 1 on success with frequency changed. - * - 0 on success without frequency changed. - * - Negative on error. */ extern rte_power_freq_change_t rte_power_freq_max; @@ -199,54 +174,24 @@ extern rte_power_freq_change_t rte_power_freq_max; * Scale down the frequency of a specific lcore to the lowest according to the * available frequencies. * Review each environments specific documentation for usage.. - * - * @param lcore_id - * lcore id. - * - * @return - * - 1 on success with frequency changed. - * - 0 on success without frequency changed. - * - Negative on error. */ extern rte_power_freq_change_t rte_power_freq_min; /** * Query the Turbo Boost status of a specific lcore. * Review each environments specific documentation for usage.. - * - * @param lcore_id - * lcore id. - * - * @return - * - 1 Turbo Boost is enabled for this lcore. - * - 0 Turbo Boost is disabled for this lcore. - * - Negative on error. */ extern rte_power_freq_change_t rte_power_turbo_status; /** * Enable Turbo Boost for this lcore. * Review each environments specific documentation for usage.. - * - * @param lcore_id - * lcore id. - * - * @return - * - 0 on success. - * - Negative on error. */ extern rte_power_freq_change_t rte_power_freq_enable_turbo; /** * Disable Turbo Boost for this lcore. * Review each environments specific documentation for usage.. - * - * @param lcore_id - * lcore id. - * - * @return - * - 0 on success. - * - Negative on error. */ extern rte_power_freq_change_t rte_power_freq_disable_turbo; -- 2.38.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-11-16 11:36:50.651642903 +0100 +++ 0006-power-fix-some-doxygen-comments.patch 2022-11-16 11:36:50.404775402 +0100 @@ -1 +1 @@ -From 58794bf8d2d577b18e8bd430fd6419274678b34e Mon Sep 17 00:00:00 2001 +From 52d2c5707971b114dac6ac5c3e8e051612f7e1a3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 58794bf8d2d577b18e8bd430fd6419274678b34e ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ - lib/power/rte_power.h | 55 ------------------------------------------- + lib/librte_power/rte_power.h | 55 ------------------------------------ @@ -20,5 +21,5 @@ -diff --git a/lib/power/rte_power.h b/lib/power/rte_power.h -index 47345e26df..7954299489 100644 ---- a/lib/power/rte_power.h -+++ b/lib/power/rte_power.h -@@ -169,14 +169,6 @@ typedef int (*rte_power_freq_change_t)(unsigned int lcore_id); +diff --git a/lib/librte_power/rte_power.h b/lib/librte_power/rte_power.h +index 04dc4cb1da..14ed6c1cf2 100644 +--- a/lib/librte_power/rte_power.h ++++ b/lib/librte_power/rte_power.h +@@ -153,14 +153,6 @@ typedef int (*rte_power_freq_change_t)(unsigned int lcore_id); @@ -39 +40 @@ -@@ -184,30 +176,13 @@ extern rte_power_freq_change_t rte_power_freq_up; +@@ -168,30 +160,13 @@ extern rte_power_freq_change_t rte_power_freq_up; @@ -70 +71 @@ -@@ -215,54 +190,24 @@ extern rte_power_freq_change_t rte_power_freq_max; +@@ -199,54 +174,24 @@ extern rte_power_freq_change_t rte_power_freq_max;