From: Kaisen You <kaisenx.you@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com,
Kaisen You <kaisenx.you@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>
Subject: [PATCH] net/iavf:fix slow memory allocation
Date: Thu, 17 Nov 2022 06:57:26 +0000 [thread overview]
Message-ID: <20221117065726.277672-1-kaisenx.you@intel.com> (raw)
In some cases, the DPDK does not allocate hugepage heap memory to
some sockets due to the user setting parameters
(e.g. -l 40-79, SOCKET 0 has no memory).
When the interrupt thread runs on the corresponding core of this
socket, each allocation/release will execute a whole set of heap
allocation/release operations,resulting in poor performance.
Instead we call malloc() to get memory from the system's
heap space to fix this problem.
Fixes: cb5c1b91f76f ("net/iavf: add thread for event callbacks")
Cc: stable@dpdk.org
Signed-off-by: Kaisen You <kaisenx.you@intel.com>
---
drivers/net/iavf/iavf_vchnl.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index f92daf97f2..a05791fe48 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -36,7 +36,6 @@ struct iavf_event_element {
struct rte_eth_dev *dev;
enum rte_eth_event_type event;
void *param;
- size_t param_alloc_size;
uint8_t param_alloc_data[0];
};
@@ -80,7 +79,7 @@ iavf_dev_event_handle(void *param __rte_unused)
TAILQ_FOREACH_SAFE(pos, &pending, next, save_next) {
TAILQ_REMOVE(&pending, pos, next);
rte_eth_dev_callback_process(pos->dev, pos->event, pos->param);
- rte_free(pos);
+ free(pos);
}
}
@@ -94,14 +93,13 @@ iavf_dev_event_post(struct rte_eth_dev *dev,
{
struct iavf_event_handler *handler = &event_handler;
char notify_byte;
- struct iavf_event_element *elem = rte_malloc(NULL, sizeof(*elem) + param_alloc_size, 0);
+ struct iavf_event_element *elem = malloc(sizeof(*elem) + param_alloc_size);
if (!elem)
return;
elem->dev = dev;
elem->event = event;
elem->param = param;
- elem->param_alloc_size = param_alloc_size;
if (param && param_alloc_size) {
rte_memcpy(elem->param_alloc_data, param, param_alloc_size);
elem->param = elem->param_alloc_data;
@@ -165,7 +163,7 @@ iavf_dev_event_handler_fini(void)
struct iavf_event_element *pos, *save_next;
TAILQ_FOREACH_SAFE(pos, &handler->pending, next, save_next) {
TAILQ_REMOVE(&handler->pending, pos, next);
- rte_free(pos);
+ free(pos);
}
}
--
2.34.1
next reply other threads:[~2022-11-17 7:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 6:57 Kaisen You [this message]
2022-11-18 8:22 ` Jiale, SongX
2022-12-07 9:07 ` You, KaisenX
2022-12-08 8:46 ` Wu, Jingjing
2022-12-08 15:04 ` Ferruh Yigit
2022-12-13 7:52 ` You, KaisenX
2022-12-13 9:35 ` Ferruh Yigit
2022-12-13 13:27 ` Ferruh Yigit
2022-12-20 6:52 ` You, KaisenX
2022-12-20 9:33 ` David Marchand
2022-12-20 10:11 ` You, KaisenX
2022-12-20 10:33 ` David Marchand
2022-12-21 9:12 ` You, KaisenX
2022-12-21 10:50 ` David Marchand
2022-12-22 6:42 ` You, KaisenX
2022-12-27 6:06 ` You, KaisenX
2023-01-10 10:16 ` David Marchand
2023-01-13 6:24 ` You, KaisenX
2022-12-21 13:48 ` Ferruh Yigit
2022-12-22 7:23 ` You, KaisenX
2022-12-22 12:06 ` Ferruh Yigit
2022-12-26 2:17 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221117065726.277672-1-kaisenx.you@intel.com \
--to=kaisenx.you@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).