From: Huisong Li <lihuisong@huawei.com>
To: <stable@dpdk.org>, <christian.ehrhardt@canonical.com>
Cc: <liudongdong3@huawei.com>, <fengchengwen@huawei.com>,
<huangdaode@huawei.com>, <lihuisong@huawei.com>
Subject: [PATCH 19.11 2/2] net/hns3: delete unused markup
Date: Thu, 1 Dec 2022 14:08:26 +0800 [thread overview]
Message-ID: <20221201060826.55104-3-lihuisong@huawei.com> (raw)
In-Reply-To: <20221201060826.55104-1-lihuisong@huawei.com>
[ upstream commit c05a540902b0e1661945775dc39b144a572c2404 ]
The '__rte_unused' tag in the input parameter of 'hns3_mac_stats_reset'
is redundant. This patch remove this tag. In addition, this function is
aimed to clear MAC statics. So using 'struct hns3_hw' as input parameter
is better than 'struct rte_eth_dev', and it also facilitates the call of
this function.
Fixes: 8839c5e202f3 ("net/hns3: support device stats")
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
---
drivers/net/hns3/hns3_stats.c | 23 ++++++-----------------
1 file changed, 6 insertions(+), 17 deletions(-)
diff --git a/drivers/net/hns3/hns3_stats.c b/drivers/net/hns3/hns3_stats.c
index b4bc4f28f3..3f3e9f1c22 100644
--- a/drivers/net/hns3/hns3_stats.c
+++ b/drivers/net/hns3/hns3_stats.c
@@ -347,15 +347,6 @@ hns3_query_mac_stats_reg_num(struct hns3_hw *hw)
return 0;
}
-static int
-hns3_query_update_mac_stats(struct rte_eth_dev *dev)
-{
- struct hns3_adapter *hns = dev->data->dev_private;
- struct hns3_hw *hw = &hns->hw;
-
- return hns3_update_mac_stats(hw);
-}
-
/* Get tqp stats from register */
static int
hns3_update_tqp_stats(struct hns3_hw *hw)
@@ -519,14 +510,13 @@ hns3_stats_reset(struct rte_eth_dev *eth_dev)
}
static int
-hns3_mac_stats_reset(__rte_unused struct rte_eth_dev *dev)
+hns3_mac_stats_reset(struct hns3_hw *hw)
{
- struct hns3_adapter *hns = dev->data->dev_private;
- struct hns3_hw *hw = &hns->hw;
struct hns3_mac_stats *mac_stats = &hw->mac_stats;
int ret;
- ret = hns3_query_update_mac_stats(dev);
+ /* Clear hardware MAC statistics by reading it. */
+ ret = hns3_update_mac_stats(hw);
if (ret) {
hns3_err(hw, "Clear Mac stats fail : %d", ret);
return ret;
@@ -590,8 +580,7 @@ hns3_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,
count = 0;
if (!hns->is_vf) {
- /* Update Mac stats */
- ret = hns3_query_update_mac_stats(dev);
+ ret = hns3_update_mac_stats(hw);
if (ret < 0) {
hns3_err(hw, "Update Mac stats fail : %d", ret);
return ret;
@@ -929,6 +918,7 @@ int
hns3_dev_xstats_reset(struct rte_eth_dev *dev)
{
struct hns3_adapter *hns = dev->data->dev_private;
+ struct hns3_hw *hw = &hns->hw;
struct hns3_pf *pf = &hns->pf;
struct hns3_rx_queue *rxq;
int ret;
@@ -956,8 +946,7 @@ hns3_dev_xstats_reset(struct rte_eth_dev *dev)
if (hns->is_vf)
return 0;
- /* HW registers are cleared on read */
- ret = hns3_mac_stats_reset(dev);
+ ret = hns3_mac_stats_reset(hw);
if (ret)
return ret;
--
2.33.0
next prev parent reply other threads:[~2022-12-01 6:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 6:08 [PATCH 19.11 0/2] backport two patches for bonding and hns3 driver Huisong Li
2022-12-01 6:08 ` [PATCH 19.11 1/2] net/bonding: fix slave device Rx/Tx offload configuration Huisong Li
2022-12-01 6:08 ` Huisong Li [this message]
2022-12-05 6:55 ` [PATCH 19.11 0/2] backport two patches for bonding and hns3 driver Christian Ehrhardt
2022-12-06 1:27 ` lihuisong (C)
2022-12-06 6:43 ` Christian Ehrhardt
2022-12-06 6:54 ` lihuisong (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221201060826.55104-3-lihuisong@huawei.com \
--to=lihuisong@huawei.com \
--cc=christian.ehrhardt@canonical.com \
--cc=fengchengwen@huawei.com \
--cc=huangdaode@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).