From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0165AA0540 for ; Tue, 13 Dec 2022 19:48:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D171940395; Tue, 13 Dec 2022 19:48:09 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3089E4021D for ; Tue, 13 Dec 2022 19:48:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670957287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gayHuSbKg4yiEl09yZohbB+wCtO0M7MXAxQeyLATjC8=; b=D92QW7w8FPHtV/ELJSwin0nCzKn2ObZo9dlcQ9nNgtE3bpfy4nwSunR8TEtwlnmb6//aJ0 MzoUl9eHhsg9Hg5mP9UbfHE8Mv5uS5X701kaI+/NZiMOvO56Rrmw1QTo3hZDFIFvnaGVaO wiZY4sR8OVmRyBsB1KOkxPgaCFSPUBo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-297-rZHa5wB1PwCd6GnY7tfZ3Q-1; Tue, 13 Dec 2022 13:48:06 -0500 X-MC-Unique: rZHa5wB1PwCd6GnY7tfZ3Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A2EE6857F90; Tue, 13 Dec 2022 18:48:05 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.195.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id 533ED1C55A; Tue, 13 Dec 2022 18:48:03 +0000 (UTC) From: Kevin Traynor To: stable@dpdk.org Cc: bluca@debian.org, david.marchand@redhat.com, john.mcnamara@intel.com, qi.z.zhang@intel.com, yux.jiang@intel.com, beilei.xing@intel.com, Yuying.Zhang@intel.com, wenxuanx.wu@intel.com, jie1x.wang@intel.com, dapengx.yu@intel.com, Kevin Traynor Subject: [PATCH 21.11 1/3] Revert "net/i40e: fix jumbo frame Rx with X722" Date: Tue, 13 Dec 2022 18:47:31 +0000 Message-Id: <20221213184733.411996-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org This reverts commit 46abe3043e56f4905972ad87f1bfb15f4c1bc4a2. This chain of commits has been found to cause issues with setting max frame size when the link is not negotiated in 1s or the link is down. The frame size is not set and no error is returned to the user. Revert the chain until a fix is found. Link to original upstream commit and discussion: 719469f13b11 ("net/i40e: fix jumbo frame Rx with X722") https://mails.dpdk.org/archives/dev/2022-December/257566.html Reported-by: David Marchand Signed-off-by: Kevin Traynor --- drivers/net/i40e/i40e_ethdev.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index ecef1a6e7e..bad27355fc 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -12115,11 +12115,6 @@ i40e_set_mac_max_frame(struct rte_eth_dev *dev, uint16_t size) bool can_be_set = true; - /* - * I40E_MEDIA_TYPE_BASET link up can be ignored - * I40E_MEDIA_TYPE_BASET link down that hw->phy.media_type - * is I40E_MEDIA_TYPE_UNKNOWN - */ - if (hw->phy.media_type != I40E_MEDIA_TYPE_BASET && - hw->phy.media_type != I40E_MEDIA_TYPE_UNKNOWN) { + /* I40E_MEDIA_TYPE_BASET link up can be ignored */ + if (hw->phy.media_type != I40E_MEDIA_TYPE_BASET) { do { update_link_reg(hw, &link); -- 2.38.1