patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: stable@dpdk.org
Cc: bluca@debian.org, david.marchand@redhat.com,
	john.mcnamara@intel.com, qi.z.zhang@intel.com,
	yux.jiang@intel.com, beilei.xing@intel.com,
	Yuying.Zhang@intel.com, wenxuanx.wu@intel.com,
	jie1x.wang@intel.com, dapengx.yu@intel.com,
	Kevin Traynor <ktraynor@redhat.com>
Subject: [PATCH 21.11 2/3] Revert "net/i40e: fix max frame size config at port level"
Date: Tue, 13 Dec 2022 18:47:32 +0000	[thread overview]
Message-ID: <20221213184733.411996-2-ktraynor@redhat.com> (raw)
In-Reply-To: <20221213184733.411996-1-ktraynor@redhat.com>

This reverts commit 67309512051829f552bc105ac63f48029629e238.

This chain of commits has been found to cause issues with setting
max frame size when the link is not negotiated in 1s or the link
is down. The frame size is not set and no error is returned to
the user.

Revert the chain until a fix is found.

Link to original upstream commit and discussion:
2184f7cdeeaa ("net/i40e: fix max frame size config at port level")
https://mails.dpdk.org/archives/dev/2022-December/257566.html

Reported-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
 drivers/net/i40e/i40e_ethdev.c | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index bad27355fc..4ac31c2fec 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12113,18 +12113,14 @@ i40e_set_mac_max_frame(struct rte_eth_dev *dev, uint16_t size)
 	struct rte_eth_link link;
 	enum i40e_status_code status;
-	bool can_be_set = true;
 
-	/* I40E_MEDIA_TYPE_BASET link up can be ignored */
-	if (hw->phy.media_type != I40E_MEDIA_TYPE_BASET) {
-		do {
-			update_link_reg(hw, &link);
-			if (link.link_status)
-				break;
-			rte_delay_ms(CHECK_INTERVAL);
-		} while (--rep_cnt);
-		can_be_set = !!link.link_status;
-	}
+	do {
+		update_link_reg(hw, &link);
+		if (link.link_status)
+			break;
 
-	if (can_be_set) {
+		rte_delay_ms(CHECK_INTERVAL);
+	} while (--rep_cnt);
+
+	if (link.link_status) {
 		status = i40e_aq_set_mac_config(hw, size, TRUE, 0, false, NULL);
 		if (status != I40E_SUCCESS)
-- 
2.38.1


  reply	other threads:[~2022-12-13 18:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 18:47 [PATCH 21.11 1/3] Revert "net/i40e: fix jumbo frame Rx with X722" Kevin Traynor
2022-12-13 18:47 ` Kevin Traynor [this message]
2022-12-13 18:47 ` [PATCH 21.11 3/3] Revert "net/i40e: enable maximum frame size at port level" Kevin Traynor
2022-12-14 10:19 ` [PATCH 21.11 1/3] Revert "net/i40e: fix jumbo frame Rx with X722" David Marchand
2022-12-19 10:20   ` Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221213184733.411996-2-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=Yuying.Zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=bluca@debian.org \
    --cc=dapengx.yu@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=jie1x.wang@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=wenxuanx.wu@intel.com \
    --cc=yux.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).