From: Mingjin Ye <mingjinx.ye@intel.com>
To: dev@dpdk.org
Cc: qiming.yang@intel.com, stable@dpdk.org, yidingx.zhou@intel.com,
Mingjin Ye <mingjinx.ye@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>, Jie Zhou <jizh@microsoft.com>,
Ranjit Menon <ranjit.menon@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Pallavi Kadam <pallavi.kadam@intel.com>
Subject: [PATCH v7] doc: add PMD known issue
Date: Mon, 26 Dec 2022 10:52:44 +0800 [thread overview]
Message-ID: <20221226025244.18972-1-mingjinx.ye@intel.com> (raw)
In-Reply-To: <20221121025443.190608-1-mingjinx.ye@intel.com>
Add a known issue: Rx path dynamic routing is not supported for PMD.
Fixes: de853a3bb151 ("net/ice: disable DDP package on Windows")
Cc: stable@dpdk.org
Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
---
doc/guides/nics/ice.rst | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst
index ce075e067c..01fb96101f 100644
--- a/doc/guides/nics/ice.rst
+++ b/doc/guides/nics/ice.rst
@@ -395,3 +395,26 @@ file is used by both the kernel driver and the DPDK PMD.
Windows support: The DDP package is not supported on Windows so,
loading of the package is disabled on Windows.
+
+ice: Rx path is not supported after PF or DCF add vlan offload
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+If pmd does not enable Vlan offload during initialization, it will
+automatically select Rx paths that do not support offload. Even if
+Vlan offload is subsequently enabled through the API, Vlan offload
+will not work because the selected Rx path does not support Vlan
+offload.
+
+cmd_vlan_offload_parsed() goes down to the follow ethdev API functions:
+ - rte_eth_dev_set_vlan_strip_on_queue()
+ - rte_eth_dev_set_vlan_offload()
+These functions add offload settings when the port is started, running
+and processing traffic. At this time, ``rte_eth_rx_queue_setup`` api is
+needed to reroute rxq to the RX path with offload function. But at this
+time, it is possible that the original Rx path is handling packages, so
+this is not thread-safe.
+
+When applying offload on the PF or DCF, starting the ``testpmd``
+application, use the ``--rx-offloads`` startup parameter to force the
+dpdk lib to choose the Rx path with the offload function by default.
+
--
2.34.1
next prev parent reply other threads:[~2022-12-26 2:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 17:10 [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq Mingjin Ye
2022-10-26 9:52 ` lihuisong (C)
2022-10-27 11:02 ` Ye, MingjinX
2022-10-28 2:09 ` lihuisong (C)
2022-11-03 1:28 ` Ye, MingjinX
2022-11-03 7:01 ` lihuisong (C)
2022-11-04 8:21 ` Ye, MingjinX
2022-11-04 10:17 ` lihuisong (C)
2022-11-04 11:33 ` Ye, MingjinX
2022-11-06 10:32 ` Andrew Rybchenko
2022-11-07 7:18 ` Ye, MingjinX
2022-10-26 17:10 ` [PATCH v4 2/2] net/ice: fix vlan offload Mingjin Ye
2022-10-27 8:36 ` Huang, ZhiminX
2022-10-27 8:36 ` [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq Huang, ZhiminX
2022-10-27 13:16 ` Singh, Aman Deep
2022-11-08 13:28 ` [PATCH v5 1/2] net/ice: fix vlan offload Mingjin Ye
2022-11-08 13:28 ` [PATCH v5 2/2] net/ice: fix vlan offload of rxq Mingjin Ye
2022-11-09 1:52 ` Huang, ZhiminX
2022-11-21 2:54 ` [PATCH v6] doc: add PMD known issue Mingjin Ye
2022-11-25 1:55 ` Ye, MingjinX
2022-12-09 10:20 ` Ye, MingjinX
2022-12-13 1:41 ` Zhang, Qi Z
2022-12-13 4:25 ` Ye, MingjinX
2022-12-23 7:32 ` [PATCH v7] " Mingjin Ye
2022-12-26 2:52 ` Mingjin Ye [this message]
2022-12-27 9:00 ` Mingjin Ye
2022-12-27 16:40 ` Stephen Hemminger
2023-01-28 6:01 ` [PATCH v8] " Mingjin Ye
2023-01-28 17:17 ` Stephen Hemminger
2023-02-02 2:30 ` Ye, MingjinX
2022-11-09 1:51 ` [PATCH v5 1/2] net/ice: fix vlan offload Huang, ZhiminX
2022-11-11 3:34 ` Ye, MingjinX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221226025244.18972-1-mingjinx.ye@intel.com \
--to=mingjinx.ye@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jizh@microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=ranjit.menon@intel.com \
--cc=stable@dpdk.org \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).