From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F999A04FD for ; Tue, 27 Dec 2022 17:40:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1437140DDB; Tue, 27 Dec 2022 17:40:50 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 96E2340DDB for ; Tue, 27 Dec 2022 17:40:48 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id s7so13678845plk.5 for ; Tue, 27 Dec 2022 08:40:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=n+Ge6rnIct/GoC9BtBwvW8UCLmza8AIm9rvjBMbnzxk=; b=nqKTLnFuWJ+Qb2buKdxosaMZyGU0I5IjgA7XAAj2oanrgAUdPMKytKOVqIYncJpT8y f1pnnATzCVzszsgoUgw+xR7UmoXvlfBG5/em+V/CwYhCexFAFYyO8ZVUdwkhIHtgw+6e tb8KP08m+1ITV6laXmOnm5dj2Vz/ho7mvnaIw3uZ6cW4ddYPUur0YHgMvNgfURnMjLcb mAYgRwkYJPIjGS9BmlP8hKcnPZY/uoAQwJEUAt4xxlAr/L1tCp17rY9CfD5XG/DUZe23 6+kk//HHPvOo8r0RfgFgPx7o/7a2ApfFsH8OgStnR5jtASldqeIDSAaX/Vth866csXxj HMVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n+Ge6rnIct/GoC9BtBwvW8UCLmza8AIm9rvjBMbnzxk=; b=bMEm/atU+QiZcDc02lHUTAc1oV6J23J/O0wiRCjl1O12CemiPneFlOBE6K0EMIkhnH ZO8wsVRdjXzgQ4weRYOxvMLx86Vgkgz7TL6W+Sb5+gdbeXhaj8Yh9ZsIY0bh4zRp2YJf 9SekzrOwM1owIbxEObSBZupe3P/RDyKO12lDnqktTqKvvyOA8rRPtyrT2UDrBx0OSqp4 A6syqXIt4jAI4bUDx23LTfQi9+i0IUnJRHUJfp5AAmIrzDtmIEjj6ncgh20/FDflAzNd e38dpjKky6eVSuy0/KJPRSwTsZYA5dZUu4TMjt80P4/HQZm6XQ3sVNK+Hv9Dy/xMjBbI Wv2w== X-Gm-Message-State: AFqh2kpWpFdP6nxp7OfXjQg45i37XcwVPhtFIcyWwT3T9kRC6XIAg9RP LvwiZV9uisYYdp3KEl7uk8E1Dw== X-Google-Smtp-Source: AMrXdXsWDkVHCCi69PBMxlEVbknmi0LflKaJllrUt7x04A8KmpE3PHZoKiRBLs8RNiroYgUhqbT2xg== X-Received: by 2002:a05:6a20:ce4b:b0:b2:ed11:284e with SMTP id id11-20020a056a20ce4b00b000b2ed11284emr15960245pzb.52.1672159247556; Tue, 27 Dec 2022 08:40:47 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id c14-20020a621c0e000000b0056bcb102e7bsm8821156pfc.68.2022.12.27.08.40.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Dec 2022 08:40:47 -0800 (PST) Date: Tue, 27 Dec 2022 08:40:45 -0800 From: Stephen Hemminger To: Mingjin Ye Cc: dev@dpdk.org, qiming.yang@intel.com, stable@dpdk.org, yidingx.zhou@intel.com, Qi Zhang , Ranjit Menon , Ferruh Yigit , Jie Zhou , Pallavi Kadam Subject: Re: [PATCH v7] doc: add PMD known issue Message-ID: <20221227084045.128da9d1@hermes.local> In-Reply-To: <20221227090040.38394-1-mingjinx.ye@intel.com> References: <20221121025443.190608-1-mingjinx.ye@intel.com> <20221227090040.38394-1-mingjinx.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, 27 Dec 2022 17:00:40 +0800 Mingjin Ye wrote: > + > +ice: Rx path is not supported after PF or DCF add vlan offload > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +If pmd does not enable Vlan offload during initialization, it will > +automatically select Rx paths that do not support offload. Even if > +Vlan offload is subsequently enabled through the API, Vlan offload > +will not work because the selected Rx path does not support Vlan > +offload. > + > +cmd_vlan_offload_parsed() goes down to the follow ethdev API functions: > + - rte_eth_dev_set_vlan_strip_on_queue() > + - rte_eth_dev_set_vlan_offload() > + > +These functions add offload settings when the port is started, running > +and processing traffic. At this time, ``rte_eth_rx_queue_setup`` api is > +needed to reroute rxq to the RX path with offload function. But at this > +time, it is possible that the original Rx path is handling packages, so > +this is not thread-safe. > + > +When applying offload on the PF or DCF, starting the ``testpmd`` > +application, use the ``--rx-offloads`` startup parameter to force the > +dpdk lib to choose the Rx path with the offload function by default. > + This seems like just making excuses in the documentation for something that should be fixed instead. This situation is probably common to many PMD's. Ideally, the drivers should reject changes to settings after device is started if they can not support it.