* [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
@ 2023-01-28 7:15 Kaiwen Deng
2023-02-02 6:09 ` Yang, Qiming
2023-02-02 6:29 ` Peng, Yuan
0 siblings, 2 replies; 6+ messages in thread
From: Kaiwen Deng @ 2023-01-28 7:15 UTC (permalink / raw)
To: dev
Cc: stable, yidingx.zhou, Kaiwen Deng, Qiming Yang, Wenjun Wu,
Wei Zhao, Beilei Xing, Wenzhuo Lu, Wei Dai
Add IPv6 addr mask and L4 mask support for rte_flow APIs.
IPv6 flow rules do not take effect in ixgbe when set
IPv6 addr mask and L4 mask to default value as 0xFF.
Set IPv6 addr mask and L4 mask as 0 to enable fields
can fix this issue.
Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
Cc: stable@dpdk.org
Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
drivers/net/ixgbe/ixgbe_flow.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index 110ff34fcc..d2ba87df27 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -1645,6 +1645,10 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,
memset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask));
rule->mask.vlan_tci_mask = 0;
rule->mask.flex_bytes_mask = 0;
+ rule->mask.dst_port_mask = 0;
+ rule->mask.src_port_mask = 0;
+ rule->mask.src_ipv6_mask = 0;
+ rule->mask.dst_ipv6_mask = 0;
/**
* The first not void item should be
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
2023-01-28 7:15 [PATCH] net/ixgbe: enable IPv6 mask for generic flow API Kaiwen Deng
@ 2023-02-02 6:09 ` Yang, Qiming
2023-02-02 6:52 ` Deng, KaiwenX
2023-02-02 6:29 ` Peng, Yuan
1 sibling, 1 reply; 6+ messages in thread
From: Yang, Qiming @ 2023-02-02 6:09 UTC (permalink / raw)
To: Deng, KaiwenX, dev
Cc: stable, Zhou, YidingX, Wu, Wenjun1, Zhao1, Wei, Xing, Beilei, Lu,
Wenzhuo, Dai, Wei
Hi, Kaiwen
The code looks good to me.
Can you ask someone to test this behavior and add a tested-by?
Qiming
> -----Original Message-----
> From: Deng, KaiwenX <kaiwenx.deng@intel.com>
> Sent: Saturday, January 28, 2023 3:15 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Deng,
> KaiwenX <kaiwenx.deng@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>; Zhao1,
> Wei <wei.zhao1@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Lu,
> Wenzhuo <wenzhuo.lu@intel.com>; Dai, Wei <wei.dai@intel.com>
> Subject: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
>
> Add IPv6 addr mask and L4 mask support for rte_flow APIs.
>
> IPv6 flow rules do not take effect in ixgbe when set
> IPv6 addr mask and L4 mask to default value as 0xFF.
>
> Set IPv6 addr mask and L4 mask as 0 to enable fields can fix this issue.
>
> Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_flow.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
> index 110ff34fcc..d2ba87df27 100644
> --- a/drivers/net/ixgbe/ixgbe_flow.c
> +++ b/drivers/net/ixgbe/ixgbe_flow.c
> @@ -1645,6 +1645,10 @@ ixgbe_parse_fdir_filter_normal(struct
> rte_eth_dev *dev,
> memset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask));
> rule->mask.vlan_tci_mask = 0;
> rule->mask.flex_bytes_mask = 0;
> + rule->mask.dst_port_mask = 0;
> + rule->mask.src_port_mask = 0;
> + rule->mask.src_ipv6_mask = 0;
> + rule->mask.dst_ipv6_mask = 0;
>
> /**
> * The first not void item should be
> --
> 2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
2023-01-28 7:15 [PATCH] net/ixgbe: enable IPv6 mask for generic flow API Kaiwen Deng
2023-02-02 6:09 ` Yang, Qiming
@ 2023-02-02 6:29 ` Peng, Yuan
1 sibling, 0 replies; 6+ messages in thread
From: Peng, Yuan @ 2023-02-02 6:29 UTC (permalink / raw)
To: Deng, KaiwenX, dev
Cc: stable, Zhou, YidingX, Deng, KaiwenX, Yang, Qiming, Wu, Wenjun1,
Zhao1, Wei, Xing, Beilei, Lu, Wenzhuo, Dai, Wei
> -----Original Message-----
> From: Kaiwen Deng <kaiwenx.deng@intel.com>
> Sent: Saturday, January 28, 2023 3:15 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Deng,
> KaiwenX <kaiwenx.deng@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>; Zhao1,
> Wei <wei.zhao1@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Lu,
> Wenzhuo <wenzhuo.lu@intel.com>; Dai, Wei <wei.dai@intel.com>
> Subject: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
>
> Add IPv6 addr mask and L4 mask support for rte_flow APIs.
>
> IPv6 flow rules do not take effect in ixgbe when set
> IPv6 addr mask and L4 mask to default value as 0xFF.
>
> Set IPv6 addr mask and L4 mask as 0 to enable fields can fix this issue.
>
> Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> ---
Tested-by: Yuan Peng <yuan.peng@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
2023-02-02 6:09 ` Yang, Qiming
@ 2023-02-02 6:52 ` Deng, KaiwenX
2023-02-07 6:41 ` Yang, Qiming
0 siblings, 1 reply; 6+ messages in thread
From: Deng, KaiwenX @ 2023-02-02 6:52 UTC (permalink / raw)
To: Yang, Qiming, dev
Cc: stable, Zhou, YidingX, Wu, Wenjun1, Zhao1, Wei, Xing, Beilei, Lu,
Wenzhuo, Dai, Wei
> -----Original Message-----
> From: Yang, Qiming <qiming.yang@intel.com>
> Sent: Thursday, February 2, 2023 2:10 PM
> To: Deng, KaiwenX <kaiwenx.deng@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Wu,
> Wenjun1 <wenjun1.wu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> Dai, Wei <wei.dai@intel.com>
> Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
>
> Hi, Kaiwen
>
> The code looks good to me.
> Can you ask someone to test this behavior and add a tested-by?
>
> Qiming
>
Hi,Qiming
Peng Yuan just added tested-by.
Kaiwen
> > -----Original Message-----
> > From: Deng, KaiwenX <kaiwenx.deng@intel.com>
> > Sent: Saturday, January 28, 2023 3:15 PM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Deng,
> > KaiwenX <kaiwenx.deng@intel.com>; Yang, Qiming
> > <qiming.yang@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>;
> Zhao1,
> > Wei <wei.zhao1@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Lu,
> > Wenzhuo <wenzhuo.lu@intel.com>; Dai, Wei <wei.dai@intel.com>
> > Subject: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
> >
> > Add IPv6 addr mask and L4 mask support for rte_flow APIs.
> >
> > IPv6 flow rules do not take effect in ixgbe when set
> > IPv6 addr mask and L4 mask to default value as 0xFF.
> >
> > Set IPv6 addr mask and L4 mask as 0 to enable fields can fix this issue.
> >
> > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_flow.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_flow.c
> > b/drivers/net/ixgbe/ixgbe_flow.c index 110ff34fcc..d2ba87df27 100644
> > --- a/drivers/net/ixgbe/ixgbe_flow.c
> > +++ b/drivers/net/ixgbe/ixgbe_flow.c
> > @@ -1645,6 +1645,10 @@ ixgbe_parse_fdir_filter_normal(struct
> > rte_eth_dev *dev,
> > memset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask));
> > rule->mask.vlan_tci_mask = 0;
> > rule->mask.flex_bytes_mask = 0;
> > + rule->mask.dst_port_mask = 0;
> > + rule->mask.src_port_mask = 0;
> > + rule->mask.src_ipv6_mask = 0;
> > + rule->mask.dst_ipv6_mask = 0;
> >
> > /**
> > * The first not void item should be
> > --
> > 2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
2023-02-02 6:52 ` Deng, KaiwenX
@ 2023-02-07 6:41 ` Yang, Qiming
2023-02-08 3:23 ` Zhang, Qi Z
0 siblings, 1 reply; 6+ messages in thread
From: Yang, Qiming @ 2023-02-07 6:41 UTC (permalink / raw)
To: Deng, KaiwenX, dev
Cc: stable, Zhou, YidingX, Wu, Wenjun1, Zhao1, Wei, Xing, Beilei, Lu,
Wenzhuo, Dai, Wei
Hi,
> -----Original Message-----
> From: Deng, KaiwenX <kaiwenx.deng@intel.com>
> Sent: Thursday, February 2, 2023 2:53 PM
> To: Yang, Qiming <qiming.yang@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Wu,
> Wenjun1 <wenjun1.wu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> Dai, Wei <wei.dai@intel.com>
> Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
>
>
>
> > -----Original Message-----
> > From: Yang, Qiming <qiming.yang@intel.com>
> > Sent: Thursday, February 2, 2023 2:10 PM
> > To: Deng, KaiwenX <kaiwenx.deng@intel.com>; dev@dpdk.org
> > Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Wu,
> > Wenjun1 <wenjun1.wu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>;
> > Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo
> > <wenzhuo.lu@intel.com>; Dai, Wei <wei.dai@intel.com>
> > Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
> >
> > Hi, Kaiwen
> >
> > The code looks good to me.
> > Can you ask someone to test this behavior and add a tested-by?
> >
> > Qiming
> >
> Hi,Qiming
>
> Peng Yuan just added tested-by.
>
> Kaiwen
> > > -----Original Message-----
> > > From: Deng, KaiwenX <kaiwenx.deng@intel.com>
> > > Sent: Saturday, January 28, 2023 3:15 PM
> > > To: dev@dpdk.org
> > > Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Deng,
> > > KaiwenX <kaiwenx.deng@intel.com>; Yang, Qiming
> > > <qiming.yang@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>;
> > Zhao1,
> > > Wei <wei.zhao1@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Lu,
> > > Wenzhuo <wenzhuo.lu@intel.com>; Dai, Wei <wei.dai@intel.com>
> > > Subject: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
> > >
> > > Add IPv6 addr mask and L4 mask support for rte_flow APIs.
> > >
> > > IPv6 flow rules do not take effect in ixgbe when set
> > > IPv6 addr mask and L4 mask to default value as 0xFF.
> > >
> > > Set IPv6 addr mask and L4 mask as 0 to enable fields can fix this issue.
> > >
> > > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> > > ---
> > > drivers/net/ixgbe/ixgbe_flow.c | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/drivers/net/ixgbe/ixgbe_flow.c
> > > b/drivers/net/ixgbe/ixgbe_flow.c index 110ff34fcc..d2ba87df27 100644
> > > --- a/drivers/net/ixgbe/ixgbe_flow.c
> > > +++ b/drivers/net/ixgbe/ixgbe_flow.c
> > > @@ -1645,6 +1645,10 @@ ixgbe_parse_fdir_filter_normal(struct
> > > rte_eth_dev *dev,
> > > memset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask));
> > > rule->mask.vlan_tci_mask = 0;
> > > rule->mask.flex_bytes_mask = 0;
> > > + rule->mask.dst_port_mask = 0;
> > > + rule->mask.src_port_mask = 0;
> > > + rule->mask.src_ipv6_mask = 0;
> > > + rule->mask.dst_ipv6_mask = 0;
> > >
> > > /**
> > > * The first not void item should be
> > > --
> > > 2.34.1
Acked-by: Qiming Yang <qiming.yang@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
2023-02-07 6:41 ` Yang, Qiming
@ 2023-02-08 3:23 ` Zhang, Qi Z
0 siblings, 0 replies; 6+ messages in thread
From: Zhang, Qi Z @ 2023-02-08 3:23 UTC (permalink / raw)
To: Yang, Qiming, Deng, KaiwenX, dev
Cc: stable, Zhou, YidingX, Wu, Wenjun1, Zhao1, Wei, Xing, Beilei, Lu,
Wenzhuo, Dai, Wei
> -----Original Message-----
> From: Yang, Qiming <qiming.yang@intel.com>
> Sent: Tuesday, February 7, 2023 2:41 PM
> To: Deng, KaiwenX <kaiwenx.deng@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Wu,
> Wenjun1 <wenjun1.wu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> Dai, Wei <wei.dai@intel.com>
> Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
>
> Hi,
>
> > -----Original Message-----
> > From: Deng, KaiwenX <kaiwenx.deng@intel.com>
> > Sent: Thursday, February 2, 2023 2:53 PM
> > To: Yang, Qiming <qiming.yang@intel.com>; dev@dpdk.org
> > Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Wu,
> > Wenjun1 <wenjun1.wu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>;
> > Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo
> > <wenzhuo.lu@intel.com>; Dai, Wei <wei.dai@intel.com>
> > Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
> >
> >
> >
> > > -----Original Message-----
> > > From: Yang, Qiming <qiming.yang@intel.com>
> > > Sent: Thursday, February 2, 2023 2:10 PM
> > > To: Deng, KaiwenX <kaiwenx.deng@intel.com>; dev@dpdk.org
> > > Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Wu,
> > > Wenjun1 <wenjun1.wu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>;
> > > Xing, Beilei <beilei.xing@intel.com>; Lu, Wenzhuo
> > > <wenzhuo.lu@intel.com>; Dai, Wei <wei.dai@intel.com>
> > > Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow
> > > API
> > >
> > > Hi, Kaiwen
> > >
> > > The code looks good to me.
> > > Can you ask someone to test this behavior and add a tested-by?
> > >
> > > Qiming
> > >
> > Hi,Qiming
> >
> > Peng Yuan just added tested-by.
> >
> > Kaiwen
> > > > -----Original Message-----
> > > > From: Deng, KaiwenX <kaiwenx.deng@intel.com>
> > > > Sent: Saturday, January 28, 2023 3:15 PM
> > > > To: dev@dpdk.org
> > > > Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Deng,
> > > > KaiwenX <kaiwenx.deng@intel.com>; Yang, Qiming
> > > > <qiming.yang@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>;
> > > Zhao1,
> > > > Wei <wei.zhao1@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> > > > Lu, Wenzhuo <wenzhuo.lu@intel.com>; Dai, Wei <wei.dai@intel.com>
> > > > Subject: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API
> > > >
> > > > Add IPv6 addr mask and L4 mask support for rte_flow APIs.
> > > >
> > > > IPv6 flow rules do not take effect in ixgbe when set
> > > > IPv6 addr mask and L4 mask to default value as 0xFF.
> > > >
> > > > Set IPv6 addr mask and L4 mask as 0 to enable fields can fix this issue.
> > > >
> > > > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> > > > ---
> > > > drivers/net/ixgbe/ixgbe_flow.c | 4 ++++
> > > > 1 file changed, 4 insertions(+)
> > > >
> > > > diff --git a/drivers/net/ixgbe/ixgbe_flow.c
> > > > b/drivers/net/ixgbe/ixgbe_flow.c index 110ff34fcc..d2ba87df27
> > > > 100644
> > > > --- a/drivers/net/ixgbe/ixgbe_flow.c
> > > > +++ b/drivers/net/ixgbe/ixgbe_flow.c
> > > > @@ -1645,6 +1645,10 @@ ixgbe_parse_fdir_filter_normal(struct
> > > > rte_eth_dev *dev,
> > > > memset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask));
> > > > rule->mask.vlan_tci_mask = 0;
> > > > rule->mask.flex_bytes_mask = 0;
> > > > + rule->mask.dst_port_mask = 0;
> > > > + rule->mask.src_port_mask = 0;
> > > > + rule->mask.src_ipv6_mask = 0;
> > > > + rule->mask.dst_ipv6_mask = 0;
> > > >
> > > > /**
> > > > * The first not void item should be
> > > > --
> > > > 2.34.1
>
> Acked-by: Qiming Yang <qiming.yang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-02-08 3:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-28 7:15 [PATCH] net/ixgbe: enable IPv6 mask for generic flow API Kaiwen Deng
2023-02-02 6:09 ` Yang, Qiming
2023-02-02 6:52 ` Deng, KaiwenX
2023-02-07 6:41 ` Yang, Qiming
2023-02-08 3:23 ` Zhang, Qi Z
2023-02-02 6:29 ` Peng, Yuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).