* [PATCH] test/mbuf: fix mbuf_autotest retest fail
@ 2023-01-31 2:48 Jie Hai
2023-02-07 13:21 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Jie Hai @ 2023-01-31 2:48 UTC (permalink / raw)
To: olivier.matz; +Cc: liudongdong3, haijie1, dev, stable
Retest "mbuf_autotest" will fail because the mbuf pool was
not freed after previous test successful done.
This patch fixes it.
Fixes: efc6f9104c80 ("mbuf: fix reset on mbuf free")
Cc: stable@dpdk.org
Signed-off-by: Jie Hai <haijie1@huawei.com>
---
app/test/test_mbuf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 53fe898a384c..6cbb03b0afaa 100644
--- a/app/test/test_mbuf.c
+++ b/app/test/test_mbuf.c
@@ -2764,6 +2764,7 @@ test_nb_segs_and_next_reset(void)
m2->nb_segs != 1 || m2->next != NULL)
GOTO_FAIL("nb_segs or next was not reset properly");
+ rte_mempool_free(pool);
return 0;
fail:
--
2.30.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] test/mbuf: fix mbuf_autotest retest fail
2023-01-31 2:48 [PATCH] test/mbuf: fix mbuf_autotest retest fail Jie Hai
@ 2023-02-07 13:21 ` David Marchand
2023-02-10 11:57 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2023-02-07 13:21 UTC (permalink / raw)
To: Jie Hai; +Cc: olivier.matz, liudongdong3, dev, stable
On Tue, Jan 31, 2023 at 3:52 AM Jie Hai <haijie1@huawei.com> wrote:
>
> Retest "mbuf_autotest" will fail because the mbuf pool was
> not freed after previous test successful done.
> This patch fixes it.
Good catch.
>
> Fixes: efc6f9104c80 ("mbuf: fix reset on mbuf free")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jie Hai <haijie1@huawei.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] test/mbuf: fix mbuf_autotest retest fail
2023-02-07 13:21 ` David Marchand
@ 2023-02-10 11:57 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2023-02-10 11:57 UTC (permalink / raw)
To: Jie Hai; +Cc: olivier.matz, liudongdong3, dev, stable
On Tue, Feb 7, 2023 at 2:21 PM David Marchand <david.marchand@redhat.com> wrote:
> On Tue, Jan 31, 2023 at 3:52 AM Jie Hai <haijie1@huawei.com> wrote:
> >
> > Retest "mbuf_autotest" will fail because the mbuf pool was
> > not freed after previous test successful done.
> > This patch fixes it.
> >
> > Fixes: efc6f9104c80 ("mbuf: fix reset on mbuf free")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jie Hai <haijie1@huawei.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-10 11:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-31 2:48 [PATCH] test/mbuf: fix mbuf_autotest retest fail Jie Hai
2023-02-07 13:21 ` David Marchand
2023-02-10 11:57 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).