From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD9D341B8A for ; Tue, 31 Jan 2023 08:24:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C24DA40E28; Tue, 31 Jan 2023 08:24:34 +0100 (CET) Received: from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80]) by mails.dpdk.org (Postfix) with ESMTP id 26FB340DFB; Tue, 31 Jan 2023 08:24:33 +0100 (CET) Received: from localhost.localdomain (unknown [78.109.72.147]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by agw.arknetworks.am (Postfix) with ESMTPSA id 836CFE002F; Tue, 31 Jan 2023 11:24:32 +0400 (+04) From: Ivan Malov To: dev@dpdk.org Cc: Andrew Rybchenko , stable@dpdk.org, Andy Moreton , Viacheslav Galaktionov Subject: [PATCH] net/sfc: export pick transfer proxy callback to representors Date: Tue, 31 Jan 2023 11:24:44 +0400 Message-Id: <20230131072444.6925-1-ivan.malov@arknetworks.am> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Currently, the "pick transfer proxy ethdev" callback is only advertised for non-representor (in example, main PF) ethdevs. That does not sit well with the original idea of this method, which is to let applications discover the privileged port to use for transfer flow management instead of any given ethdev. Applications trying to leverage this API on sfc representors receive an error and cannot configure transfer flow offloads. Fix the problem by exporting the method to representor ports. Fixes: 26706314d418 ("net/sfc: implement transfer proxy port callback") Cc: stable@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andy Moreton Reviewed-by: Viacheslav Galaktionov --- drivers/net/sfc/sfc_flow.c | 4 ++++ drivers/net/sfc/sfc_flow.h | 2 ++ drivers/net/sfc/sfc_repr.c | 10 ++++++++++ 3 files changed, 16 insertions(+) diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c index fb59abd0b5..2937953959 100644 --- a/drivers/net/sfc/sfc_flow.c +++ b/drivers/net/sfc/sfc_flow.c @@ -2806,6 +2806,10 @@ const struct rte_flow_ops sfc_flow_ops = { .pick_transfer_proxy = sfc_flow_pick_transfer_proxy, }; +const struct rte_flow_ops sfc_repr_flow_ops = { + .pick_transfer_proxy = sfc_flow_pick_transfer_proxy, +}; + void sfc_flow_init(struct sfc_adapter *sa) { diff --git a/drivers/net/sfc/sfc_flow.h b/drivers/net/sfc/sfc_flow.h index 12875344b5..2b1e5a2ff6 100644 --- a/drivers/net/sfc/sfc_flow.h +++ b/drivers/net/sfc/sfc_flow.h @@ -107,6 +107,8 @@ TAILQ_HEAD(sfc_flow_list, rte_flow); extern const struct rte_flow_ops sfc_flow_ops; +extern const struct rte_flow_ops sfc_repr_flow_ops; + enum sfc_flow_item_layers { SFC_FLOW_ITEM_ANY_LAYER, SFC_FLOW_ITEM_START_LAYER, diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c index 417d0073cb..6b1d5492a9 100644 --- a/drivers/net/sfc/sfc_repr.c +++ b/drivers/net/sfc/sfc_repr.c @@ -18,6 +18,7 @@ #include "sfc_log.h" #include "sfc_debug.h" +#include "sfc_flow.h" #include "sfc_repr.h" #include "sfc_ethdev_state.h" #include "sfc_repr_proxy_api.h" @@ -888,6 +889,14 @@ sfc_repr_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) return 0; } +static int +sfc_repr_dev_flow_ops_get(struct rte_eth_dev *dev __rte_unused, + const struct rte_flow_ops **ops) +{ + *ops = &sfc_repr_flow_ops; + return 0; +} + static const struct eth_dev_ops sfc_repr_dev_ops = { .dev_configure = sfc_repr_dev_configure, .dev_start = sfc_repr_dev_start, @@ -901,6 +910,7 @@ static const struct eth_dev_ops sfc_repr_dev_ops = { .rx_queue_release = sfc_repr_rx_queue_release, .tx_queue_setup = sfc_repr_tx_queue_setup, .tx_queue_release = sfc_repr_tx_queue_release, + .flow_ops_get = sfc_repr_dev_flow_ops_get, }; -- 2.30.2