* [dpdk-dev] [PATCH 1/3] common/cnxk: fix channel mask for SDP interfaces
@ 2023-02-10 4:21 psatheesh
2023-02-10 4:21 ` [dpdk-dev] [PATCH 2/3] common/cnxk: fix printing IPsec flow rules psatheesh
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: psatheesh @ 2023-02-10 4:21 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, Satheesh Paul, stable
From: Satheesh Paul <psatheesh@marvell.com>
Fix channel mask of SDP interfaces on CN10K.
Fixes: f137566333 ("common/cnxk: support setting channel mask for SDP interfaces")
Cc: stable@dpdk.org
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
---
drivers/common/cnxk/roc_npc.c | 9 +++++++--
drivers/common/cnxk/roc_npc_priv.h | 3 +++
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c
index c872548230..9edccb5258 100644
--- a/drivers/common/cnxk/roc_npc.c
+++ b/drivers/common/cnxk/roc_npc.c
@@ -1380,8 +1380,13 @@ roc_npc_flow_create(struct roc_npc *roc_npc, const struct roc_npc_attr *attr,
/* By default set the channel and mask to cover
* the whole SDP channel range.
*/
- npc->sdp_channel = (uint16_t)NIX_CHAN_SDP_CH_START;
- npc->sdp_channel_mask = (uint16_t)NIX_CHAN_SDP_CH_START;
+ if (roc_model_is_cn10k()) {
+ npc->sdp_channel = (uint16_t)CN10K_SDP_CH_START;
+ npc->sdp_channel_mask = (uint16_t)CN10K_SDP_CH_MASK;
+ } else {
+ npc->sdp_channel = (uint16_t)NIX_CHAN_SDP_CH_START;
+ npc->sdp_channel_mask = (uint16_t)NIX_CHAN_SDP_CH_START;
+ }
}
}
diff --git a/drivers/common/cnxk/roc_npc_priv.h b/drivers/common/cnxk/roc_npc_priv.h
index 2a7d3137fb..aa27228354 100644
--- a/drivers/common/cnxk/roc_npc_priv.h
+++ b/drivers/common/cnxk/roc_npc_priv.h
@@ -77,6 +77,9 @@
#define NPC_LFLAG_LC_OFFSET (NPC_LTYPE_OFFSET_START + 6)
#define NPC_LTYPE_LC_OFFSET (NPC_LTYPE_OFFSET_START + 8)
+#define CN10K_SDP_CH_START 0x80
+#define CN10K_SDP_CH_MASK 0xF80
+
struct npc_action_vtag_info {
uint16_t vlan_id;
uint16_t vlan_ethtype;
--
2.35.3
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH 2/3] common/cnxk: fix printing IPsec flow rules
2023-02-10 4:21 [dpdk-dev] [PATCH 1/3] common/cnxk: fix channel mask for SDP interfaces psatheesh
@ 2023-02-10 4:21 ` psatheesh
2023-02-10 4:21 ` [dpdk-dev] [PATCH 3/3] common/cnxk: fix inline IPsec rule creation psatheesh
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: psatheesh @ 2023-02-10 4:21 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, Satheesh Paul, stable, Jerin Jacob
From: Satheesh Paul <psatheesh@marvell.com>
When dumping flow data, dump preallocated IPsec rules also.
Fixes: 1aa86a170e ("drivers: support IPsec rule reservation scheme")
Cc: stable@dpdk.org
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Jerin Jacob <jerinj@marvell.com>
Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
---
drivers/common/cnxk/roc_npc.c | 7 +-
drivers/common/cnxk/roc_npc_mcam_dump.c | 154 ++++++++++++++++++------
2 files changed, 120 insertions(+), 41 deletions(-)
diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c
index 9edccb5258..579b3dce9a 100644
--- a/drivers/common/cnxk/roc_npc.c
+++ b/drivers/common/cnxk/roc_npc.c
@@ -1550,11 +1550,14 @@ roc_npc_flow_dump(FILE *file, struct roc_npc *roc_npc)
roc_npc_flow_mcam_dump(file, roc_npc, flow_iter);
}
}
+
+ TAILQ_FOREACH(flow_iter, &npc->ipsec_list, next) {
+ roc_npc_flow_mcam_dump(file, roc_npc, flow_iter);
+ }
}
int
-roc_npc_mcam_merge_base_steering_rule(struct roc_npc *roc_npc,
- struct roc_npc_flow *flow)
+roc_npc_mcam_merge_base_steering_rule(struct roc_npc *roc_npc, struct roc_npc_flow *flow)
{
struct npc_mcam_read_base_rule_rsp *base_rule_rsp;
struct npc *npc = roc_npc_to_npc_priv(roc_npc);
diff --git a/drivers/common/cnxk/roc_npc_mcam_dump.c b/drivers/common/cnxk/roc_npc_mcam_dump.c
index 40909b45e6..a88e166fbe 100644
--- a/drivers/common/cnxk/roc_npc_mcam_dump.c
+++ b/drivers/common/cnxk/roc_npc_mcam_dump.c
@@ -73,43 +73,93 @@ static const char *const ltype_str[NPC_MAX_LID][NPC_MAX_LT] = {
[NPC_LID_LA][NPC_LT_LA_CPT_HDR] = "LA_CPT_HDR",
[NPC_LID_LA][NPC_LT_LA_CUSTOM_L2_24B_ETHER] = "LA_CUSTOM_L2_24B_ETHER",
[NPC_LID_LA][NPC_LT_LA_CUSTOM_PRE_L2_ETHER] = "NPC_LT_LA_CUSTOM_PRE_L2_ETHER",
+ [NPC_LID_LA][NPC_LT_LA_CUSTOM0] = "NPC_LT_LA_CUSTOM0",
+ [NPC_LID_LA][NPC_LT_LA_CUSTOM1] = "NPC_LT_LA_CUSTOM1",
[NPC_LID_LB][0] = "NONE",
+ [NPC_LID_LB][NPC_LT_LB_ETAG] = "LB_ETAG",
[NPC_LID_LB][NPC_LT_LB_CTAG] = "LB_CTAG",
[NPC_LID_LB][NPC_LT_LB_STAG_QINQ] = "LB_STAG_QINQ",
- [NPC_LID_LB][NPC_LT_LB_ETAG] = "LB_ETAG",
+ [NPC_LID_LB][NPC_LT_LB_BTAG] = "LB_BTAG",
+ [NPC_LID_LB][NPC_LT_LB_PPPOE] = "LB_PPPOE",
+ [NPC_LID_LB][NPC_LT_LB_DSA] = "LB_DSA",
+ [NPC_LID_LB][NPC_LT_LB_DSA_VLAN] = "LB_DSA_VLAN",
+ [NPC_LID_LB][NPC_LT_LB_EDSA] = "LB_EDSA",
+ [NPC_LID_LB][NPC_LT_LB_EDSA_VLAN] = "LB_EDSA_VLAN",
[NPC_LID_LB][NPC_LT_LB_EXDSA] = "LB_EXDSA",
+ [NPC_LID_LB][NPC_LT_LB_EXDSA_VLAN] = "LB_EXDSA_VLAN",
+ [NPC_LID_LB][NPC_LT_LB_FDSA] = "LB_FDSA",
[NPC_LID_LB][NPC_LT_LB_VLAN_EXDSA] = "LB_VLAN_EXDSA",
+ [NPC_LID_LB][NPC_LT_LB_CUSTOM0] = "LB_CUSTOM0",
+ [NPC_LID_LB][NPC_LT_LB_CUSTOM1] = "LB_CUSTOM1",
[NPC_LID_LC][0] = "NONE",
+ [NPC_LID_LC][NPC_LT_LC_PTP] = "LC_PTP",
[NPC_LID_LC][NPC_LT_LC_IP] = "LC_IP",
+ [NPC_LID_LC][NPC_LT_LC_IP_OPT] = "LC_IP_OPT",
[NPC_LID_LC][NPC_LT_LC_IP6] = "LC_IP6",
- [NPC_LID_LC][NPC_LT_LC_ARP] = "LC_ARP",
[NPC_LID_LC][NPC_LT_LC_IP6_EXT] = "LC_IP6_EXT",
+ [NPC_LID_LC][NPC_LT_LC_ARP] = "LC_ARP",
+ [NPC_LID_LC][NPC_LT_LC_RARP] = "LC_RARP",
+ [NPC_LID_LC][NPC_LT_LC_MPLS] = "LC_MPLS",
+ [NPC_LID_LC][NPC_LT_LC_NSH] = "LC_NSH",
+ [NPC_LID_LC][NPC_LT_LC_FCOE] = "LC_FCOE",
[NPC_LID_LC][NPC_LT_LC_NGIO] = "LC_NGIO",
+ [NPC_LID_LC][NPC_LT_LC_CUSTOM0] = "LC_CUSTOM0",
+ [NPC_LID_LC][NPC_LT_LC_CUSTOM1] = "LC_CUSTOM1",
[NPC_LID_LD][0] = "NONE",
- [NPC_LID_LD][NPC_LT_LD_ICMP] = "LD_ICMP",
- [NPC_LID_LD][NPC_LT_LD_ICMP6] = "LD_ICMP6",
- [NPC_LID_LD][NPC_LT_LD_UDP] = "LD_UDP",
[NPC_LID_LD][NPC_LT_LD_TCP] = "LD_TCP",
+ [NPC_LID_LD][NPC_LT_LD_UDP] = "LD_UDP",
[NPC_LID_LD][NPC_LT_LD_SCTP] = "LD_SCTP",
+ [NPC_LID_LD][NPC_LT_LD_ICMP6] = "LD_ICMP6",
+ [NPC_LID_LD][NPC_LT_LD_CUSTOM0] = "LD_CUSTOM0",
+ [NPC_LID_LD][NPC_LT_LD_CUSTOM1] = "LD_CUSTOM1",
+ [NPC_LID_LD][NPC_LT_LD_IGMP] = "LD_IGMP",
+ [NPC_LID_LD][NPC_LT_LD_AH] = "LD_AH",
[NPC_LID_LD][NPC_LT_LD_GRE] = "LD_GRE",
[NPC_LID_LD][NPC_LT_LD_NVGRE] = "LD_NVGRE",
+ [NPC_LID_LD][NPC_LT_LD_NSH] = "LD_NSH",
+ [NPC_LID_LD][NPC_LT_LD_TU_MPLS_IN_NSH] = "LD_TU_MPLS_IN_NSH",
+ [NPC_LID_LD][NPC_LT_LD_TU_MPLS_IN_IP] = "LD_TU_MPLS_IN_IP",
+ [NPC_LID_LD][NPC_LT_LD_ICMP] = "LD_ICMP",
[NPC_LID_LE][0] = "NONE",
[NPC_LID_LE][NPC_LT_LE_VXLAN] = "LE_VXLAN",
+ [NPC_LID_LE][NPC_LT_LE_GENEVE] = "LE_GENEVE",
[NPC_LID_LE][NPC_LT_LE_ESP] = "LE_ESP",
- [NPC_LID_LE][NPC_LT_LE_GTPC] = "LE_GTPC",
[NPC_LID_LE][NPC_LT_LE_GTPU] = "LE_GTPU",
- [NPC_LID_LE][NPC_LT_LE_GENEVE] = "LE_GENEVE",
[NPC_LID_LE][NPC_LT_LE_VXLANGPE] = "LE_VXLANGPE",
+ [NPC_LID_LE][NPC_LT_LE_GTPC] = "LE_GTPC",
+ [NPC_LID_LE][NPC_LT_LE_NSH] = "LE_NSH",
+ [NPC_LID_LE][NPC_LT_LE_TU_MPLS_IN_GRE] = "LE_TU_MPLS_IN_GRE",
+ [NPC_LID_LE][NPC_LT_LE_TU_NSH_IN_GRE] = "LE_TU_NSH_IN_GRE",
+ [NPC_LID_LE][NPC_LT_LE_TU_MPLS_IN_UDP] = "LE_TU_MPLS_IN_UDP",
+ [NPC_LID_LE][NPC_LT_LE_CUSTOM0] = "LE_CUSTOM0",
+ [NPC_LID_LE][NPC_LT_LE_CUSTOM1] = "LE_CUSTOM1",
[NPC_LID_LF][0] = "NONE",
[NPC_LID_LF][NPC_LT_LF_TU_ETHER] = "LF_TU_ETHER",
+ [NPC_LID_LF][NPC_LT_LF_TU_PPP] = "LF_TU_PPP",
+ [NPC_LID_LF][NPC_LT_LF_TU_MPLS_IN_VXLANGPE] = "LF_TU_MPLS_IN_VXLANGPE",
+ [NPC_LID_LF][NPC_LT_LF_TU_NSH_IN_VXLANGPE] = "LF_TU_NSH_IN_VXLANGPE",
+ [NPC_LID_LF][NPC_LT_LF_TU_MPLS_IN_NSH] = "LF_TU_MPLS_IN_NSH",
+ [NPC_LID_LF][NPC_LT_LF_TU_3RD_NSH] = "LF_TU_3RD_NSH",
+ [NPC_LID_LF][NPC_LT_LF_CUSTOM0] = "LF_CUSTOM0",
+ [NPC_LID_LF][NPC_LT_LF_CUSTOM1] = "LF_CUSTOM1",
[NPC_LID_LG][0] = "NONE",
[NPC_LID_LG][NPC_LT_LG_TU_IP] = "LG_TU_IP",
[NPC_LID_LG][NPC_LT_LG_TU_IP6] = "LG_TU_IP6",
+ [NPC_LID_LG][NPC_LT_LG_TU_ARP] = "LG_TU_ARP",
+ [NPC_LID_LG][NPC_LT_LG_TU_ETHER_IN_NSH] = "LG_TU_ETHER_IN_NSH",
+ [NPC_LID_LG][NPC_LT_LG_CUSTOM0] = "LG_CUSTOM0",
+ [NPC_LID_LG][NPC_LT_LG_CUSTOM1] = "LG_CUSTOM1",
[NPC_LID_LH][0] = "NONE",
- [NPC_LID_LH][NPC_LT_LH_TU_UDP] = "LH_TU_UDP",
[NPC_LID_LH][NPC_LT_LH_TU_TCP] = "LH_TU_TCP",
+ [NPC_LID_LH][NPC_LT_LH_TU_UDP] = "LH_TU_UDP",
[NPC_LID_LH][NPC_LT_LH_TU_SCTP] = "LH_TU_SCTP",
+ [NPC_LID_LH][NPC_LT_LH_TU_ICMP6] = "LH_TU_ICMP6",
+ [NPC_LID_LH][NPC_LT_LH_CUSTOM0] = "LH_CUSTOM0",
+ [NPC_LID_LH][NPC_LT_LH_CUSTOM1] = "LH_CUSTOM1",
+ [NPC_LID_LH][NPC_LT_LH_TU_IGMP] = "LH_TU_IGMP",
[NPC_LID_LH][NPC_LT_LH_TU_ESP] = "LH_TU_ESP",
+ [NPC_LID_LH][NPC_LT_LH_TU_AH] = "LH_TU_AH",
+ [NPC_LID_LH][NPC_LT_LH_TU_ICMP] = "LH_TU_ICMP",
};
static uint16_t
@@ -585,20 +635,71 @@ npc_flow_dump_vtag_action(FILE *file, uint64_t vtag_action, bool is_rx)
}
}
-void
-roc_npc_flow_mcam_dump(FILE *file, struct roc_npc *roc_npc,
- struct roc_npc_flow *flow)
+static void
+npc_flow_hw_mcam_entry_dump(FILE *file, struct npc *npc, struct roc_npc_flow *flow)
{
- struct npc *npc = roc_npc_to_npc_priv(roc_npc);
+ uint64_t mcam_data[ROC_NPC_MAX_MCAM_WIDTH_DWORDS];
+ uint64_t mcam_mask[ROC_NPC_MAX_MCAM_WIDTH_DWORDS];
struct npc_mcam_read_entry_req *mcam_read_req;
struct npc_mcam_read_entry_rsp *mcam_read_rsp;
+ struct nix_inl_dev *inl_dev = NULL;
+ struct idev_cfg *idev;
+ struct mbox *mbox;
+ int rc = 0, i;
+
+ idev = idev_get_cfg();
+ if (idev)
+ inl_dev = idev->nix_inl_dev;
+
+ if (inl_dev && flow->use_pre_alloc)
+ mbox = inl_dev->dev.mbox;
+ else
+ mbox = npc->mbox;
+
+ mcam_read_req = mbox_alloc_msg_npc_mcam_read_entry(mbox_get(mbox));
+ if (mcam_read_req == NULL) {
+ plt_err("Failed to alloc msg");
+ mbox_put(mbox);
+ return;
+ }
+
+ mcam_read_req->entry = flow->mcam_id;
+ rc = mbox_process_msg(mbox, (void *)&mcam_read_rsp);
+ if (rc) {
+ mbox_put(mbox);
+ plt_err("Failed to fetch MCAM entry:%d", flow->mcam_id);
+ return;
+ }
+
+ mbox_memcpy(mcam_data, mcam_read_rsp->entry_data.kw, sizeof(mcam_data));
+ mbox_memcpy(mcam_mask, mcam_read_rsp->entry_data.kw_mask, sizeof(mcam_data));
+
+ fprintf(file, "HW MCAM Data :\n");
+
+ for (i = 0; i < ROC_NPC_MAX_MCAM_WIDTH_DWORDS; i++) {
+ fprintf(file, "\tDW%d :%016lX\n", i, mcam_data[i]);
+ fprintf(file, "\tDW%d_Mask:%016lX\n", i, mcam_mask[i]);
+ }
+
+ fprintf(file, "\n");
+ mbox_put(mbox);
+}
+
+void
+roc_npc_flow_mcam_dump(FILE *file, struct roc_npc *roc_npc, struct roc_npc_flow *flow)
+{
+ struct npc *npc = roc_npc_to_npc_priv(roc_npc);
uint64_t count = 0;
bool is_rx = 0;
int i, rc = 0;
fprintf(file, "MCAM Index:%d\n", flow->mcam_id);
if (flow->ctr_id != NPC_COUNTER_NONE && flow->use_ctr) {
- rc = roc_npc_mcam_read_counter(roc_npc, flow->ctr_id, &count);
+ if (flow->use_pre_alloc)
+ rc = roc_npc_inl_mcam_read_counter(flow->ctr_id, &count);
+ else
+ rc = roc_npc_mcam_read_counter(roc_npc, flow->ctr_id, &count);
+
if (rc)
return;
fprintf(file, "Hit count: %" PRIu64 "\n", count);
@@ -622,30 +723,5 @@ roc_npc_flow_mcam_dump(FILE *file, struct roc_npc *roc_npc,
fprintf(file, "\tDW%d_Mask:%016lX\n", i, flow->mcam_mask[i]);
}
- mcam_read_req = mbox_alloc_msg_npc_mcam_read_entry(mbox_get(npc->mbox));
- if (mcam_read_req == NULL) {
- plt_err("Failed to alloc msg");
- mbox_put(npc->mbox);
- return;
- }
-
- mcam_read_req->entry = flow->mcam_id;
- rc = mbox_process_msg(npc->mbox, (void *)&mcam_read_rsp);
- if (rc) {
- mbox_put(npc->mbox);
- plt_err("Failed to fetch MCAM entry:%d", flow->mcam_id);
- return;
- }
-
- fprintf(file, "HW MCAM Data :\n");
-
- for (i = 0; i < ROC_NPC_MAX_MCAM_WIDTH_DWORDS; i++) {
- fprintf(file, "\tDW%d :%016lX\n", i,
- mcam_read_rsp->entry_data.kw[i]);
- fprintf(file, "\tDW%d_Mask:%016lX\n", i,
- mcam_read_rsp->entry_data.kw_mask[i]);
- }
-
- fprintf(file, "\n");
- mbox_put(npc->mbox);
+ npc_flow_hw_mcam_entry_dump(file, npc, flow);
}
--
2.35.3
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH 3/3] common/cnxk: fix inline IPsec rule creation
2023-02-10 4:21 [dpdk-dev] [PATCH 1/3] common/cnxk: fix channel mask for SDP interfaces psatheesh
2023-02-10 4:21 ` [dpdk-dev] [PATCH 2/3] common/cnxk: fix printing IPsec flow rules psatheesh
@ 2023-02-10 4:21 ` psatheesh
2023-02-10 8:08 ` [dpdk-dev] [PATCH 1/3] common/cnxk: fix channel mask for SDP interfaces Jerin Jacob
2023-02-10 8:26 ` [dpdk-dev] [PATCH v2 " psatheesh
3 siblings, 0 replies; 8+ messages in thread
From: psatheesh @ 2023-02-10 4:21 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, Satheesh Paul, stable
From: Satheesh Paul <psatheesh@marvell.com>
Use inline IPsec device to create IPsec rules irrespective
of RTE_ETH_RX_OFFLOAD_SECURITY offload flag.
Fixes: 1aa86a170e ("drivers: support IPsec rule reservation scheme")
Cc: stable@dpdk.org
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
---
drivers/common/cnxk/roc_npc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c
index 579b3dce9a..d3efebe663 100644
--- a/drivers/common/cnxk/roc_npc.c
+++ b/drivers/common/cnxk/roc_npc.c
@@ -562,8 +562,10 @@ npc_parse_actions(struct roc_npc *roc_npc, const struct roc_npc_attr *attr,
}
rq = inl_rq->qid;
pf_func = nix_inl_dev_pffunc_get();
- flow->is_inline_dev = 1;
}
+
+ if (roc_nix_inl_dev_is_probed())
+ flow->is_inline_dev = 1;
sec_action = actions;
break;
case ROC_NPC_ACTION_TYPE_VLAN_STRIP:
--
2.35.3
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 1/3] common/cnxk: fix channel mask for SDP interfaces
2023-02-10 4:21 [dpdk-dev] [PATCH 1/3] common/cnxk: fix channel mask for SDP interfaces psatheesh
2023-02-10 4:21 ` [dpdk-dev] [PATCH 2/3] common/cnxk: fix printing IPsec flow rules psatheesh
2023-02-10 4:21 ` [dpdk-dev] [PATCH 3/3] common/cnxk: fix inline IPsec rule creation psatheesh
@ 2023-02-10 8:08 ` Jerin Jacob
2023-02-10 8:26 ` [dpdk-dev] [PATCH v2 " psatheesh
3 siblings, 0 replies; 8+ messages in thread
From: Jerin Jacob @ 2023-02-10 8:08 UTC (permalink / raw)
To: psatheesh
Cc: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao,
dev, stable
On Fri, Feb 10, 2023 at 9:51 AM <psatheesh@marvell.com> wrote:
>
> From: Satheesh Paul <psatheesh@marvell.com>
>
> Fix channel mask of SDP interfaces on CN10K.
>
> Fixes: f137566333 ("common/cnxk: support setting channel mask for SDP interfaces")
> Cc: stable@dpdk.org
>
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
Please run ./devtools/check-git-log.sh -n 3 and
./devtools/checkpatches.sh -n 3 before pushing the patches
to fix below issues.
WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12
chars of sha1> ("<title line>")' - ie: 'Fixes: f13756633330
("common/cnxk: support setting channel mask for SDP interfaces")'
#8:
Fixes: f137566333 ("common/cnxk: support setting channel mask for SDP
interfaces")
total: 0 errors, 1 warnings, 24 lines checked
### [PATCH] common/cnxk: fix printing IPsec flow rules
WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12
chars of sha1> ("<title line>")' - ie: 'Fixes: 1aa86a170e27 ("drivers:
support IPsec rule reservation scheme")'
#8:
Fixes: 1aa86a170e ("drivers: support IPsec rule reservation scheme")
total: 0 errors, 1 warnings, 224 lines checked
### [PATCH] common/cnxk: fix inline IPsec rule creation
WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12
chars of sha1> ("<title line>")' - ie: 'Fixes: 1aa86a170e27 ("drivers:
support IPsec rule reservation scheme")'
> ---
> drivers/common/cnxk/roc_npc.c | 9 +++++++--
> drivers/common/cnxk/roc_npc_priv.h | 3 +++
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c
> index c872548230..9edccb5258 100644
> --- a/drivers/common/cnxk/roc_npc.c
> +++ b/drivers/common/cnxk/roc_npc.c
> @@ -1380,8 +1380,13 @@ roc_npc_flow_create(struct roc_npc *roc_npc, const struct roc_npc_attr *attr,
> /* By default set the channel and mask to cover
> * the whole SDP channel range.
> */
> - npc->sdp_channel = (uint16_t)NIX_CHAN_SDP_CH_START;
> - npc->sdp_channel_mask = (uint16_t)NIX_CHAN_SDP_CH_START;
> + if (roc_model_is_cn10k()) {
> + npc->sdp_channel = (uint16_t)CN10K_SDP_CH_START;
> + npc->sdp_channel_mask = (uint16_t)CN10K_SDP_CH_MASK;
> + } else {
> + npc->sdp_channel = (uint16_t)NIX_CHAN_SDP_CH_START;
> + npc->sdp_channel_mask = (uint16_t)NIX_CHAN_SDP_CH_START;
> + }
> }
> }
>
> diff --git a/drivers/common/cnxk/roc_npc_priv.h b/drivers/common/cnxk/roc_npc_priv.h
> index 2a7d3137fb..aa27228354 100644
> --- a/drivers/common/cnxk/roc_npc_priv.h
> +++ b/drivers/common/cnxk/roc_npc_priv.h
> @@ -77,6 +77,9 @@
> #define NPC_LFLAG_LC_OFFSET (NPC_LTYPE_OFFSET_START + 6)
> #define NPC_LTYPE_LC_OFFSET (NPC_LTYPE_OFFSET_START + 8)
>
> +#define CN10K_SDP_CH_START 0x80
> +#define CN10K_SDP_CH_MASK 0xF80
> +
> struct npc_action_vtag_info {
> uint16_t vlan_id;
> uint16_t vlan_ethtype;
> --
> 2.35.3
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH v2 1/3] common/cnxk: fix channel mask for SDP interfaces
2023-02-10 4:21 [dpdk-dev] [PATCH 1/3] common/cnxk: fix channel mask for SDP interfaces psatheesh
` (2 preceding siblings ...)
2023-02-10 8:08 ` [dpdk-dev] [PATCH 1/3] common/cnxk: fix channel mask for SDP interfaces Jerin Jacob
@ 2023-02-10 8:26 ` psatheesh
2023-02-10 8:26 ` [dpdk-dev] [PATCH v2 2/3] common/cnxk: fix printing IPsec flow rules psatheesh
2023-02-10 8:26 ` [dpdk-dev] [PATCH v2 3/3] common/cnxk: fix inline IPsec rule creation psatheesh
3 siblings, 2 replies; 8+ messages in thread
From: psatheesh @ 2023-02-10 8:26 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, Satheesh Paul, stable
From: Satheesh Paul <psatheesh@marvell.com>
Fix channel mask of SDP interfaces on CN10K.
Fixes: f13756633330 ("common/cnxk: support setting channel mask for SDP interfaces")
Cc: stable@dpdk.org
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
---
v2:
* Corrected "Fixes:" tag with 12 char sha1
drivers/common/cnxk/roc_npc.c | 9 +++++++--
drivers/common/cnxk/roc_npc_priv.h | 3 +++
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c
index c872548230..9edccb5258 100644
--- a/drivers/common/cnxk/roc_npc.c
+++ b/drivers/common/cnxk/roc_npc.c
@@ -1380,8 +1380,13 @@ roc_npc_flow_create(struct roc_npc *roc_npc, const struct roc_npc_attr *attr,
/* By default set the channel and mask to cover
* the whole SDP channel range.
*/
- npc->sdp_channel = (uint16_t)NIX_CHAN_SDP_CH_START;
- npc->sdp_channel_mask = (uint16_t)NIX_CHAN_SDP_CH_START;
+ if (roc_model_is_cn10k()) {
+ npc->sdp_channel = (uint16_t)CN10K_SDP_CH_START;
+ npc->sdp_channel_mask = (uint16_t)CN10K_SDP_CH_MASK;
+ } else {
+ npc->sdp_channel = (uint16_t)NIX_CHAN_SDP_CH_START;
+ npc->sdp_channel_mask = (uint16_t)NIX_CHAN_SDP_CH_START;
+ }
}
}
diff --git a/drivers/common/cnxk/roc_npc_priv.h b/drivers/common/cnxk/roc_npc_priv.h
index 2a7d3137fb..aa27228354 100644
--- a/drivers/common/cnxk/roc_npc_priv.h
+++ b/drivers/common/cnxk/roc_npc_priv.h
@@ -77,6 +77,9 @@
#define NPC_LFLAG_LC_OFFSET (NPC_LTYPE_OFFSET_START + 6)
#define NPC_LTYPE_LC_OFFSET (NPC_LTYPE_OFFSET_START + 8)
+#define CN10K_SDP_CH_START 0x80
+#define CN10K_SDP_CH_MASK 0xF80
+
struct npc_action_vtag_info {
uint16_t vlan_id;
uint16_t vlan_ethtype;
--
2.35.3
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH v2 2/3] common/cnxk: fix printing IPsec flow rules
2023-02-10 8:26 ` [dpdk-dev] [PATCH v2 " psatheesh
@ 2023-02-10 8:26 ` psatheesh
2023-02-10 8:26 ` [dpdk-dev] [PATCH v2 3/3] common/cnxk: fix inline IPsec rule creation psatheesh
1 sibling, 0 replies; 8+ messages in thread
From: psatheesh @ 2023-02-10 8:26 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, Satheesh Paul, stable, Jerin Jacob
From: Satheesh Paul <psatheesh@marvell.com>
When dumping flow data, dump preallocated IPsec rules also.
Fixes: 1aa86a170e27 ("drivers: support IPsec rule reservation scheme")
Cc: stable@dpdk.org
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Jerin Jacob <jerinj@marvell.com>
Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
---
drivers/common/cnxk/roc_npc.c | 7 +-
drivers/common/cnxk/roc_npc_mcam_dump.c | 154 ++++++++++++++++++------
2 files changed, 120 insertions(+), 41 deletions(-)
diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c
index 9edccb5258..579b3dce9a 100644
--- a/drivers/common/cnxk/roc_npc.c
+++ b/drivers/common/cnxk/roc_npc.c
@@ -1550,11 +1550,14 @@ roc_npc_flow_dump(FILE *file, struct roc_npc *roc_npc)
roc_npc_flow_mcam_dump(file, roc_npc, flow_iter);
}
}
+
+ TAILQ_FOREACH(flow_iter, &npc->ipsec_list, next) {
+ roc_npc_flow_mcam_dump(file, roc_npc, flow_iter);
+ }
}
int
-roc_npc_mcam_merge_base_steering_rule(struct roc_npc *roc_npc,
- struct roc_npc_flow *flow)
+roc_npc_mcam_merge_base_steering_rule(struct roc_npc *roc_npc, struct roc_npc_flow *flow)
{
struct npc_mcam_read_base_rule_rsp *base_rule_rsp;
struct npc *npc = roc_npc_to_npc_priv(roc_npc);
diff --git a/drivers/common/cnxk/roc_npc_mcam_dump.c b/drivers/common/cnxk/roc_npc_mcam_dump.c
index 40909b45e6..a88e166fbe 100644
--- a/drivers/common/cnxk/roc_npc_mcam_dump.c
+++ b/drivers/common/cnxk/roc_npc_mcam_dump.c
@@ -73,43 +73,93 @@ static const char *const ltype_str[NPC_MAX_LID][NPC_MAX_LT] = {
[NPC_LID_LA][NPC_LT_LA_CPT_HDR] = "LA_CPT_HDR",
[NPC_LID_LA][NPC_LT_LA_CUSTOM_L2_24B_ETHER] = "LA_CUSTOM_L2_24B_ETHER",
[NPC_LID_LA][NPC_LT_LA_CUSTOM_PRE_L2_ETHER] = "NPC_LT_LA_CUSTOM_PRE_L2_ETHER",
+ [NPC_LID_LA][NPC_LT_LA_CUSTOM0] = "NPC_LT_LA_CUSTOM0",
+ [NPC_LID_LA][NPC_LT_LA_CUSTOM1] = "NPC_LT_LA_CUSTOM1",
[NPC_LID_LB][0] = "NONE",
+ [NPC_LID_LB][NPC_LT_LB_ETAG] = "LB_ETAG",
[NPC_LID_LB][NPC_LT_LB_CTAG] = "LB_CTAG",
[NPC_LID_LB][NPC_LT_LB_STAG_QINQ] = "LB_STAG_QINQ",
- [NPC_LID_LB][NPC_LT_LB_ETAG] = "LB_ETAG",
+ [NPC_LID_LB][NPC_LT_LB_BTAG] = "LB_BTAG",
+ [NPC_LID_LB][NPC_LT_LB_PPPOE] = "LB_PPPOE",
+ [NPC_LID_LB][NPC_LT_LB_DSA] = "LB_DSA",
+ [NPC_LID_LB][NPC_LT_LB_DSA_VLAN] = "LB_DSA_VLAN",
+ [NPC_LID_LB][NPC_LT_LB_EDSA] = "LB_EDSA",
+ [NPC_LID_LB][NPC_LT_LB_EDSA_VLAN] = "LB_EDSA_VLAN",
[NPC_LID_LB][NPC_LT_LB_EXDSA] = "LB_EXDSA",
+ [NPC_LID_LB][NPC_LT_LB_EXDSA_VLAN] = "LB_EXDSA_VLAN",
+ [NPC_LID_LB][NPC_LT_LB_FDSA] = "LB_FDSA",
[NPC_LID_LB][NPC_LT_LB_VLAN_EXDSA] = "LB_VLAN_EXDSA",
+ [NPC_LID_LB][NPC_LT_LB_CUSTOM0] = "LB_CUSTOM0",
+ [NPC_LID_LB][NPC_LT_LB_CUSTOM1] = "LB_CUSTOM1",
[NPC_LID_LC][0] = "NONE",
+ [NPC_LID_LC][NPC_LT_LC_PTP] = "LC_PTP",
[NPC_LID_LC][NPC_LT_LC_IP] = "LC_IP",
+ [NPC_LID_LC][NPC_LT_LC_IP_OPT] = "LC_IP_OPT",
[NPC_LID_LC][NPC_LT_LC_IP6] = "LC_IP6",
- [NPC_LID_LC][NPC_LT_LC_ARP] = "LC_ARP",
[NPC_LID_LC][NPC_LT_LC_IP6_EXT] = "LC_IP6_EXT",
+ [NPC_LID_LC][NPC_LT_LC_ARP] = "LC_ARP",
+ [NPC_LID_LC][NPC_LT_LC_RARP] = "LC_RARP",
+ [NPC_LID_LC][NPC_LT_LC_MPLS] = "LC_MPLS",
+ [NPC_LID_LC][NPC_LT_LC_NSH] = "LC_NSH",
+ [NPC_LID_LC][NPC_LT_LC_FCOE] = "LC_FCOE",
[NPC_LID_LC][NPC_LT_LC_NGIO] = "LC_NGIO",
+ [NPC_LID_LC][NPC_LT_LC_CUSTOM0] = "LC_CUSTOM0",
+ [NPC_LID_LC][NPC_LT_LC_CUSTOM1] = "LC_CUSTOM1",
[NPC_LID_LD][0] = "NONE",
- [NPC_LID_LD][NPC_LT_LD_ICMP] = "LD_ICMP",
- [NPC_LID_LD][NPC_LT_LD_ICMP6] = "LD_ICMP6",
- [NPC_LID_LD][NPC_LT_LD_UDP] = "LD_UDP",
[NPC_LID_LD][NPC_LT_LD_TCP] = "LD_TCP",
+ [NPC_LID_LD][NPC_LT_LD_UDP] = "LD_UDP",
[NPC_LID_LD][NPC_LT_LD_SCTP] = "LD_SCTP",
+ [NPC_LID_LD][NPC_LT_LD_ICMP6] = "LD_ICMP6",
+ [NPC_LID_LD][NPC_LT_LD_CUSTOM0] = "LD_CUSTOM0",
+ [NPC_LID_LD][NPC_LT_LD_CUSTOM1] = "LD_CUSTOM1",
+ [NPC_LID_LD][NPC_LT_LD_IGMP] = "LD_IGMP",
+ [NPC_LID_LD][NPC_LT_LD_AH] = "LD_AH",
[NPC_LID_LD][NPC_LT_LD_GRE] = "LD_GRE",
[NPC_LID_LD][NPC_LT_LD_NVGRE] = "LD_NVGRE",
+ [NPC_LID_LD][NPC_LT_LD_NSH] = "LD_NSH",
+ [NPC_LID_LD][NPC_LT_LD_TU_MPLS_IN_NSH] = "LD_TU_MPLS_IN_NSH",
+ [NPC_LID_LD][NPC_LT_LD_TU_MPLS_IN_IP] = "LD_TU_MPLS_IN_IP",
+ [NPC_LID_LD][NPC_LT_LD_ICMP] = "LD_ICMP",
[NPC_LID_LE][0] = "NONE",
[NPC_LID_LE][NPC_LT_LE_VXLAN] = "LE_VXLAN",
+ [NPC_LID_LE][NPC_LT_LE_GENEVE] = "LE_GENEVE",
[NPC_LID_LE][NPC_LT_LE_ESP] = "LE_ESP",
- [NPC_LID_LE][NPC_LT_LE_GTPC] = "LE_GTPC",
[NPC_LID_LE][NPC_LT_LE_GTPU] = "LE_GTPU",
- [NPC_LID_LE][NPC_LT_LE_GENEVE] = "LE_GENEVE",
[NPC_LID_LE][NPC_LT_LE_VXLANGPE] = "LE_VXLANGPE",
+ [NPC_LID_LE][NPC_LT_LE_GTPC] = "LE_GTPC",
+ [NPC_LID_LE][NPC_LT_LE_NSH] = "LE_NSH",
+ [NPC_LID_LE][NPC_LT_LE_TU_MPLS_IN_GRE] = "LE_TU_MPLS_IN_GRE",
+ [NPC_LID_LE][NPC_LT_LE_TU_NSH_IN_GRE] = "LE_TU_NSH_IN_GRE",
+ [NPC_LID_LE][NPC_LT_LE_TU_MPLS_IN_UDP] = "LE_TU_MPLS_IN_UDP",
+ [NPC_LID_LE][NPC_LT_LE_CUSTOM0] = "LE_CUSTOM0",
+ [NPC_LID_LE][NPC_LT_LE_CUSTOM1] = "LE_CUSTOM1",
[NPC_LID_LF][0] = "NONE",
[NPC_LID_LF][NPC_LT_LF_TU_ETHER] = "LF_TU_ETHER",
+ [NPC_LID_LF][NPC_LT_LF_TU_PPP] = "LF_TU_PPP",
+ [NPC_LID_LF][NPC_LT_LF_TU_MPLS_IN_VXLANGPE] = "LF_TU_MPLS_IN_VXLANGPE",
+ [NPC_LID_LF][NPC_LT_LF_TU_NSH_IN_VXLANGPE] = "LF_TU_NSH_IN_VXLANGPE",
+ [NPC_LID_LF][NPC_LT_LF_TU_MPLS_IN_NSH] = "LF_TU_MPLS_IN_NSH",
+ [NPC_LID_LF][NPC_LT_LF_TU_3RD_NSH] = "LF_TU_3RD_NSH",
+ [NPC_LID_LF][NPC_LT_LF_CUSTOM0] = "LF_CUSTOM0",
+ [NPC_LID_LF][NPC_LT_LF_CUSTOM1] = "LF_CUSTOM1",
[NPC_LID_LG][0] = "NONE",
[NPC_LID_LG][NPC_LT_LG_TU_IP] = "LG_TU_IP",
[NPC_LID_LG][NPC_LT_LG_TU_IP6] = "LG_TU_IP6",
+ [NPC_LID_LG][NPC_LT_LG_TU_ARP] = "LG_TU_ARP",
+ [NPC_LID_LG][NPC_LT_LG_TU_ETHER_IN_NSH] = "LG_TU_ETHER_IN_NSH",
+ [NPC_LID_LG][NPC_LT_LG_CUSTOM0] = "LG_CUSTOM0",
+ [NPC_LID_LG][NPC_LT_LG_CUSTOM1] = "LG_CUSTOM1",
[NPC_LID_LH][0] = "NONE",
- [NPC_LID_LH][NPC_LT_LH_TU_UDP] = "LH_TU_UDP",
[NPC_LID_LH][NPC_LT_LH_TU_TCP] = "LH_TU_TCP",
+ [NPC_LID_LH][NPC_LT_LH_TU_UDP] = "LH_TU_UDP",
[NPC_LID_LH][NPC_LT_LH_TU_SCTP] = "LH_TU_SCTP",
+ [NPC_LID_LH][NPC_LT_LH_TU_ICMP6] = "LH_TU_ICMP6",
+ [NPC_LID_LH][NPC_LT_LH_CUSTOM0] = "LH_CUSTOM0",
+ [NPC_LID_LH][NPC_LT_LH_CUSTOM1] = "LH_CUSTOM1",
+ [NPC_LID_LH][NPC_LT_LH_TU_IGMP] = "LH_TU_IGMP",
[NPC_LID_LH][NPC_LT_LH_TU_ESP] = "LH_TU_ESP",
+ [NPC_LID_LH][NPC_LT_LH_TU_AH] = "LH_TU_AH",
+ [NPC_LID_LH][NPC_LT_LH_TU_ICMP] = "LH_TU_ICMP",
};
static uint16_t
@@ -585,20 +635,71 @@ npc_flow_dump_vtag_action(FILE *file, uint64_t vtag_action, bool is_rx)
}
}
-void
-roc_npc_flow_mcam_dump(FILE *file, struct roc_npc *roc_npc,
- struct roc_npc_flow *flow)
+static void
+npc_flow_hw_mcam_entry_dump(FILE *file, struct npc *npc, struct roc_npc_flow *flow)
{
- struct npc *npc = roc_npc_to_npc_priv(roc_npc);
+ uint64_t mcam_data[ROC_NPC_MAX_MCAM_WIDTH_DWORDS];
+ uint64_t mcam_mask[ROC_NPC_MAX_MCAM_WIDTH_DWORDS];
struct npc_mcam_read_entry_req *mcam_read_req;
struct npc_mcam_read_entry_rsp *mcam_read_rsp;
+ struct nix_inl_dev *inl_dev = NULL;
+ struct idev_cfg *idev;
+ struct mbox *mbox;
+ int rc = 0, i;
+
+ idev = idev_get_cfg();
+ if (idev)
+ inl_dev = idev->nix_inl_dev;
+
+ if (inl_dev && flow->use_pre_alloc)
+ mbox = inl_dev->dev.mbox;
+ else
+ mbox = npc->mbox;
+
+ mcam_read_req = mbox_alloc_msg_npc_mcam_read_entry(mbox_get(mbox));
+ if (mcam_read_req == NULL) {
+ plt_err("Failed to alloc msg");
+ mbox_put(mbox);
+ return;
+ }
+
+ mcam_read_req->entry = flow->mcam_id;
+ rc = mbox_process_msg(mbox, (void *)&mcam_read_rsp);
+ if (rc) {
+ mbox_put(mbox);
+ plt_err("Failed to fetch MCAM entry:%d", flow->mcam_id);
+ return;
+ }
+
+ mbox_memcpy(mcam_data, mcam_read_rsp->entry_data.kw, sizeof(mcam_data));
+ mbox_memcpy(mcam_mask, mcam_read_rsp->entry_data.kw_mask, sizeof(mcam_data));
+
+ fprintf(file, "HW MCAM Data :\n");
+
+ for (i = 0; i < ROC_NPC_MAX_MCAM_WIDTH_DWORDS; i++) {
+ fprintf(file, "\tDW%d :%016lX\n", i, mcam_data[i]);
+ fprintf(file, "\tDW%d_Mask:%016lX\n", i, mcam_mask[i]);
+ }
+
+ fprintf(file, "\n");
+ mbox_put(mbox);
+}
+
+void
+roc_npc_flow_mcam_dump(FILE *file, struct roc_npc *roc_npc, struct roc_npc_flow *flow)
+{
+ struct npc *npc = roc_npc_to_npc_priv(roc_npc);
uint64_t count = 0;
bool is_rx = 0;
int i, rc = 0;
fprintf(file, "MCAM Index:%d\n", flow->mcam_id);
if (flow->ctr_id != NPC_COUNTER_NONE && flow->use_ctr) {
- rc = roc_npc_mcam_read_counter(roc_npc, flow->ctr_id, &count);
+ if (flow->use_pre_alloc)
+ rc = roc_npc_inl_mcam_read_counter(flow->ctr_id, &count);
+ else
+ rc = roc_npc_mcam_read_counter(roc_npc, flow->ctr_id, &count);
+
if (rc)
return;
fprintf(file, "Hit count: %" PRIu64 "\n", count);
@@ -622,30 +723,5 @@ roc_npc_flow_mcam_dump(FILE *file, struct roc_npc *roc_npc,
fprintf(file, "\tDW%d_Mask:%016lX\n", i, flow->mcam_mask[i]);
}
- mcam_read_req = mbox_alloc_msg_npc_mcam_read_entry(mbox_get(npc->mbox));
- if (mcam_read_req == NULL) {
- plt_err("Failed to alloc msg");
- mbox_put(npc->mbox);
- return;
- }
-
- mcam_read_req->entry = flow->mcam_id;
- rc = mbox_process_msg(npc->mbox, (void *)&mcam_read_rsp);
- if (rc) {
- mbox_put(npc->mbox);
- plt_err("Failed to fetch MCAM entry:%d", flow->mcam_id);
- return;
- }
-
- fprintf(file, "HW MCAM Data :\n");
-
- for (i = 0; i < ROC_NPC_MAX_MCAM_WIDTH_DWORDS; i++) {
- fprintf(file, "\tDW%d :%016lX\n", i,
- mcam_read_rsp->entry_data.kw[i]);
- fprintf(file, "\tDW%d_Mask:%016lX\n", i,
- mcam_read_rsp->entry_data.kw_mask[i]);
- }
-
- fprintf(file, "\n");
- mbox_put(npc->mbox);
+ npc_flow_hw_mcam_entry_dump(file, npc, flow);
}
--
2.35.3
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH v2 3/3] common/cnxk: fix inline IPsec rule creation
2023-02-10 8:26 ` [dpdk-dev] [PATCH v2 " psatheesh
2023-02-10 8:26 ` [dpdk-dev] [PATCH v2 2/3] common/cnxk: fix printing IPsec flow rules psatheesh
@ 2023-02-10 8:26 ` psatheesh
2023-02-11 9:04 ` Jerin Jacob
1 sibling, 1 reply; 8+ messages in thread
From: psatheesh @ 2023-02-10 8:26 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, Satheesh Paul, stable
From: Satheesh Paul <psatheesh@marvell.com>
Use inline IPsec device to create IPsec rules irrespective
of RTE_ETH_RX_OFFLOAD_SECURITY offload flag.
Fixes: 1aa86a170e27 ("drivers: support IPsec rule reservation scheme")
Cc: stable@dpdk.org
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
---
drivers/common/cnxk/roc_npc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c
index 579b3dce9a..d3efebe663 100644
--- a/drivers/common/cnxk/roc_npc.c
+++ b/drivers/common/cnxk/roc_npc.c
@@ -562,8 +562,10 @@ npc_parse_actions(struct roc_npc *roc_npc, const struct roc_npc_attr *attr,
}
rq = inl_rq->qid;
pf_func = nix_inl_dev_pffunc_get();
- flow->is_inline_dev = 1;
}
+
+ if (roc_nix_inl_dev_is_probed())
+ flow->is_inline_dev = 1;
sec_action = actions;
break;
case ROC_NPC_ACTION_TYPE_VLAN_STRIP:
--
2.35.3
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH v2 3/3] common/cnxk: fix inline IPsec rule creation
2023-02-10 8:26 ` [dpdk-dev] [PATCH v2 3/3] common/cnxk: fix inline IPsec rule creation psatheesh
@ 2023-02-11 9:04 ` Jerin Jacob
0 siblings, 0 replies; 8+ messages in thread
From: Jerin Jacob @ 2023-02-11 9:04 UTC (permalink / raw)
To: psatheesh
Cc: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao,
dev, stable
On Fri, Feb 10, 2023 at 1:56 PM <psatheesh@marvell.com> wrote:
>
> From: Satheesh Paul <psatheesh@marvell.com>
>
> Use inline IPsec device to create IPsec rules irrespective
> of RTE_ETH_RX_OFFLOAD_SECURITY offload flag.
>
> Fixes: 1aa86a170e27 ("drivers: support IPsec rule reservation scheme")
> Cc: stable@dpdk.org
>
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
Series applied to dpdk-next-net-eventdev/for-main. Thanks
> ---
> drivers/common/cnxk/roc_npc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c
> index 579b3dce9a..d3efebe663 100644
> --- a/drivers/common/cnxk/roc_npc.c
> +++ b/drivers/common/cnxk/roc_npc.c
> @@ -562,8 +562,10 @@ npc_parse_actions(struct roc_npc *roc_npc, const struct roc_npc_attr *attr,
> }
> rq = inl_rq->qid;
> pf_func = nix_inl_dev_pffunc_get();
> - flow->is_inline_dev = 1;
> }
> +
> + if (roc_nix_inl_dev_is_probed())
> + flow->is_inline_dev = 1;
> sec_action = actions;
> break;
> case ROC_NPC_ACTION_TYPE_VLAN_STRIP:
> --
> 2.35.3
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-02-11 9:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-10 4:21 [dpdk-dev] [PATCH 1/3] common/cnxk: fix channel mask for SDP interfaces psatheesh
2023-02-10 4:21 ` [dpdk-dev] [PATCH 2/3] common/cnxk: fix printing IPsec flow rules psatheesh
2023-02-10 4:21 ` [dpdk-dev] [PATCH 3/3] common/cnxk: fix inline IPsec rule creation psatheesh
2023-02-10 8:08 ` [dpdk-dev] [PATCH 1/3] common/cnxk: fix channel mask for SDP interfaces Jerin Jacob
2023-02-10 8:26 ` [dpdk-dev] [PATCH v2 " psatheesh
2023-02-10 8:26 ` [dpdk-dev] [PATCH v2 2/3] common/cnxk: fix printing IPsec flow rules psatheesh
2023-02-10 8:26 ` [dpdk-dev] [PATCH v2 3/3] common/cnxk: fix inline IPsec rule creation psatheesh
2023-02-11 9:04 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).