From: Akhil Goyal <gakhil@marvell.com>
To: <dev@dpdk.org>
Cc: <radu.nicolau@intel.com>, <anoobj@marvell.com>, <g.singh@nxp.com>,
<hemant.agrawal@nxp.com>, <kai.ji@intel.com>,
<ruifeng.wang@arm.com>, <sunilprakashrao.uttarwar@amd.com>,
<rnagadheeraj@marvell.com>, <matan@nvidia.com>,
Akhil Goyal <gakhil@marvell.com>, <stable@dpdk.org>
Subject: [PATCH 1/3] examples/ipsec-secgw: fix auth IV length
Date: Thu, 16 Feb 2023 19:54:40 +0530 [thread overview]
Message-ID: <20230216142442.3657742-1-gakhil@marvell.com> (raw)
Currently, cipher IV length is getting used to set auth
xform IV length. Auth IV is needed for AES-GMAC case,
and in all other cases, auth IV should be 0.
Used a separate auth IV length to separate out cipher and auth cases.
Fixes: 9413c3901f31 ("examples/ipsec-secgw: support additional algorithms")
Cc: stable@dpdk.org
Signed-off-by: Akhil Goyal <gakhil@marvell.com>
---
examples/ipsec-secgw/sa.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
index 7da9444a7b..001762bea9 100644
--- a/examples/ipsec-secgw/sa.c
+++ b/examples/ipsec-secgw/sa.c
@@ -1247,6 +1247,7 @@ sa_add_rules(struct sa_ctx *sa_ctx, const struct ipsec_sa entries[],
struct ipsec_sa *sa;
uint32_t i, idx;
uint16_t iv_length, aad_length;
+ uint16_t auth_iv_length = 0;
int inline_status;
int32_t rc;
struct rte_ipsec_session *ips;
@@ -1340,7 +1341,7 @@ sa_add_rules(struct sa_ctx *sa_ctx, const struct ipsec_sa entries[],
/* AES_GMAC uses salt like AEAD algorithms */
if (sa->auth_algo == RTE_CRYPTO_AUTH_AES_GMAC)
- iv_length = 12;
+ auth_iv_length = 12;
if (inbound) {
sa_ctx->xf[idx].b.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
@@ -1364,7 +1365,7 @@ sa_add_rules(struct sa_ctx *sa_ctx, const struct ipsec_sa entries[],
sa_ctx->xf[idx].a.auth.op =
RTE_CRYPTO_AUTH_OP_VERIFY;
sa_ctx->xf[idx].a.auth.iv.offset = IV_OFFSET;
- sa_ctx->xf[idx].a.auth.iv.length = iv_length;
+ sa_ctx->xf[idx].a.auth.iv.length = auth_iv_length;
} else { /* outbound */
sa_ctx->xf[idx].a.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
@@ -1388,7 +1389,7 @@ sa_add_rules(struct sa_ctx *sa_ctx, const struct ipsec_sa entries[],
sa_ctx->xf[idx].b.auth.op =
RTE_CRYPTO_AUTH_OP_GENERATE;
sa_ctx->xf[idx].b.auth.iv.offset = IV_OFFSET;
- sa_ctx->xf[idx].b.auth.iv.length = iv_length;
+ sa_ctx->xf[idx].b.auth.iv.length = auth_iv_length;
}
--
2.25.1
next reply other threads:[~2023-02-16 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 14:24 Akhil Goyal [this message]
2023-02-21 13:13 ` Ji, Kai
2023-02-27 17:34 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230216142442.3657742-1-gakhil@marvell.com \
--to=gakhil@marvell.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=g.singh@nxp.com \
--cc=hemant.agrawal@nxp.com \
--cc=kai.ji@intel.com \
--cc=matan@nvidia.com \
--cc=radu.nicolau@intel.com \
--cc=rnagadheeraj@marvell.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
--cc=sunilprakashrao.uttarwar@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).