From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F308C41CFC for ; Tue, 21 Feb 2023 11:35:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 976CB431D6; Tue, 21 Feb 2023 11:35:44 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2110.outbound.protection.outlook.com [40.107.243.110]) by mails.dpdk.org (Postfix) with ESMTP id 2F4DD431C7; Tue, 21 Feb 2023 11:35:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PRmBTAEuRqlDWmc8MBLVHXRdAc+HnYbGezIGRbhks47bHwumnHw5OptUYus55eRF0+DHKk/1yHtDC0ufyVz0/USCFrwy1PWt7IYEagVgLutXOQAA5+xoC9VFWTKMuI1b/CkzbSSA19ksduYmiC3P5MFRjkhqpOzb/mHCBb0fvQ8rFd07lsnMKLnvQk4qV3iVBCHvGfXQPPQIVEceXXoirTzvF9cezWRV+dlu9/z9mC4R0RdlMQhvtNVurO0tqaVFxIpvDJ2uIq51XRchUfe3N81O7qVx2/SvcDqnavYYiNihVie4G78dFvha6KC26RXHiadZBXr6OrGCluTpuCq2rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rs7EInAabFq6ZS36rWbINsALrv6WMj1PatupA7HA6BQ=; b=LBpmq7ZZoM5LvF7f8RBd0O2FrNaJjfKc8mstNI3e7kRXVWy6Knd1ErqtUjuQ2WxynJHf8uhNeidGvOpg1d4nzFOed29QsJ2lppSFXrSKC2hWbJixYzd05ya8D4QQa5ARR9iBZ4iKInzPGYzkYO338t1og+sfVUTS/QdzUYfCcOZ7gQqCpJZJeqlVWwCp/Dc9YBQXSXjZ8HDzDVzeqotwyjOjMIeOAa0h+gVS0MViW6Rxnrh4ZVmpdXBTzJFXdvVIECplIA8VZZtJvs+Jo/sDiXgLCMofJUIR6SfeJzIS/MBLbMbghpCuhEB79zGDYCxNTM9GE76+RwYtVjJS+0fExg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rs7EInAabFq6ZS36rWbINsALrv6WMj1PatupA7HA6BQ=; b=nt/fLn7Q/wMJIU35eCQ4QatQlHS9j9qE2aBxJs7aTtKgXzM2d61SEIPFGQhVM+rMnC5sBU6NtNtQ5JHjOo7t0cyfgOjXtoz+MXd8u7p4C4XGm+VCXu/cU/755jfVgBFCOmjQdoWS1PMsftUTlhkZj03JdnZwStgW1yxTsfLr64w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH0PR13MB5616.namprd13.prod.outlook.com (2603:10b6:510:12b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 10:35:37 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 10:35:37 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH v2 3/6] net/nfp: fix the set IPv6 flow action Date: Tue, 21 Feb 2023 18:35:10 +0800 Message-Id: <20230221103513.412-4-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221103513.412-1-chaoyong.he@corigine.com> References: <20230221064930.3399-1-chaoyong.he@corigine.com> <20230221103513.412-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2P153CA0038.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::7) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH0PR13MB5616:EE_ X-MS-Office365-Filtering-Correlation-Id: 463a3fa0-e06e-48b0-9b14-08db13f75ec2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GyFS2rR46a5uP9SIZF89+PSwmtnIzjFOiITPzV8dyqn6wjDBus/1tREmeo2rD3JiQxT39YTYlRz3bgOMDX+/rPn/J+49BCmA52iaBcZIAnK3Bht67rZlEDjGEIim70n2g8EkcW6QPFCROIGCOS2ijpJXiBMTGYnTSzPz2XzcQL8he4QBNPODihk1/adFbHu2di1sQTZMgsNlD7nyslgwivMoorDCiklcoAFbPHe3BVbdN0srsmSgckZvJUaH4GCEtXJq8/8Ho61ZRs2UcxhG1gX+PN22YmeB+QdIP+7pZ6Kwg1qJ8B6COKCEaWJO0rJyQbZ8r9cyWdHmkl8rpovJnB2Y0y42D2EvvcKLWZo+TCjLxh/dGtm6gcxhtW/TXymqI1ZaUd5ckJoYrJXdhqxCNeeJD4FCd8TllQIShp5m3S0KsJWUs8UXGyvogZwt1qjgXeEzWdPTErjcmvFhuHQELoMcaognzq1YLXYmDCWfzisQ499FL/imPW97G9MT8N+FdJhNgGIr42l2Bvbab+GTnG+q6dt866sM8ktN95Ul9lXnb7it8xv8nieM/RhlJH5CcNIhA6ipX8otTEI9cIKxUA1ciU43nDAhxbgsdrWfIChpnXquXymeDT1/8WzHonas3uc6vbnru/sHLIQU6mYO8bB4yY8KUzwJhI7ssytZUjuA8sqQ+HAbYYG0F1+2zstG5lLp6vnZfC+jzbRSyXqB3w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(396003)(346002)(366004)(39840400004)(136003)(451199018)(83380400001)(450100002)(66476007)(66556008)(26005)(8676002)(66946007)(478600001)(316002)(4326008)(6916009)(6506007)(6666004)(6512007)(186003)(1076003)(36756003)(38100700002)(38350700002)(86362001)(6486002)(2906002)(41300700001)(8936002)(44832011)(5660300002)(52116002)(2616005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjkzeDRiSENKRjhDOVFpWjh3S2FBWUdva3ZBMXlNbHhSRkxPNVcrYkhwL1Yz?= =?utf-8?B?Q1IrMi9RT0V4VGFrTThhMkdBTU02ZE8vc3VhNGlIckRyUUF0MW92dFV1eldU?= =?utf-8?B?aXZtMVlIUXE0SzFBbjhaK08wNkdFTFBKV0QzNEpUMUYrcnNGRFQrS1BHYUFE?= =?utf-8?B?cGxpMlNDeUJ5RllYK3d5MzB0UWlJNDNDTHVPOHEraTNyWHM1UGxtZzB4K21p?= =?utf-8?B?bEQ5VkxJeW8waGFGV2tXd3lYZ0hSdWtrS2Y0dHc5dVk0SjdmSGZQV2psZFZJ?= =?utf-8?B?dEdJa3hocHB0R0NsUDdJeUE5VURnbG9JOGNaUmhzQVY2dUtSUXJVb2ltUE9J?= =?utf-8?B?RURIbTFLc1EwQjBLVHB3RHI3RzJxd2piQVFqVnQrM1NUMlBkOU9IMGNOTTR0?= =?utf-8?B?cG0rTmMrTE9RM1ZGOWFsVmpmK1B3d0ptMVJYSjJJYkhnd2Fxb2kvVmg3SHpa?= =?utf-8?B?aFF0b1FJV25nd21oSWF5OGw4bW9VZFlNQVpKcmNCT2ZMTk91bGZTTG5sbmpJ?= =?utf-8?B?NkR1UDdROTFReGk3Z0tNYkJJL29Lak5ua24xQkRHU2o3QnU1Sm5MK25JR013?= =?utf-8?B?azQwajQ5MkZqUUVOV2hQVW5wRGFGcXpzM3ZDZHgrVXVLbDRYNXN3S01RUU4v?= =?utf-8?B?Mklhd0FET0sya25XWVZ6Z3pXeGxQVHp0R0hUT3dGWmdRNGxYcDBJZjA5ZFp0?= =?utf-8?B?aVl1UU4wLy80ZmVVbkxWZ0R1cXNqVmEydGpyaTF2RkpRcTBwaWFQZEV0bHhn?= =?utf-8?B?TENaRXRMTGZpd1YxWkJyOENwRlFiUmtJNDh0cVRaeTZ6ZjlCTTJ5WUx3THdJ?= =?utf-8?B?OFZ6aWQ2bGE4R2xZN1pjakRSdkV4MXQ3a01oc3ppREZMWWE5VHR1UnFTMUxh?= =?utf-8?B?OVlaR2RMVTNpaUo4ZFU2NjBia1FMMkF4bk4vcTcvQ3N3cVczYkdweFVHMVlt?= =?utf-8?B?S3lSVk1GR2ZLVmpCS01oNUwzSmNPRWdxQklkOHVRWmRjeGJUbzAyVDBTZ2Nu?= =?utf-8?B?a0djUGp5OXU1WUtjZkRWb3lYMzVWMmRJZXJBV3d0S3dhZ1ArS0V5Zjc1cHZN?= =?utf-8?B?c0xvUW9rWGErdkVZUHVhOGg3ck5xbmdKT3JPL3JNaytldFh0ZGxMWCtCTFJK?= =?utf-8?B?Z2wzVStmcmVJUEJpbEovTG1pKzZEdWFIVStyeEh6TUJhK3VLSHlQYnMxd0lY?= =?utf-8?B?N3lJN3Vnc2x1UytOVTVqSzJkcTR0WC9peS9QOHhhZmMxSnBScjNDQ0JmM3cv?= =?utf-8?B?Wk5Cb1E1QUtTVCtPcmVJd0dWUXN1eDFuY0wxblY3VmZkY2Z1SGNVMUVyaCth?= =?utf-8?B?b2FMWlExZVloOG9rcFJXdjd5UjEvL2djUmgyVnhFMGZsN0dDSU03elhZNWhS?= =?utf-8?B?OVNuQVJBazhqS0FMRkg5Y3EwQUhKVEdpblBLdXkrS2UxTmNSR1BxV2d0KzBQ?= =?utf-8?B?b1BUZjFpYjRWL3g2WlJ1dzJuQnVuUTQxY3VROEsrVFVyeXpCMDEwWmxGMHE5?= =?utf-8?B?TTd6OUhHMHdZbFZCb2V1R3ZpT3VDYVRRK29QRmFLU0NpV1VQUnNCcmFRWXR4?= =?utf-8?B?SXZaZmsyRDdKLzBFZDh4WEdHcVVuR0RhLytRRjdkYVl2cE9EMFBZSWlzZW9M?= =?utf-8?B?OGJtQTNJSGpXSGlVOC9id25KTVpMUTJPOGJTbit2eUh6K045dXVpa0FUVEJ3?= =?utf-8?B?QkRVWlpoc294L1VBTFFBZDNJeW9WNUlQdnU0Y3BMYmNVZnY3bGtiL1R3VGph?= =?utf-8?B?b0Y3b2pyZzdVNkd1bVpqc2ZxOFdlUWpuak9XNGJTanFsR3JyQW1xcll0YWNK?= =?utf-8?B?dlA3Z3NlR1ZnaUpSdSs2U08vV0xySytRZ3J1empDVjhTWjhFcmt4d1ZMOEh1?= =?utf-8?B?dUc3OHQvNm1DQ0RKS3VoaGJWdzNZZ0RsR0lsdUFMMmNBUFZES3M1bVdpVmlQ?= =?utf-8?B?eXQwTVY0ZjFIcW9WaWdUMDk0N0VlNEdCRmo2SXVKeVNzT3puMUtFaDBrOGJB?= =?utf-8?B?OTRLcGdMc1hIaE9kNHhLOW1Oc3I2bHh1YTRpdFRBRE5lRWY3Tkt2QUVaalV0?= =?utf-8?B?aStXVnVJVk5Lc2xtTmlFMDlqTklBcjEraGQxek9wUmcyRTVTa0xTUDMrQ0Ro?= =?utf-8?B?STNpbnFoYUs4ZG9LOWJPM2s2WkZLcUhjUXRHdDE2d0pqbXk3N0Z2b2hhaUlE?= =?utf-8?B?SEE9PQ==?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 463a3fa0-e06e-48b0-9b14-08db13f75ec2 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 10:35:37.4949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YQ04i3K5YOSzeIYo46fC2/9q4wsFifZfcCr+Xg3TnYg+OAwTAL8qsFXTVnvlqZKUMLOgKQTFiPfFlaNxZCkWKOSjydggo6xvDdXOgHDawKg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5616 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The former logic of set IPv6 source/destination address flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right IPv6 address as expected. Fixes: 596ae2217214 ("net/nfp: support IPv6 source flow action") Fixes: 51384f79b264 ("net/nfp: support IPv6 destination flow action") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index 39493ce98d..d1fe744758 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2163,8 +2163,10 @@ nfp_flow_action_set_ipv6(char *act_data, set_ip->head.len_lw = act_size >> NFP_FL_LW_SIZ; set_ip->reserved = 0; - for (i = 0; i < 4; i++) - set_ip->ipv6[i].exact = set_ipv6->ipv6_addr[i]; + for (i = 0; i < 4; i++) { + set_ip->ipv6[i].exact = set_ipv6->ipv6_addr[i * 4]; + set_ip->ipv6[i].mask = RTE_BE32(0xffffffff); + } } static void -- 2.29.3