* [PATCH] vhost: fix slot index in async split virtqueue Tx
@ 2023-02-23 2:30 Cheng Jiang
2023-03-02 10:23 ` Maxime Coquelin
2023-03-06 14:23 ` Maxime Coquelin
0 siblings, 2 replies; 3+ messages in thread
From: Cheng Jiang @ 2023-02-23 2:30 UTC (permalink / raw)
To: maxime.coquelin, chenbo.xia
Cc: dev, wangzhihong.wzh, jiayu.hu, xuan.ding, wenwux.ma, yuanx.wang,
xingguang.he, Cheng Jiang, stable
The slot_idx in the asynchronous Vhost split virtqueue dequeue data path
is supposed to be decreased by 1 when desc_to_mbuf() fails.
Fixes: 84d5204310d7 ("vhost: support async dequeue for split ring")
Cc: stable@dpdk.org
Signed-off-by: Cheng Jiang <cheng1.jiang@intel.com>
---
lib/vhost/virtio_net.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
index 8caf05319e..374007a61a 100644
--- a/lib/vhost/virtio_net.c
+++ b/lib/vhost/virtio_net.c
@@ -3720,6 +3720,7 @@ virtio_dev_tx_async_split(struct virtio_net *dev, struct vhost_virtqueue *vq,
allocerr_warned = true;
}
dropped = true;
+ slot_idx--;
break;
}
--
2.35.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] vhost: fix slot index in async split virtqueue Tx
2023-02-23 2:30 [PATCH] vhost: fix slot index in async split virtqueue Tx Cheng Jiang
@ 2023-03-02 10:23 ` Maxime Coquelin
2023-03-06 14:23 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2023-03-02 10:23 UTC (permalink / raw)
To: Cheng Jiang, chenbo.xia
Cc: dev, wangzhihong.wzh, jiayu.hu, xuan.ding, wenwux.ma, yuanx.wang,
xingguang.he, stable
On 2/23/23 03:30, Cheng Jiang wrote:
> The slot_idx in the asynchronous Vhost split virtqueue dequeue data path
> is supposed to be decreased by 1 when desc_to_mbuf() fails.
>
> Fixes: 84d5204310d7 ("vhost: support async dequeue for split ring")
> Cc: stable@dpdk.org
>
> Signed-off-by: Cheng Jiang <cheng1.jiang@intel.com>
> ---
> lib/vhost/virtio_net.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
> index 8caf05319e..374007a61a 100644
> --- a/lib/vhost/virtio_net.c
> +++ b/lib/vhost/virtio_net.c
> @@ -3720,6 +3720,7 @@ virtio_dev_tx_async_split(struct virtio_net *dev, struct vhost_virtqueue *vq,
> allocerr_warned = true;
> }
> dropped = true;
> + slot_idx--;
> break;
> }
>
> --
> 2.35.1
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] vhost: fix slot index in async split virtqueue Tx
2023-02-23 2:30 [PATCH] vhost: fix slot index in async split virtqueue Tx Cheng Jiang
2023-03-02 10:23 ` Maxime Coquelin
@ 2023-03-06 14:23 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2023-03-06 14:23 UTC (permalink / raw)
To: Cheng Jiang, chenbo.xia
Cc: dev, wangzhihong.wzh, jiayu.hu, xuan.ding, wenwux.ma, yuanx.wang,
xingguang.he, stable
On 2/23/23 03:30, Cheng Jiang wrote:
> The slot_idx in the asynchronous Vhost split virtqueue dequeue data path
> is supposed to be decreased by 1 when desc_to_mbuf() fails.
>
> Fixes: 84d5204310d7 ("vhost: support async dequeue for split ring")
> Cc: stable@dpdk.org
>
> Signed-off-by: Cheng Jiang <cheng1.jiang@intel.com>
> ---
> lib/vhost/virtio_net.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
> index 8caf05319e..374007a61a 100644
> --- a/lib/vhost/virtio_net.c
> +++ b/lib/vhost/virtio_net.c
> @@ -3720,6 +3720,7 @@ virtio_dev_tx_async_split(struct virtio_net *dev, struct vhost_virtqueue *vq,
> allocerr_warned = true;
> }
> dropped = true;
> + slot_idx--;
> break;
> }
>
> --
> 2.35.1
>
Applied to dpdk-next-virtio/main.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-06 14:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-23 2:30 [PATCH] vhost: fix slot index in async split virtqueue Tx Cheng Jiang
2023-03-02 10:23 ` Maxime Coquelin
2023-03-06 14:23 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).