From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3F4941D4F for ; Thu, 23 Feb 2023 10:37:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDF9C43152; Thu, 23 Feb 2023 10:37:25 +0100 (CET) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mails.dpdk.org (Postfix) with ESMTP id D2580427E9 for ; Thu, 23 Feb 2023 10:37:24 +0100 (CET) Received: by mail-wr1-f45.google.com with SMTP id r7so9966660wrz.6 for ; Thu, 23 Feb 2023 01:37:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VIBf9e1MXyC0rodmrlOrCLmB5Wubvb3mDz/0niaalmQ=; b=qvtm4s5U3aKD0b7zDxbfiDOoAyOFJ2IgzmVBRPiBSTOTSSq3jaC5NLwRZl8GiRoi0K Uw4FSDbpQz1/+OayAk5BgEz+FdV4pd33pT48u8uTh6f27BcBVrcsDDZTjJfB7TtoLhu6 Oqy2mFb+5K6sCexkTDUh+uhnMA9YHgYiK2TQgzcGFo4l9sGifa6biuTcG6heiYh0vYJp LWjkKZyHMsU92NIfefxzNxFVzXZxTn7kxn1R9TKbLJkciR6SjY3I0rIdgdnSU365tkUa pkRXnoVeU8WiyKTb9ZsbhRoRwupnhKkncmVxyo7K1GihuB3r1bW7hWwKhdnkbxdAl1Gk WgpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VIBf9e1MXyC0rodmrlOrCLmB5Wubvb3mDz/0niaalmQ=; b=yKg0YHcagEV9eiNzQ7QCcV7Vm07sG+yUBo2EPaU5KPe4Ibh45mUX0mvOocn82UUI9l 75Lf57vVeQ8oivqRxR4ychGU/NLWfUYmhTv1UckwIDNcmBeZCcNdwUDmQeJlMiys/wvQ tQgRGETqUk8dSS1Iw7c7qnhqdw3beSOVKHctGWuCfgz62V5LxJr9q6SVHivd7eviKQI7 loNzJF2EKfMm5D5+lTIkgBK14HaTWH/BosibGQUH8NoT1UAFvtdZwmxiyNXdsufNY6s8 fLaun/rmx0AsXDcXgH/5BC3yB6u0jgoktm2vpkJiU5bXCTlhSBC8vUGBzXxpRK4ygeSu pvuA== X-Gm-Message-State: AO0yUKUOMxbkrRtE4GrzdSMBtzJTS5CanYbKBQpwvn+HN6bCHV4Y3ulo uP2dgiEk3iD0oYnAL8hNg8w= X-Google-Smtp-Source: AK7set+fVbz4y/674TC3ldxIcNC2a7KF8UHLfbkjh0XZDwiiV46xut9bWN45qgQP/vUh4LMT9dTexg== X-Received: by 2002:a05:6000:1141:b0:2c5:8e30:457f with SMTP id d1-20020a056000114100b002c58e30457fmr8781899wrx.29.1677145044351; Thu, 23 Feb 2023 01:37:24 -0800 (PST) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id k17-20020a7bc411000000b003dfee43863fsm9883925wmi.26.2023.02.23.01.37.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 01:37:23 -0800 (PST) From: luca.boccassi@gmail.com To: Tyler Retzlaff Cc: Stephen Hemminger , David Marchand , dpdk stable Subject: patch 'eal/windows: mark memory config as complete' has been queued to stable release 20.11.8 Date: Thu, 23 Feb 2023 09:36:05 +0000 Message-Id: <20230223093715.3926893-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/77f9d2464c9a604214849c9c233a9e8dc8a0a7e9 Thanks. Luca Boccassi --- >From 77f9d2464c9a604214849c9c233a9e8dc8a0a7e9 Mon Sep 17 00:00:00 2001 From: Tyler Retzlaff Date: Fri, 16 Dec 2022 09:16:39 -0800 Subject: [PATCH] eal/windows: mark memory config as complete [ upstream commit 40032e5e0787fb311cc89c45bd681740b0c9e266 ] Memory configuration was not being marked as completed. Add the missing call to rte_eal_init() for Windows. This allows rte_thread_register to work on Windows and lcores_autotest to be built and run Windows which also exercises the rte_ctrl_thread_create API on Windows. Fixes: 5c307ba2a5b1 ("eal: register non-EAL threads as lcores") Signed-off-by: Tyler Retzlaff Reviewed-by: Stephen Hemminger Acked-by: David Marchand --- lib/librte_eal/windows/eal.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c index 892c69356d..e865427e97 100644 --- a/lib/librte_eal/windows/eal.c +++ b/lib/librte_eal/windows/eal.c @@ -437,6 +437,9 @@ rte_eal_init(int argc, char **argv) */ rte_eal_mp_remote_launch(sync_func, NULL, SKIP_MAIN); rte_eal_mp_wait_lcore(); + + eal_mcfg_complete(); + return fctret; } -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 09:36:28.384681399 +0000 +++ 0001-eal-windows-mark-memory-config-as-complete.patch 2023-02-23 09:36:28.166168835 +0000 @@ -1 +1 @@ -From 40032e5e0787fb311cc89c45bd681740b0c9e266 Mon Sep 17 00:00:00 2001 +From 77f9d2464c9a604214849c9c233a9e8dc8a0a7e9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 40032e5e0787fb311cc89c45bd681740b0c9e266 ] + @@ -19 +21 @@ - lib/eal/windows/eal.c | 3 +++ + lib/librte_eal/windows/eal.c | 3 +++ @@ -22,5 +24,5 @@ -diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c -index adb929a014..56fadc7afe 100644 ---- a/lib/eal/windows/eal.c -+++ b/lib/eal/windows/eal.c -@@ -462,6 +462,9 @@ rte_eal_init(int argc, char **argv) +diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c +index 892c69356d..e865427e97 100644 +--- a/lib/librte_eal/windows/eal.c ++++ b/lib/librte_eal/windows/eal.c +@@ -437,6 +437,9 @@ rte_eal_init(int argc, char **argv)