From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8ACF641D4F for ; Thu, 23 Feb 2023 10:37:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8674A43150; Thu, 23 Feb 2023 10:37:57 +0100 (CET) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mails.dpdk.org (Postfix) with ESMTP id 0C1BD43150 for ; Thu, 23 Feb 2023 10:37:56 +0100 (CET) Received: by mail-wm1-f47.google.com with SMTP id k37so5230881wms.0 for ; Thu, 23 Feb 2023 01:37:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=50kwD41SliwLEZjE8SZX0SIam1soOAIi49Yrp+mYbSs=; b=hlZjfpRjwp3wtzkdI27HSrCsCJox7+e6/U+pnbZTEZouJbrCcbdnHhM9oUnz+fF+xN WtSQr6/CaP8VACRU6LyWOxr2Jm3/38nCJKbPPjpyNrMxYtKUEYTchwY9yWDYApCdKQHP J2dIVhNpuL25BCkfLxIi5Rq9Xdu51NOnwfhS89ZJpuPY6k7E5Q9NLCkMFlHlTT6KB0Fh C6b6AlUaMhpydJJhCjnPCfJocgjEOihWBje/7sqdW9TxpwV2BiG+nudpLBziDP0bCrAv onEaFQx9it2hRjwSAkyX1eO+PjALkrItgR89e+Ku0zqIhHd4ltMb/sg7tRrcpPa604AF kpeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=50kwD41SliwLEZjE8SZX0SIam1soOAIi49Yrp+mYbSs=; b=Y5Fl0ZP3Lms0Hpwm/re3ep9F4B05cWuB5ax9DeWCOJs5xUU4W72nEwZZhxPbY7dwQt UX/6NjA8PMoPdT7EI08TVfGPJ8OieLNEXkmXfwOP1c0Cnb6Dp6dhn1rBx86zhYroC89v hNNL921sc8WMAEN/Lv6bnNyZOFf+iSEIn6ct0ij9HkdlVpXA+CQoJVL8vh41oXR74xIX +/Pjz18ENSx+7XKGQMYno4lNWpwsw5sA47nwLeBOZml2YzGJ7KJacyOCPn3I6g+rA29s JXJBAFicBu8FXb0jTvBwIhZAdj6djZFJ+AH9Ar1A2WFQiFYAdaasfXLk+qhuI1xJcTq6 9DKg== X-Gm-Message-State: AO0yUKUCe6qo0SUD8QgXyKsQ2jWeodKoLCTp+SfT0UAf5LrGJE0C+qtK fS96S02EqMjNIpBcwcsqA3myhUTATh4= X-Google-Smtp-Source: AK7set87YO99Q35yKrnIPilE0P6ITYPsNeLPrFxM2YPx+Pj+fkJNP/EMa1DwfSeYVq1Lx4cdhmMP6Q== X-Received: by 2002:a05:600c:1895:b0:3df:1673:90b6 with SMTP id x21-20020a05600c189500b003df167390b6mr8500086wmp.39.1677145075778; Thu, 23 Feb 2023 01:37:55 -0800 (PST) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id e6-20020a05600c4e4600b003e214803343sm10274867wmq.46.2023.02.23.01.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 01:37:55 -0800 (PST) From: luca.boccassi@gmail.com To: Gregory Etelson Cc: Ferruh Yigit , dpdk stable Subject: patch 'app/testpmd: fix interactive mode with no ports' has been queued to stable release 20.11.8 Date: Thu, 23 Feb 2023 09:36:15 +0000 Message-Id: <20230223093715.3926893-11-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230223093715.3926893-1-luca.boccassi@gmail.com> References: <20230223093715.3926893-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/b395818b0abc09e649e2f9e24a85abc8fcf3bfd1 Thanks. Luca Boccassi --- >From b395818b0abc09e649e2f9e24a85abc8fcf3bfd1 Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Thu, 19 Jan 2023 19:45:59 +0200 Subject: [PATCH] app/testpmd: fix interactive mode with no ports [ upstream commit 7e40372522c5a129da616d1420ff582968b81b46 ] Testpmd terminated unconditionally if it failed to start all ports. The patch allows testpmd to get into the command line, if the interactive mode was requested. Fixes: 6937d2103e22 ("app/testpmd: add option to not start device") Signed-off-by: Gregory Etelson Acked-by: Ferruh Yigit --- app/test-pmd/testpmd.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 13d8c1c72a..799fa9f539 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3990,8 +3990,13 @@ main(int argc, char** argv) } } - if (!no_device_start && start_port(RTE_PORT_ALL) != 0) - rte_exit(EXIT_FAILURE, "Start ports failed\n"); + if (!no_device_start && start_port(RTE_PORT_ALL) != 0) { + if (!interactive) { + rte_eal_cleanup(); + rte_exit(EXIT_FAILURE, "Start ports failed\n"); + } + fprintf(stderr, "Start ports failed\n"); + } /* set all ports to promiscuous mode by default */ RTE_ETH_FOREACH_DEV(port_id) { -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 09:36:28.742111733 +0000 +++ 0011-app-testpmd-fix-interactive-mode-with-no-ports.patch 2023-02-23 09:36:28.182169130 +0000 @@ -1 +1 @@ -From 7e40372522c5a129da616d1420ff582968b81b46 Mon Sep 17 00:00:00 2001 +From b395818b0abc09e649e2f9e24a85abc8fcf3bfd1 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7e40372522c5a129da616d1420ff582968b81b46 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 134d79a555..e366f81a0f 100644 +index 13d8c1c72a..799fa9f539 100644 @@ -24 +25 @@ -@@ -4483,8 +4483,13 @@ main(int argc, char** argv) +@@ -3990,8 +3990,13 @@ main(int argc, char** argv)