From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B191141D4F for ; Thu, 23 Feb 2023 10:37:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ACD2A43150; Thu, 23 Feb 2023 10:37:59 +0100 (CET) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mails.dpdk.org (Postfix) with ESMTP id 2BEA1427E9 for ; Thu, 23 Feb 2023 10:37:57 +0100 (CET) Received: by mail-wr1-f51.google.com with SMTP id r7so9968458wrz.6 for ; Thu, 23 Feb 2023 01:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AlBBY/xigPX3OPtVZSKd9mnKd5omDa4miJbCcoVuldM=; b=KlNMS6xKsBvHVOcpjQ3z9uZzadHC2Rj1zpMfattXEs/JNGYxonhw5KvVwd9rBc3tKb Rc3hkvedC1wnfccrAylWvWyVKq75rNUXNAhDg9CIHPSaayEGGxT3BmXK/rsY+h3jKMok v4kVFaUXfGXa/8I+D8BtKSUftr4PSxaHLY2D+G2VmQhF+KqHeOBKu3uUKOL1E9O3dtWi 0Xkl2d7U9EtfhtVRweMR+pXWtbTr9VyebNwpmqhKY5JP0XdMXzKwonFsGfTsONd/kjaw APPusoEq60UWoaeJhzVtHnvQyM8hkFWRLploN9fwfDlye9TfO8vTvn1hFx0C4RnMoTyv BWvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AlBBY/xigPX3OPtVZSKd9mnKd5omDa4miJbCcoVuldM=; b=NFMUCuedV7zrTxsNVIpdthn6HLvST3Qfc0URxYcK3MM3IB24gsbt5Pq7GF9T9Chx8d +IYkiq8xQgANEyaUil/VZvgfqTX8+hJvESmKc/CO3MBZzuqHS6y8hjhJDWNjfJj2XV67 SjZDRRH28BOECDM4UyrQSV5Nu7gNhO5UtOZUJRm1xzloHd+IwZFlHKrpciahxA3tscR9 Rkay43JobhYGOtYknRkQz4oJdiAP5t3/CcTyAS6Exy6Yb9Q0Iq/C5dmuv7i4BsQw/KC/ x6NJlTtRXCBZsSR4T0I+ztrOzVxinCqSK3otuuQK9yzZGWYhzgh25CPftdUiLe5nDJtk 6l2A== X-Gm-Message-State: AO0yUKXcFiQ/7rlzSpT/UaJ6R+IWsJgxanQrXlwZH+jVRA1CC/hr0V0l 2vVhGYgHiLlyzm08bbRc4xZrQ2FvHgE= X-Google-Smtp-Source: AK7set/SYxDqwRfz74E2CkCmyK7uzHKTJe4b6GwzHKIN3S0puQUhd1nAh1I8clsdS43P0UgYqUQusQ== X-Received: by 2002:a5d:4d50:0:b0:2c6:e7ff:8f17 with SMTP id a16-20020a5d4d50000000b002c6e7ff8f17mr9497800wru.25.1677145076875; Thu, 23 Feb 2023 01:37:56 -0800 (PST) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id u9-20020a5d5149000000b002c550eb062fsm8508099wrt.14.2023.02.23.01.37.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 01:37:56 -0800 (PST) From: luca.boccassi@gmail.com To: Megha Ajmera Cc: Cristian Dumitrescu , dpdk stable Subject: patch 'examples/qos_sched: fix debug mode' has been queued to stable release 20.11.8 Date: Thu, 23 Feb 2023 09:36:16 +0000 Message-Id: <20230223093715.3926893-12-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230223093715.3926893-1-luca.boccassi@gmail.com> References: <20230223093715.3926893-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/9533aa034b5aea24ab7687b79ab9a83e8ed66f53 Thanks. Luca Boccassi --- >From 9533aa034b5aea24ab7687b79ab9a83e8ed66f53 Mon Sep 17 00:00:00 2001 From: Megha Ajmera Date: Thu, 5 Jan 2023 12:28:53 +0000 Subject: [PATCH] examples/qos_sched: fix debug mode MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit af13b8711aa43a851d2c12e5d3f8f87dd047307e ] This issue is happening due to non-initialization of some fields in “rte_eth_rxconf” structure in our application. Doing a memset to zero before initialization in HQoS application. Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-by: Megha Ajmera Acked-by: Cristian Dumitrescu --- examples/qos_sched/init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index 1abe003fc6..33e8a75526 100644 --- a/examples/qos_sched/init.c +++ b/examples/qos_sched/init.c @@ -82,6 +82,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) if (app_inited_port_mask & (1u << portid)) return 0; + memset(&rx_conf, 0, sizeof(struct rte_eth_rxconf)); rx_conf.rx_thresh.pthresh = rx_thresh.pthresh; rx_conf.rx_thresh.hthresh = rx_thresh.hthresh; rx_conf.rx_thresh.wthresh = rx_thresh.wthresh; @@ -89,6 +90,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) rx_conf.rx_drop_en = 0; rx_conf.rx_deferred_start = 0; + memset(&tx_conf, 0, sizeof(struct rte_eth_txconf)); tx_conf.tx_thresh.pthresh = tx_thresh.pthresh; tx_conf.tx_thresh.hthresh = tx_thresh.hthresh; tx_conf.tx_thresh.wthresh = tx_thresh.wthresh; -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 09:36:28.781443820 +0000 +++ 0012-examples-qos_sched-fix-debug-mode.patch 2023-02-23 09:36:28.182169130 +0000 @@ -1 +1 @@ -From af13b8711aa43a851d2c12e5d3f8f87dd047307e Mon Sep 17 00:00:00 2001 +From 9533aa034b5aea24ab7687b79ab9a83e8ed66f53 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit af13b8711aa43a851d2c12e5d3f8f87dd047307e ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 0709aec10c..d28350e14a 100644 +index 1abe003fc6..33e8a75526 100644 @@ -26 +27 @@ -@@ -79,6 +79,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) +@@ -82,6 +82,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) @@ -34 +35 @@ -@@ -86,6 +87,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) +@@ -89,6 +90,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp)