From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76F3841D4F for ; Thu, 23 Feb 2023 10:38:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72E9D4317F; Thu, 23 Feb 2023 10:38:13 +0100 (CET) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mails.dpdk.org (Postfix) with ESMTP id 9B42343152 for ; Thu, 23 Feb 2023 10:38:12 +0100 (CET) Received: by mail-wm1-f47.google.com with SMTP id k37so5232084wms.0 for ; Thu, 23 Feb 2023 01:38:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7+rOnPGMUWE5gi8vZGVe0JyUQZgAXP6iPGZbwp3LouY=; b=Olf7ZDLDiTAmB9k0umjvoFSbjMSUA9PltruqG+s8SQtRLmFBgqIEUz6x+/WfdiN/m6 3PtPibeE/b1SIWmr27mEGq+ZIOT2Sitqa1Rq1ZL/G/0YXPGCVkH6VJLkZFGTMOpZ6gtr +6cax7VP9tFN7NIvJqzU8leA3BTG+Aiu5VHwFreIbZEbg5tIgfo3tiFlYe38dnrrrj0H VcGDHNEcB4+F/5L9pDi+6w2sZ/8ELLF6Ls6KlNAXgkJnfDYtV2cp5abE6gMKLTcEd69E FZdTfNKI+yOLHQthd96VmemkTspS+abAIsnas8Xnr4X0t98I7orIP8/bRpZft+GGKMsl 2gTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7+rOnPGMUWE5gi8vZGVe0JyUQZgAXP6iPGZbwp3LouY=; b=G8h/b8DzZ20z3Y9OJK+TQpMV3k+YRP63EMO7bhnrwszzM2b4bzVZXayxnMc4el2h7T YwEQpiMaL6o+S1BXR5YuOai82gM//zvADMYoWbdics+jbpQFv3n+KO+dchMNFoJNs605 3mV5B3MrlDC32X+l5PWYrOQP7Ayjh4xVbLg0XO7EuoWuTYYOs5uifJ7spjTRoDBRvX1Y 08/t1njd982DSscNcxUa395uSYUtkem/FOrgfBPAR0i/vTVO7kPBx0J0UDuQr+wwZXER 7yhgkPuTTcyRlDIC8DdiHLPt4qsner5lCI4QT+GKChrlClKEeNHDfxPK4VQCFAGY6Z6v QHTg== X-Gm-Message-State: AO0yUKW/RXw26lJ5XA2NuHCBAb/emb4i5t5Ej1ssz/3MR/A3JNFmP708 pw6rhxxTXwz5h4OLWZbY1N1wagd5Pgg= X-Google-Smtp-Source: AK7set9g3KaiNup63Rc5okRLK/+31KZ6b4mXnJTepJF3DAyIDryLEp6hxJFMSrNcMjzCZFpyqYNlSA== X-Received: by 2002:a05:600c:4d06:b0:3dd:1c45:d592 with SMTP id u6-20020a05600c4d0600b003dd1c45d592mr8369962wmp.19.1677145092348; Thu, 23 Feb 2023 01:38:12 -0800 (PST) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id h13-20020a05600c314d00b003e2059c7978sm10906754wmo.36.2023.02.23.01.38.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 01:38:11 -0800 (PST) From: luca.boccassi@gmail.com To: Nicolas Chautru Cc: Maxime Coquelin , dpdk stable Subject: patch 'app/bbdev: add allocation checks' has been queued to stable release 20.11.8 Date: Thu, 23 Feb 2023 09:36:21 +0000 Message-Id: <20230223093715.3926893-17-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230223093715.3926893-1-luca.boccassi@gmail.com> References: <20230223093715.3926893-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/eb40823a13fe79a6f0328015f4c2e6587f6dd8bb Thanks. Luca Boccassi --- >From eb40823a13fe79a6f0328015f4c2e6587f6dd8bb Mon Sep 17 00:00:00 2001 From: Nicolas Chautru Date: Tue, 13 Dec 2022 08:18:55 -0800 Subject: [PATCH] app/bbdev: add allocation checks [ upstream commit 8abe31b1d9d9448ab4ab1d98a22314a2fa9fbfc6 ] Adding check for error on return of the rte_bbdev_*_op_alloc_bulk calls in bbdev-test. Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 36589f3c3e..f38d991f87 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -4361,7 +4361,8 @@ offload_latency_test_dec(struct rte_mempool *mempool, struct test_buffers *bufs, if (unlikely(num_to_process - dequeued < burst_sz)) burst_sz = num_to_process - dequeued; - rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz); + ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz); + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); if (test_vector.op_type != RTE_BBDEV_OP_NONE) copy_reference_dec_op(ops_enq, burst_sz, dequeued, bufs->inputs, @@ -4446,7 +4447,8 @@ offload_latency_test_ldpc_dec(struct rte_mempool *mempool, if (unlikely(num_to_process - dequeued < burst_sz)) burst_sz = num_to_process - dequeued; - rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz); + ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz); + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); if (test_vector.op_type != RTE_BBDEV_OP_NONE) copy_reference_ldpc_dec_op(ops_enq, burst_sz, dequeued, bufs->inputs, -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 09:36:28.967985419 +0000 +++ 0017-app-bbdev-add-allocation-checks.patch 2023-02-23 09:36:28.194169351 +0000 @@ -1 +1 @@ -From 8abe31b1d9d9448ab4ab1d98a22314a2fa9fbfc6 Mon Sep 17 00:00:00 2001 +From eb40823a13fe79a6f0328015f4c2e6587f6dd8bb Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8abe31b1d9d9448ab4ab1d98a22314a2fa9fbfc6 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -15,2 +16,2 @@ - app/test-bbdev/test_bbdev_perf.c | 9 ++++++--- - 1 file changed, 6 insertions(+), 3 deletions(-) + app/test-bbdev/test_bbdev_perf.c | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) @@ -19 +20 @@ -index 90eff6364e..e001074861 100644 +index 36589f3c3e..f38d991f87 100644 @@ -22,11 +23 @@ -@@ -4958,7 +4958,8 @@ offload_latency_test_fft(struct rte_mempool *mempool, struct test_buffers *bufs, - if (unlikely(num_to_process - dequeued < burst_sz)) - burst_sz = num_to_process - dequeued; - -- rte_bbdev_fft_op_alloc_bulk(mempool, ops_enq, burst_sz); -+ ret = rte_bbdev_fft_op_alloc_bulk(mempool, ops_enq, burst_sz); -+ TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); - if (test_vector.op_type != RTE_BBDEV_OP_NONE) - copy_reference_fft_op(ops_enq, burst_sz, dequeued, - bufs->inputs, -@@ -5039,7 +5040,8 @@ offload_latency_test_dec(struct rte_mempool *mempool, struct test_buffers *bufs, +@@ -4361,7 +4361,8 @@ offload_latency_test_dec(struct rte_mempool *mempool, struct test_buffers *bufs, @@ -42 +33 @@ -@@ -5124,7 +5126,8 @@ offload_latency_test_ldpc_dec(struct rte_mempool *mempool, +@@ -4446,7 +4447,8 @@ offload_latency_test_ldpc_dec(struct rte_mempool *mempool,