From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A003941D4F for ; Thu, 23 Feb 2023 10:38:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BB1E4318C; Thu, 23 Feb 2023 10:38:14 +0100 (CET) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mails.dpdk.org (Postfix) with ESMTP id C1E8643158 for ; Thu, 23 Feb 2023 10:38:13 +0100 (CET) Received: by mail-wm1-f51.google.com with SMTP id ay29-20020a05600c1e1d00b003e9f4c2b623so2919733wmb.3 for ; Thu, 23 Feb 2023 01:38:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nxNSqdOadFXpXrieRXKERWEwWLhPOJ2WyqJHnyyft1o=; b=GpysgJejRougdegjCHjuGDJ/kL1KdLjv1kO2agkpzPW4yECLn+Pb/RnpCqQ575rEoj W7805c4FXpHuuWnmmYuj4MH5hPbSTezVqegV1qL4UDg/9Q9xgdBmh3iEmjlJAj5pBZJd lmvE5RA8AuWxbQw9zdxDbg/HN+gIR+s8CgUciXlovZ0jAagMn7LH8XDRj1d1HBAhPxTt RsERAuLMfvUgDY9SqzjgbotHAaYIi4ogYW+PrPpV6cTWis76ILd2gh5cZNtQr4rEZhNH vs+dtIiUwjv9wInrYP5OsWhVfKRdaqhI37BPH+PYxXSb44P3Ltp/NiEyX7k14qpYfEAk MxBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nxNSqdOadFXpXrieRXKERWEwWLhPOJ2WyqJHnyyft1o=; b=YhL5Iw0kn1s98tVz0OGBHY+OBG0bF6ltjAVHnBLwUFPg37C3EPeR+y5RxmQ4sOwQrg LCLFSTFLVuRFcj9YbbyuM35pg8HuHyC/7BXR0wLW3egXfqDfpLGA9rDlCC3L2Yrc6FKH e5hled3Wu41yj4AJHyPqcjdp3OWECWe4j7rvvKpwphdlwGuljYTn+RkhEM7W9FYicZD4 GnaZNHycTj1Ickdn0TpUu4kVuRnLDVBsWeo7VSTABoDvCOXAhT14tE4mZQmkbN4kN4Qn kEeGbnUA9wiHC9yyoAETtm40TGBEMsUUT42KTA2CiWMCn5XK/qq1riipDMF3yP7Gu169 2qxA== X-Gm-Message-State: AO0yUKUp9sygGpx5ZluMIWnurHvFdWIvf7UWH+gioHyAmaj6Jwv/HDkw AyV45O1aAQU+Mu9V9OWyOSg= X-Google-Smtp-Source: AK7set+IWI3rbtKDC9MquCuEDJgIbDy6OcFXRg+E/yyx+dUleJNJVnfeQ7eTf2vKis2MDVzbIuiWwQ== X-Received: by 2002:a05:600c:4b28:b0:3e2:6ec:61ea with SMTP id i40-20020a05600c4b2800b003e206ec61eamr8995953wmp.28.1677145093488; Thu, 23 Feb 2023 01:38:13 -0800 (PST) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id m6-20020a05600c4f4600b003df245cd853sm13144783wmq.44.2023.02.23.01.38.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 01:38:13 -0800 (PST) From: luca.boccassi@gmail.com To: Hernan Vargas Cc: Maxime Coquelin , dpdk stable Subject: patch 'baseband/acc: fix memory leak on acc100 close' has been queued to stable release 20.11.8 Date: Thu, 23 Feb 2023 09:36:22 +0000 Message-Id: <20230223093715.3926893-18-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230223093715.3926893-1-luca.boccassi@gmail.com> References: <20230223093715.3926893-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/cb5f9847826edc8834caa9a53959a20d2d5670d3 Thanks. Luca Boccassi --- >From cb5f9847826edc8834caa9a53959a20d2d5670d3 Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Thu, 12 Jan 2023 11:36:03 -0800 Subject: [PATCH] baseband/acc: fix memory leak on acc100 close [ upstream commit 1bc7f26ebd45da2ab2740a00c991100dc8f0037d ] Explicitly call rte_free for harq_layout pointer in dev_close function to prevent memory leak. Fixes: ba2262fe16c ("baseband/acc100: fix close cleanup") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc100/rte_acc100_pmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c index 1d4b25328a..ec0f045754 100644 --- a/drivers/baseband/acc100/rte_acc100_pmd.c +++ b/drivers/baseband/acc100/rte_acc100_pmd.c @@ -778,6 +778,7 @@ acc100_dev_close(struct rte_bbdev *dev) rte_free(d->tail_ptrs); rte_free(d->info_ring); rte_free(d->sw_rings_base); + rte_free(d->harq_layout); d->sw_rings_base = NULL; d->tail_ptrs = NULL; d->info_ring = NULL; -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 09:36:29.007907458 +0000 +++ 0018-baseband-acc-fix-memory-leak-on-acc100-close.patch 2023-02-23 09:36:28.202169498 +0000 @@ -1 +1 @@ -From 1bc7f26ebd45da2ab2740a00c991100dc8f0037d Mon Sep 17 00:00:00 2001 +From cb5f9847826edc8834caa9a53959a20d2d5670d3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1bc7f26ebd45da2ab2740a00c991100dc8f0037d ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -15 +16 @@ - drivers/baseband/acc/rte_acc100_pmd.c | 1 + + drivers/baseband/acc100/rte_acc100_pmd.c | 1 + @@ -18,5 +19,5 @@ -diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c -index b3164529dd..146a22bd64 100644 ---- a/drivers/baseband/acc/rte_acc100_pmd.c -+++ b/drivers/baseband/acc/rte_acc100_pmd.c -@@ -620,6 +620,7 @@ acc100_dev_close(struct rte_bbdev *dev) +diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c +index 1d4b25328a..ec0f045754 100644 +--- a/drivers/baseband/acc100/rte_acc100_pmd.c ++++ b/drivers/baseband/acc100/rte_acc100_pmd.c +@@ -778,6 +778,7 @@ acc100_dev_close(struct rte_bbdev *dev)