From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9D5741D4F for ; Thu, 23 Feb 2023 10:38:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5F0F43158; Thu, 23 Feb 2023 10:38:59 +0100 (CET) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mails.dpdk.org (Postfix) with ESMTP id 0F61643150 for ; Thu, 23 Feb 2023 10:38:58 +0100 (CET) Received: by mail-wr1-f41.google.com with SMTP id v3so10061275wrp.2 for ; Thu, 23 Feb 2023 01:38:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B9nYS+YBbMp0Z6zF6YvxpPWl3i8D0K373gam4Qm0prE=; b=mftO7G2b0LQWqi1/QN3rqsihVNfGyAp/hgp/zKJWj1YvK+7+mUY/EoFNNhpDCEGQw9 qtH/DZTHQAD8/0qeQfghEkSxo69FXifLeAK9wCNTR0uLg2XsC0G0KoYh3TowPaDXpBdB D4weotdiERznG95iQMEuLL06LhpIkPcaaCPD3ik11ON1jPXMMrXuxX4PdcIX7dQI2Jgk PQnIyNg4YFSuqauO1OneRSi239oMvcDU5vz7eI0uiHSwhRJKTAk7HoVtuhyHpbXGMddl nu0/XHhthOivnx1ET3xOv9SFK0oaBpTG1//Cj9PyDBFxkrHxrjnTf//2VmFjYcTV4CCH R5nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B9nYS+YBbMp0Z6zF6YvxpPWl3i8D0K373gam4Qm0prE=; b=2yorJP0VNXSWyVcws80TDZyJJj1+u/f+FJ97c4O2BfxxRLloou0N8K5TNDy83g2rdw 5OY7d3DeNtezZVwHsewHEKAyiHYC2G8BIzA8BGtA2MU53dGmqcCMX8HgbsPTdMvdijZT T6mtd0yhBb/yCniZitbAG4XVyOtmGx4jpxC6zBVxCHaG/MtM/pQFGyJvUWjMcq3CYwsT kl/+MsvXs4jcuGyS30EgjWoQCO55+VTfIhuxsA73yqzO7exJOKibTg/B43Ae0NEP/2lW ooW/LmQ2RK9LRJ2sQQKmzWHIik/GLyzy/Z5qsO2NOlzzKf6nqzn7l7CsRF5rmP63QxaU sXpg== X-Gm-Message-State: AO0yUKVhUso00rZm3u3cGETbaC+GxaOnPmCXfKQfJNMkmiL0sF2u1TsN aVK5BLOnb7xKjFo3wyUy+XyFT8VrNeggfg== X-Google-Smtp-Source: AK7set80QCOKJCyvRIYBQsaKm3KRg+K5C7QvrPkiOOEKnPFDhofF9XI0OOvK52Wn1miu9OQxq2gCEA== X-Received: by 2002:adf:f2ce:0:b0:2c7:1210:fe5b with SMTP id d14-20020adff2ce000000b002c71210fe5bmr1137235wrp.49.1677145137831; Thu, 23 Feb 2023 01:38:57 -0800 (PST) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id o18-20020a05600c4fd200b003e9ded91c27sm3352410wmq.4.2023.02.23.01.38.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 01:38:57 -0800 (PST) From: luca.boccassi@gmail.com To: Maxime Coquelin Cc: Chenbo Xia , Kevin Traynor , dpdk stable Subject: patch 'vhost: decrease log level for unimplemented requests' has been queued to stable release 20.11.8 Date: Thu, 23 Feb 2023 09:36:35 +0000 Message-Id: <20230223093715.3926893-31-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230223093715.3926893-1-luca.boccassi@gmail.com> References: <20230223093715.3926893-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/08a43750b568989f171f8c2bd1caa7ad398da7e9 Thanks. Luca Boccassi --- >From 08a43750b568989f171f8c2bd1caa7ad398da7e9 Mon Sep 17 00:00:00 2001 From: Maxime Coquelin Date: Mon, 6 Feb 2023 16:07:33 +0100 Subject: [PATCH] vhost: decrease log level for unimplemented requests [ upstream commit 43ccd55fdd6ab34b55060045594cc21aefa74383 ] This patch changes VHOST_USER_SET_VRING_ERR and VHOST_USER_SET_LOG_FD "not implemented" log levels from INFO to DEBUG, as implementing these requests is not mandatory. Having them being displayed at INFO level may induce some confusion to the end-user. Fixes: fd29c33b651a ("vhost: handle unsupported message types in functions") Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Acked-by: Kevin Traynor --- lib/librte_vhost/vhost_user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index da04a37867..93781f4b80 100644 --- a/lib/librte_vhost/vhost_user.c +++ b/lib/librte_vhost/vhost_user.c @@ -1679,7 +1679,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev __rte_unused, if (!(msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK)) close(msg->fds[0]); - VHOST_LOG_CONFIG(INFO, "not implemented\n"); + VHOST_LOG_CONFIG(DEBUG, "not implemented\n"); return RTE_VHOST_MSG_RESULT_OK; } @@ -2191,7 +2191,7 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused, return RTE_VHOST_MSG_RESULT_ERR; close(msg->fds[0]); - VHOST_LOG_CONFIG(INFO, "not implemented.\n"); + VHOST_LOG_CONFIG(DEBUG, "not implemented.\n"); return RTE_VHOST_MSG_RESULT_OK; } -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 09:36:29.495272824 +0000 +++ 0031-vhost-decrease-log-level-for-unimplemented-requests.patch 2023-02-23 09:36:28.230170013 +0000 @@ -1 +1 @@ -From 43ccd55fdd6ab34b55060045594cc21aefa74383 Mon Sep 17 00:00:00 2001 +From 08a43750b568989f171f8c2bd1caa7ad398da7e9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 43ccd55fdd6ab34b55060045594cc21aefa74383 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ - lib/vhost/vhost_user.c | 4 ++-- + lib/librte_vhost/vhost_user.c | 4 ++-- @@ -22,5 +23,5 @@ -diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c -index 8c1d60b76b..b4236820a2 100644 ---- a/lib/vhost/vhost_user.c -+++ b/lib/vhost/vhost_user.c -@@ -1818,7 +1818,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev, +diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c +index da04a37867..93781f4b80 100644 +--- a/lib/librte_vhost/vhost_user.c ++++ b/lib/librte_vhost/vhost_user.c +@@ -1679,7 +1679,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev __rte_unused, @@ -28,4 +29,4 @@ - if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK)) - close(ctx->fds[0]); -- VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n"); -+ VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n"); + if (!(msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK)) + close(msg->fds[0]); +- VHOST_LOG_CONFIG(INFO, "not implemented\n"); ++ VHOST_LOG_CONFIG(DEBUG, "not implemented\n"); @@ -35 +36 @@ -@@ -2340,7 +2340,7 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev, +@@ -2191,7 +2191,7 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused, @@ -38,3 +39,3 @@ - close(ctx->fds[0]); -- VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented.\n"); -+ VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented.\n"); + close(msg->fds[0]); +- VHOST_LOG_CONFIG(INFO, "not implemented.\n"); ++ VHOST_LOG_CONFIG(DEBUG, "not implemented.\n");