From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61C3441D4F for ; Thu, 23 Feb 2023 10:39:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D2F743150; Thu, 23 Feb 2023 10:39:32 +0100 (CET) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mails.dpdk.org (Postfix) with ESMTP id 8271243158 for ; Thu, 23 Feb 2023 10:39:30 +0100 (CET) Received: by mail-wr1-f48.google.com with SMTP id t15so10244982wrz.7 for ; Thu, 23 Feb 2023 01:39:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8Li49NGtNTdrvWtTJqmgzU750VLVuXjWMTwZp3/aunI=; b=pT/X8OiQ0eb2oLz9Fh78av5vgZC+LfC6VXnDj7tLHp9Sb4oOprdmjciqd7NDRqVDER o//OMPmYXDhOtmKcb7Sq6dbAWmeYk+bMclxrszxwzxQFdCZh5uHp0cECp0BYV/Bd9M+F LXlbVB1VHobLWWXt2tdZ68rwSFVbwmKMdNbTQv6dkHYj8TaokBK7dTaMt6bQMlIe8Ftu 8x5PwC9KqsOowD2VoPVsVerL7VumffZ+d3awa0qiyNSI1s8OgafIuJT3iV8Si79fO72A maLw6jwGRCN46L6pypiHszeda9IH5AOyhHDhdbwTjn7PzVcap2gRoNpLDbGsrHHA3lEl Z02A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Li49NGtNTdrvWtTJqmgzU750VLVuXjWMTwZp3/aunI=; b=jEnwTBYd3V51NanSXpoeDAIiBPCRct2HF8mbVkjkI3HMiFEAVK3PiKB/ScCMGUUIhK vciIVlM2cj9Er8n++sIYDND4PgpUrYhNL2l1YPEsnX0lWQNyPXR7PDDaFsM4Ac+vS3ye jgD2/PCT6CFiYl3/NslFuk4r+wP5VYz5hFhZsRqEzqfS6LdAmjnfQnfNXGhL91eK/L5F t5KBC/+imPm2SVBM1ApUibeLRv3PvF0nj20HpFnc2m/lD/P80sXOQETb9UwjtJRIW95o Y2x3FkEC5ulfXyh75rugHhTvJF+A4EupZYoDxSY4xUBMPb2mZZohyokEB/f2CT2m5bfX 4Fdg== X-Gm-Message-State: AO0yUKVgo+ON4N8/bDtTd71FTxXmRp0vZvTHgJ/7eUpLcBgRbWxvtAv3 3JiwpGM3Gc3O8b47hS68oHE= X-Google-Smtp-Source: AK7set8jHk3Ha+8iHmioDX0F4tGx4IRkG+9jyaEajtqwWVV4GDM9ClEls3S2JTOSGS/aFx655Mg1/g== X-Received: by 2002:a5d:4b48:0:b0:2c3:e0a0:94f with SMTP id w8-20020a5d4b48000000b002c3e0a0094fmr10198295wrs.37.1677145170148; Thu, 23 Feb 2023 01:39:30 -0800 (PST) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id r13-20020adfdc8d000000b002c557f82e27sm7902467wrj.99.2023.02.23.01.39.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 01:39:29 -0800 (PST) From: luca.boccassi@gmail.com To: Huisong Li Cc: Dongdong Liu , dpdk stable Subject: patch 'net/hns3: fix clearing RSS configuration' has been queued to stable release 20.11.8 Date: Thu, 23 Feb 2023 09:36:46 +0000 Message-Id: <20230223093715.3926893-42-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230223093715.3926893-1-luca.boccassi@gmail.com> References: <20230223093715.3926893-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/3463844614179865471d552dbd54d1bf0d3a5c19 Thanks. Luca Boccassi --- >From 3463844614179865471d552dbd54d1bf0d3a5c19 Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Tue, 31 Jan 2023 21:02:55 +0800 Subject: [PATCH] net/hns3: fix clearing RSS configuration [ upstream commit 1aa5222454725001939ff571e685225f6cf85653 ] When a RSS rule has an unsupported action, the RSS configuration is cleared by mistake. Remove clearing RSS configuration in this case. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c index 0ce4cd1e2a..67379d5bbb 100644 --- a/drivers/net/hns3/hns3_flow.c +++ b/drivers/net/hns3/hns3_flow.c @@ -1389,12 +1389,10 @@ hns3_parse_rss_filter(struct rte_eth_dev *dev, /* Check if the next not void action is END */ NEXT_ITEM_OF_ACTION(act, actions, act_index); - if (act->type != RTE_FLOW_ACTION_TYPE_END) { - memset(rss_conf, 0, sizeof(struct hns3_rss_conf)); + if (act->type != RTE_FLOW_ACTION_TYPE_END) return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, act, "Not supported action."); - } return 0; } -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 09:36:29.919208143 +0000 +++ 0042-net-hns3-fix-clearing-RSS-configuration.patch 2023-02-23 09:36:28.270170750 +0000 @@ -1 +1 @@ -From 1aa5222454725001939ff571e685225f6cf85653 Mon Sep 17 00:00:00 2001 +From 3463844614179865471d552dbd54d1bf0d3a5c19 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1aa5222454725001939ff571e685225f6cf85653 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index de38a42048..5711757684 100644 +index 0ce4cd1e2a..67379d5bbb 100644 @@ -24 +25 @@ -@@ -1421,12 +1421,10 @@ hns3_parse_rss_filter(struct rte_eth_dev *dev, +@@ -1389,12 +1389,10 @@ hns3_parse_rss_filter(struct rte_eth_dev *dev,