From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8808541D4F for ; Thu, 23 Feb 2023 10:40:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 840234319C; Thu, 23 Feb 2023 10:40:21 +0100 (CET) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id 11C8A43152 for ; Thu, 23 Feb 2023 10:40:19 +0100 (CET) Received: by mail-wr1-f49.google.com with SMTP id t13so10068437wrv.13 for ; Thu, 23 Feb 2023 01:40:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m3ySnJnKKcnLuYJObgEuU/tp/JZ3hw0jhFABg2W3KoI=; b=fmm7Ty/ETiLLNag9v1oYOoCNSW0WSQIh/QxELJPElp+Vq7rETq16xAtJIkoFB3rpuC sYJCxBGlRT4jClgWvzSb1Wg7CMJ3AMQqpQe5LVpS5rCeUQBKDUe422MCJ8l1M7KHj+HC 4Rbi+UWLt3YKdwSkoQAq8CJ2NQHh1v4851KkDnGRUhtDuxbAff5ilpc6A2zdxwBuOR5H 07EJ+H33tZvbc+ojs6xzQ/N/zUkj6RdQXo+9d1mUl+YlAUPvG4WPRbi09isxUxY7G5au b57PvMwRS78vRQG65WH/X5C+fM7E00lQxPoeva4x0n+4uh0xVEyI9sEQyd6MuU63rK47 cHnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m3ySnJnKKcnLuYJObgEuU/tp/JZ3hw0jhFABg2W3KoI=; b=bp78yq0fBCMzGSA9qIENWOzt1gU2q2usWKl5DHqfr5W4b2gnYBkc0Zc9fyWhRnJRqv cPZZfK0lV3zL2o3yRiuUmL9mUziUclFsvwJNH8BIIcq7kyjbtLMdcHpFD0o5O2IRwsXQ ZBiJ7eYh8x4iSWp+x4yjA5PkzqUqnp7yRH9sJvpHSrTM94amE8MaJg8lEiaBttMYM8ps hi65OaqLdUeNSAfhUy4Qy+3I7XVoP/NdeABPAxJ/ly8LsQr3g2pNPivy3GECrc31BB5Q lSadv8yzh7xjl5XCEaqhSRDmW0mGqf2LNgTQN9mMRrxLcnGNI0jvG4UM2aCgsi4429xk xaVQ== X-Gm-Message-State: AO0yUKWZaduYB1QNbphXendm1lMfPy5xBobe86hAzVHYQFVGcOsCSxZ/ El0Jtw+6rl8OkyrsSh1jzmL37W2zE71Dog== X-Google-Smtp-Source: AK7set87EiI/X6o11Jy9KCn58PsrJM2Yto0SgNBaZMiLVv/MYZNwGp5cIiyNpTMwP4d+utREfStluQ== X-Received: by 2002:adf:f70b:0:b0:2c6:67c9:860a with SMTP id r11-20020adff70b000000b002c667c9860amr10518445wrp.44.1677145218809; Thu, 23 Feb 2023 01:40:18 -0800 (PST) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id l18-20020a5d4112000000b002c56179d39esm10856595wrp.44.2023.02.23.01.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 01:40:18 -0800 (PST) From: luca.boccassi@gmail.com To: David Marchand Cc: Qi Zhang , dpdk stable Subject: patch 'net/iavf: protect insertion in flow list' has been queued to stable release 20.11.8 Date: Thu, 23 Feb 2023 09:37:03 +0000 Message-Id: <20230223093715.3926893-59-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230223093715.3926893-1-luca.boccassi@gmail.com> References: <20230223093715.3926893-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/2f6bcfd34b4ea29d60bc6ab0b57627d21cb2b159 Thanks. Luca Boccassi --- >From 2f6bcfd34b4ea29d60bc6ab0b57627d21cb2b159 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 5 Jan 2023 14:57:43 +0100 Subject: [PATCH] net/iavf: protect insertion in flow list [ upstream commit d79c3b264e31465695bc4c6279381522060a22f6 ] Add missing lock acquire. Fixes: ff2d0c345c3b ("net/iavf: support generic flow API") Signed-off-by: David Marchand Acked-by: Qi Zhang --- drivers/net/iavf/iavf_generic_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_generic_flow.c b/drivers/net/iavf/iavf_generic_flow.c index 00e7f15c33..0df67befe2 100644 --- a/drivers/net/iavf/iavf_generic_flow.c +++ b/drivers/net/iavf/iavf_generic_flow.c @@ -1246,11 +1246,12 @@ iavf_flow_create(struct rte_eth_dev *dev, } flow->engine = engine; + rte_spinlock_lock(&vf->flow_ops_lock); TAILQ_INSERT_TAIL(&vf->flow_list, flow, node); + rte_spinlock_unlock(&vf->flow_ops_lock); PMD_DRV_LOG(INFO, "Succeeded to create (%d) flow", engine->type); free_flow: - rte_spinlock_unlock(&vf->flow_ops_lock); return flow; } -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 09:36:30.588094200 +0000 +++ 0059-net-iavf-protect-insertion-in-flow-list.patch 2023-02-23 09:36:28.334171928 +0000 @@ -1 +1 @@ -From d79c3b264e31465695bc4c6279381522060a22f6 Mon Sep 17 00:00:00 2001 +From 2f6bcfd34b4ea29d60bc6ab0b57627d21cb2b159 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d79c3b264e31465695bc4c6279381522060a22f6 ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index f33c764764..6f6e95fc45 100644 +index 00e7f15c33..0df67befe2 100644 @@ -21 +22 @@ -@@ -2278,11 +2278,12 @@ iavf_flow_create(struct rte_eth_dev *dev, +@@ -1246,11 +1246,12 @@ iavf_flow_create(struct rte_eth_dev *dev,