From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 9356A41D4F
for <public@inbox.dpdk.org>; Thu, 23 Feb 2023 10:40:35 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 8E44F4319C;
Thu, 23 Feb 2023 10:40:35 +0100 (CET)
Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com
[209.85.221.52]) by mails.dpdk.org (Postfix) with ESMTP id 89A17427E9
for <stable@dpdk.org>; Thu, 23 Feb 2023 10:40:33 +0100 (CET)
Received: by mail-wr1-f52.google.com with SMTP id r7so9975555wrz.6
for <stable@dpdk.org>; Thu, 23 Feb 2023 01:40:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=K4j0IpWlEajIQBrZT3QcCT4Fx7mrUC0/0SsTrQ6U2t0=;
b=E1OMQ+o0rZ039Jul8ASHhVRF1a+xIdl/7xPGa8qXGzQag2aAxkHVS2skBMEc+lMFiY
HSxvA0k+vtg7FHx7eTmr6pU+pGeLyH9YanBdp2b922LceBtnKRVLH+ooEXvz9ktdJObF
x25Q24OEGEuf7nNCa6mexb2dJaPxw26m6bQcjd4xwSo5UbZ8J0Fq8tawyJDd530pT2hS
IycGbrNTX92zXImmKqTYANLyJ6/G9zQFqPbz636+PqEhebbMxwuWDGAWQz7+xleRyTZq
FS9YfBBB7UEPHa1PjvKo7Jci+l9vHaKWGMkcS4dD+F2tGlfqqBqXc6Sx/HHoLGo+LO42
67YQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=K4j0IpWlEajIQBrZT3QcCT4Fx7mrUC0/0SsTrQ6U2t0=;
b=mYZYsASm4LRHk5Ocz07Ro6Y3desWoBUhbGtGbRs5XGeKPfPAOXx7KFp1hXp/fdgKab
ul5zgyRil3139AfRecoSUHYElyjQ2T/iiDRwUdZ5gHEoAmDgpBUBsjonq0o4JfcoDtqI
wF7KNkatgR0T6Oh0oc0Xk2QE/jmVlltcKeSQMNzFoD/Q9wfDpj8kdAhosqcVKt2SJyeB
s+gI/oXvErdu6qsSJftW3P8J+Oq5T17y5XyXTJiUqa9RUACl+MedWsGbxszmzF3DIsJz
9Va9eixwhAiri2hxCDq/vLCAv4SN3bZX/pF0APc9ekQCko0F7HkrvocyfOgrPnHoTHfr
KVnw==
X-Gm-Message-State: AO0yUKUNbH4XKoawcVoYrFXcLjX1oUSDlhMP6zjx3vXXs7T5q7y9QVCo
0PANiXgjx+DQ0CnsWf5L6Kc=
X-Google-Smtp-Source: AK7set+BKlsp+pnxLfficWpKHokK1Nrqo4t5vwk1Z5yGeKrGvdRt7SAIOYsGtSOnevtr2Aj9QBU1KQ==
X-Received: by 2002:adf:f3cd:0:b0:2c7:1324:dba8 with SMTP id
g13-20020adff3cd000000b002c71324dba8mr999734wrp.49.1677145233329;
Thu, 23 Feb 2023 01:40:33 -0800 (PST)
Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id
c24-20020a7bc858000000b003e11ad0750csm7723155wml.47.2023.02.23.01.40.32
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 23 Feb 2023 01:40:32 -0800 (PST)
From: luca.boccassi@gmail.com
To: Edwin Brossette <edwin.brossette@6wind.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'net/bnxt: fix link state change interrupt config' has been
queued to stable release 20.11.8
Date: Thu, 23 Feb 2023 09:37:07 +0000
Message-Id: <20230223093715.3926893-63-luca.boccassi@gmail.com>
X-Mailer: git-send-email 2.39.1
In-Reply-To: <20230223093715.3926893-1-luca.boccassi@gmail.com>
References: <20230223093715.3926893-1-luca.boccassi@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Hi,
FYI, your patch has been queued to stable release 20.11.8
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/25/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/de481ff9ddb85bddac2834cbdae53280a119aa3d
Thanks.
Luca Boccassi
---
>From de481ff9ddb85bddac2834cbdae53280a119aa3d Mon Sep 17 00:00:00 2001
From: Edwin Brossette <edwin.brossette@6wind.com>
Date: Mon, 6 Feb 2023 18:11:13 +0100
Subject: [PATCH] net/bnxt: fix link state change interrupt config
[ upstream commit 60653f4a25bd87a32bc148461f32566af997da8b ]
When getting the device's info via bnxt_dev_info_get_op(), the device
enables interrupts on link state changes because of the following line:
eth_dev->data->dev_conf.intr_conf.lsc = 1;
Enabling this mode might not be wanted by the user.
The flag RTE_ETH_DEV_INTR_LSC can be used to inform the above
application that LSC interrupts are supported. Thus, checking this flag,
the user can decide whether or not to enable these interrupts.
Since there is no reason for a function meant to display config to
actually modify it, remove this line. In addition, raise the dev_flag
associated with this state on the device's initialization to show the
device supports link state change interrupts.
Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification")
Signed-off-by: Edwin Brossette <edwin.brossette@6wind.com>
Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 44056c9c4d..827253ff1c 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -1030,7 +1030,6 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
.tx_free_thresh = 32,
.tx_rs_thresh = 32,
};
- eth_dev->data->dev_conf.intr_conf.lsc = 1;
dev_info->rx_desc_lim.nb_min = BNXT_MIN_RING_DESC;
dev_info->rx_desc_lim.nb_max = BNXT_MAX_RX_RING_DESC;
@@ -5772,6 +5771,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused)
rte_eth_copy_pci_info(eth_dev, pci_dev);
eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
+ eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;
bp = eth_dev->data->dev_private;
--
2.39.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-02-23 09:36:30.763745888 +0000
+++ 0063-net-bnxt-fix-link-state-change-interrupt-config.patch 2023-02-23 09:36:28.346172150 +0000
@@ -1 +1 @@
-From 60653f4a25bd87a32bc148461f32566af997da8b Mon Sep 17 00:00:00 2001
+From de481ff9ddb85bddac2834cbdae53280a119aa3d Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 60653f4a25bd87a32bc148461f32566af997da8b ]
+
@@ -23 +24,0 @@
-Cc: stable@dpdk.org
@@ -29 +29,0 @@
- .mailmap | 1 +
@@ -31 +31 @@
- 2 files changed, 2 insertions(+), 1 deletion(-)
+ 1 file changed, 1 insertion(+), 1 deletion(-)
@@ -33,12 +32,0 @@
-diff --git a/.mailmap b/.mailmap
-index e111e05bc2..a9f4f28fba 100644
---- a/.mailmap
-+++ b/.mailmap
-@@ -339,6 +339,7 @@ Dzmitry Sautsa <dzmitryx.sautsa@intel.com>
- Ed Czeck <ed.czeck@atomicrules.com>
- Eduard Serra <eserra@vmware.com>
- Edward Makarov <makarov@kraftway.ru>
-+Edwin Brossette <edwin.brossette@6wind.com>
- Eelco Chaudron <echaudro@redhat.com>
- Elad Nachman <eladv6@gmail.com>
- Elad Persiko <eladpe@mellanox.com>
@@ -46 +34 @@
-index b3de490d36..753e86b4b2 100644
+index 44056c9c4d..827253ff1c 100644
@@ -49 +37 @@
-@@ -1017,7 +1017,6 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
+@@ -1030,7 +1030,6 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
@@ -57 +45 @@
-@@ -5859,6 +5858,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused)
+@@ -5772,6 +5771,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused)