From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DF7841D4F for ; Thu, 23 Feb 2023 10:40:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49545431B0; Thu, 23 Feb 2023 10:40:52 +0100 (CET) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id 43CC9427E9 for ; Thu, 23 Feb 2023 10:40:51 +0100 (CET) Received: by mail-wr1-f50.google.com with SMTP id c12so10142971wrw.1 for ; Thu, 23 Feb 2023 01:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s87BcJQ4uNPnr+NLWbqLZQ0VtSse4E1d3VPZy8upES8=; b=iDhPScq9oNPDb017nV73YB4AQqlU05E9s7YBylgrQNGUyTYIYVvrgSxKO6V1GNMw1N r+uwiLLYYLrAGEFXAiq7gXNG0Y0Fm7K8eXDC3CxbaIWn3XWHzFCtfFEQrfTvHelt9MWy QOTUkwRwSO+zORQC+lawM2CJN3ZWh+bX+9X5J9FWHq/F6YTdkElZQVKaGF7pcGj7KV8f GRkZ4YHIvrIgYngcos0GRIlWf0awUYTo2xNuX5Mv4gB5qMcMQE+IyQ26FmNaTVM+L7kv 36Rx5s7qfDvjuUInaM29TWeVc3viQImnt7Y9rko5ttQkhk0qrY3sZ8FIs9UP9iJgeQgQ S/ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s87BcJQ4uNPnr+NLWbqLZQ0VtSse4E1d3VPZy8upES8=; b=MH1KiMriyeXSXurYwqYcvOsMbA9wK+Q+VXhgPXSAcAGTOXclulrWbIVV1VwJbayILE T5dh5qcL6zhsZniKV+jJ2OKX5jFutsNu1JHmpS5zBkpWGONukRshKB0MKFj2PRZGR9jL d4tWj4/5Aec77lVJ2Vbl7TtQQ3EL4Xz3tDbsl5NrjqIInFWkRjmiQXP0Vg2AC4i9sM4Z D9ACQyhWWrDZ0PTOuqYZTjJDVV/4YuCXxhuN73E35FYh6gOO+1crKPVPZcLM/+zeIlHS U3AcRf+ytRQ0GcZdg6B2UcOiuekvjbnO7vhBlwR7OXxpBX/Z49vrpj/lR9HF1NqIIT2n h6ew== X-Gm-Message-State: AO0yUKWS34ZdFVsrMAwczRsMTRwnOd/F8Rog5I7I6WBEtqwUU7pJ4uAA sYsmFahAgzmuaL1l6v1sCdaR1Xw1WWwBpw== X-Google-Smtp-Source: AK7set8XZi/W03tOP3hggYNKinaR1Nkqxyw7lYWHzXLdYZjrtKkfrN8e7Evph7ROx2FDKgCe2omXPQ== X-Received: by 2002:a5d:4e09:0:b0:2c5:789d:804f with SMTP id p9-20020a5d4e09000000b002c5789d804fmr10097704wrt.55.1677145250910; Thu, 23 Feb 2023 01:40:50 -0800 (PST) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id w2-20020a5d6802000000b002c55efa9cbesm9777659wru.39.2023.02.23.01.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 01:40:50 -0800 (PST) From: luca.boccassi@gmail.com To: Bruce Richardson Cc: Olivier Matz , dpdk stable Subject: patch 'examples/cmdline: fix build with GCC 12' has been queued to stable release 20.11.8 Date: Thu, 23 Feb 2023 09:37:14 +0000 Message-Id: <20230223093715.3926893-70-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230223093715.3926893-1-luca.boccassi@gmail.com> References: <20230223093715.3926893-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/e6c09a4ba8216aa2ece322ac68ad921f42880089 Thanks. Luca Boccassi --- >From e6c09a4ba8216aa2ece322ac68ad921f42880089 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Wed, 18 Jan 2023 16:11:11 +0000 Subject: [PATCH] examples/cmdline: fix build with GCC 12 [ upstream commit 2ba8d0adb06f92ef73bc8e3953ca45b7d322c823 ] When building the example without libbsd and using the DPDK-provided strlcpy function, a compiler warning is emitted by GCC 12 about the copy of the parsed string into the resulting object. This is because the source from cmdline library is 128 bytes and the destination buffer is 64-bytes. commands.c: In function 'cmd_obj_add_parsed': rte_string_fns.h:61:24: warning: '%s' directive output may be truncated writing up to 127 bytes into a region of size 64 [-Wformat-truncation=] 61 | return (size_t)snprintf(dst, size, "%s", src); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /usr/include/stdio.h:894, from commands.c:7: /usr/include/x86_64-linux-gnu/bits/stdio2.h:71:10: note: '__builtin_snprintf' output between 1 and 128 bytes into a destination of size 64 Multiple options are possible to fix this, but the one taken in this patch is to ensure truncation never occurs by setting the destination buffer size to be the same as that used by the cmdline library. Fixes: af75078fece3 ("first public release") Signed-off-by: Bruce Richardson Acked-by: Olivier Matz --- examples/cmdline/parse_obj_list.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/cmdline/parse_obj_list.h b/examples/cmdline/parse_obj_list.h index 6516d3e2c2..1223ac1e8b 100644 --- a/examples/cmdline/parse_obj_list.h +++ b/examples/cmdline/parse_obj_list.h @@ -12,8 +12,9 @@ #include #include +#include -#define OBJ_NAME_LEN_MAX 64 +#define OBJ_NAME_LEN_MAX sizeof(cmdline_fixed_string_t) struct object { SLIST_ENTRY(object) next; -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 09:36:31.111446829 +0000 +++ 0070-examples-cmdline-fix-build-with-GCC-12.patch 2023-02-23 09:36:28.354172297 +0000 @@ -1 +1 @@ -From 2ba8d0adb06f92ef73bc8e3953ca45b7d322c823 Mon Sep 17 00:00:00 2001 +From e6c09a4ba8216aa2ece322ac68ad921f42880089 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2ba8d0adb06f92ef73bc8e3953ca45b7d322c823 ] + @@ -27 +28,0 @@ -Cc: stable@dpdk.org