From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11AF741D52 for ; Thu, 23 Feb 2023 16:07:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DC4843250; Thu, 23 Feb 2023 16:07:32 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id EADF643249 for ; Thu, 23 Feb 2023 16:07:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677164850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HxOmYD/h7EuzxOkt3t52mvMk1hG6tSsRmiY/pa0ja08=; b=Yinnrdz3FV04lx5oor8g6cmGp+8a/2Et+ImOXQtTEnkZQM1AZ4YxqrO5MMfdWmlAtcbAIu N8W9Ci4i2D99xNS9FD5lBTb1518kF6DsNrxnkNR2ECHjA2K83bubYLK4zBaae+QbX+0eT+ eQlNOHLerUaba+w8dOIQ51FvtcIfRI8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-553-bVfYc5R7Ph24kI7MSYdZrQ-1; Thu, 23 Feb 2023 10:07:29 -0500 X-MC-Unique: bVfYc5R7Ph24kI7MSYdZrQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EEE931C05AF9; Thu, 23 Feb 2023 15:07:18 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 378E42166B2B; Thu, 23 Feb 2023 15:07:18 +0000 (UTC) From: Kevin Traynor To: Andy Pei Cc: Maxime Coquelin , dpdk stable Subject: patch 'vdpa/ifc: fix reconnection in SW-assisted live migration' has been queued to stable release 21.11.4 Date: Thu, 23 Feb 2023 15:05:15 +0000 Message-Id: <20230223150631.723699-24-ktraynor@redhat.com> In-Reply-To: <20230223150631.723699-1-ktraynor@redhat.com> References: <20230223150631.723699-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/28/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/e928dfe88cd92ec50392d6023f07d96b89c42d54 Thanks. Kevin --- >From e928dfe88cd92ec50392d6023f07d96b89c42d54 Mon Sep 17 00:00:00 2001 From: Andy Pei Date: Mon, 12 Dec 2022 15:12:45 +0800 Subject: [PATCH] vdpa/ifc: fix reconnection in SW-assisted live migration [ upstream commit ef3be7e237dd707f46870b09b93f88f8ee5e75c6 ] In the case using argument "sw-live-migration=1" to enable SW assisted live migration, we take QEMU as front end for example, after source VM migrates to destination VM, we keep vdpa process for source VM there, we kill the QEMU process for source VM, and restart the QEMU process for source VM. In this case, vdpa driver will not perform DMA map and data path will not work properly. The above case works fine in the case "sw-live-migration=0". The root cause is that current code driver does not set running flag to 0. Driver treats device as ruuning and does not perform DMA map. Fixes: 4bb531e152d3 ("net/ifc: support SW assisted VDPA live migration") Signed-off-by: Andy Pei Reviewed-by: Maxime Coquelin --- drivers/vdpa/ifc/ifcvf_vdpa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c index d3c05bd3f9..c9b10527cc 100644 --- a/drivers/vdpa/ifc/ifcvf_vdpa.c +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c @@ -849,4 +849,6 @@ ifcvf_sw_fallback_switchover(struct ifcvf_internal *internal) vdpa_disable_vfio_intr(internal); + rte_atomic32_set(&internal->running, 0); + ret = rte_vhost_host_notifier_ctrl(vid, RTE_VHOST_QUEUE_ALL, false); if (ret && ret != -ENOTSUP) -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 14:46:24.422938327 +0000 +++ 0024-vdpa-ifc-fix-reconnection-in-SW-assisted-live-migrat.patch 2023-02-23 14:46:23.731235830 +0000 @@ -1 +1 @@ -From ef3be7e237dd707f46870b09b93f88f8ee5e75c6 Mon Sep 17 00:00:00 2001 +From e928dfe88cd92ec50392d6023f07d96b89c42d54 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ef3be7e237dd707f46870b09b93f88f8ee5e75c6 ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index 9468f66638..35520ea3ae 100644 +index d3c05bd3f9..c9b10527cc 100644 @@ -31 +32 @@ -@@ -1045,4 +1045,6 @@ ifcvf_sw_fallback_switchover(struct ifcvf_internal *internal) +@@ -849,4 +849,6 @@ ifcvf_sw_fallback_switchover(struct ifcvf_internal *internal)