From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A451841D52 for ; Thu, 23 Feb 2023 16:07:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B6914325F; Thu, 23 Feb 2023 16:07:39 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 31E8443255 for ; Thu, 23 Feb 2023 16:07:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677164857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tieMusm0F52mliWZSnznK1JvnlvkcUHZtc89qB+v2U0=; b=isL3i1FbN4WLpBOaY+R1dRg9A5tbP7528/ubK3tqPD/8e8rqdbeXcMxK3rlqkd6+PPVBtQ WaAsu4UhdRW+ea8BGWNHs7IFKXc2tvNjrrRLIjs0dqJ18NWuJJkWTfG0fznEVRNo5LiPUG /HaKmuTDjhFs4Y7pxlc1+Rgz48tHzGM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-22-AvQcqSPyPgOUAfZ3X8N5Dg-1; Thu, 23 Feb 2023 10:07:31 -0500 X-MC-Unique: AvQcqSPyPgOUAfZ3X8N5Dg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BE92485CCE1; Thu, 23 Feb 2023 15:07:21 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id ECA092166B29; Thu, 23 Feb 2023 15:07:20 +0000 (UTC) From: Kevin Traynor To: Hernan Vargas Cc: Maxime Coquelin , dpdk stable Subject: patch 'baseband/acc: fix memory leak on acc100 close' has been queued to stable release 21.11.4 Date: Thu, 23 Feb 2023 15:05:17 +0000 Message-Id: <20230223150631.723699-26-ktraynor@redhat.com> In-Reply-To: <20230223150631.723699-1-ktraynor@redhat.com> References: <20230223150631.723699-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/28/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/3664b67985f2bdab3ec33c0b5f38b6f023d8c987 Thanks. Kevin --- >From 3664b67985f2bdab3ec33c0b5f38b6f023d8c987 Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Thu, 12 Jan 2023 11:36:03 -0800 Subject: [PATCH] baseband/acc: fix memory leak on acc100 close [ upstream commit 1bc7f26ebd45da2ab2740a00c991100dc8f0037d ] Explicitly call rte_free for harq_layout pointer in dev_close function to prevent memory leak. Fixes: ba2262fe16c ("baseband/acc100: fix close cleanup") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc100/rte_acc100_pmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c index eba6eb0df4..713e58fb54 100644 --- a/drivers/baseband/acc100/rte_acc100_pmd.c +++ b/drivers/baseband/acc100/rte_acc100_pmd.c @@ -780,4 +780,5 @@ acc100_dev_close(struct rte_bbdev *dev) rte_free(d->info_ring); rte_free(d->sw_rings_base); + rte_free(d->harq_layout); d->sw_rings_base = NULL; d->tail_ptrs = NULL; -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 14:46:24.468853903 +0000 +++ 0026-baseband-acc-fix-memory-leak-on-acc100-close.patch 2023-02-23 14:46:23.736235847 +0000 @@ -1 +1 @@ -From 1bc7f26ebd45da2ab2740a00c991100dc8f0037d Mon Sep 17 00:00:00 2001 +From 3664b67985f2bdab3ec33c0b5f38b6f023d8c987 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1bc7f26ebd45da2ab2740a00c991100dc8f0037d ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -15 +16 @@ - drivers/baseband/acc/rte_acc100_pmd.c | 1 + + drivers/baseband/acc100/rte_acc100_pmd.c | 1 + @@ -18,5 +19,5 @@ -diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c -index b3164529dd..146a22bd64 100644 ---- a/drivers/baseband/acc/rte_acc100_pmd.c -+++ b/drivers/baseband/acc/rte_acc100_pmd.c -@@ -621,4 +621,5 @@ acc100_dev_close(struct rte_bbdev *dev) +diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c +index eba6eb0df4..713e58fb54 100644 +--- a/drivers/baseband/acc100/rte_acc100_pmd.c ++++ b/drivers/baseband/acc100/rte_acc100_pmd.c +@@ -780,4 +780,5 @@ acc100_dev_close(struct rte_bbdev *dev)