From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6EEB41D52 for ; Thu, 23 Feb 2023 16:07:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A37A04326C; Thu, 23 Feb 2023 16:07:46 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7323143260 for ; Thu, 23 Feb 2023 16:07:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677164863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UrRcc+P38IE+e16NpuUmJXGQIxRPrQ+Rvta63qd3DNs=; b=D+J2ZxxW+fSSqzjzB7KxLZnmMOGOlVk+IrHp/13Wb7s13b/cGNXFR+a8PZ7zG/LUP+uaVD MSWlRo4bOTkt+5IDBLe2WCgjUDywscP1G6SlARW3kB0A6yhh0L8R6QQQRvJ1CK/CBr+v5P eb5LTYeOTydA0AR1A8gHYcvfccqDiR0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-503-wTkguCexNYq2MH7HGnpy6Q-1; Thu, 23 Feb 2023 10:07:41 -0500 X-MC-Unique: wTkguCexNYq2MH7HGnpy6Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C615718E0048; Thu, 23 Feb 2023 15:07:30 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 143172166B29; Thu, 23 Feb 2023 15:07:29 +0000 (UTC) From: Kevin Traynor To: Kalesh AP Cc: Ajit Khaparde , dpdk stable Subject: patch 'net/bnxt: fix Tx queue stats after queue stop and start' has been queued to stable release 21.11.4 Date: Thu, 23 Feb 2023 15:05:25 +0000 Message-Id: <20230223150631.723699-34-ktraynor@redhat.com> In-Reply-To: <20230223150631.723699-1-ktraynor@redhat.com> References: <20230223150631.723699-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/28/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/aa0ecc4f913ab016eb48b508d01d2f4355027d2d Thanks. Kevin --- >From aa0ecc4f913ab016eb48b508d01d2f4355027d2d Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Wed, 1 Feb 2023 09:50:12 +0530 Subject: [PATCH] net/bnxt: fix Tx queue stats after queue stop and start [ upstream commit 9bd8998fe09736a048e367e1ef7543dd8b5dfd2c ] The Tx queue stats are being reported incorrectly due to a workaround for ring counters sometimes being reported as zero. When a queue is stopped and started, the ring counter is reset to zero. The workaround interprets the zero as incorrect, and sets the reported ring count as the previously read value (from before the queue being restared). This shows up as negative counters in testpmd's "show fwd stats" command. The fix clears the prev counter for the queue when the queue is started. Fixes: 219842b9990c ("net/bnxt: workaround spurious zero stats in Thor") Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_txr.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c index 3b8f2382f9..ec63b97fe2 100644 --- a/drivers/net/bnxt/bnxt_txr.c +++ b/drivers/net/bnxt/bnxt_txr.c @@ -552,4 +552,10 @@ int bnxt_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id) return rc; + /* reset the previous stats for the tx_queue since the counters + * will be cleared when the queue is started. + */ + memset(&bp->prev_tx_ring_stats[tx_queue_id], 0, + sizeof(struct bnxt_ring_stats)); + bnxt_free_hwrm_tx_ring(bp, tx_queue_id); rc = bnxt_alloc_hwrm_tx_ring(bp, tx_queue_id); -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 14:46:24.660667100 +0000 +++ 0034-net-bnxt-fix-Tx-queue-stats-after-queue-stop-and-sta.patch 2023-02-23 14:46:23.755235914 +0000 @@ -1 +1 @@ -From 9bd8998fe09736a048e367e1ef7543dd8b5dfd2c Mon Sep 17 00:00:00 2001 +From aa0ecc4f913ab016eb48b508d01d2f4355027d2d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9bd8998fe09736a048e367e1ef7543dd8b5dfd2c ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 67e016775c..21c2217092 100644 +index 3b8f2382f9..ec63b97fe2 100644 @@ -27 +28 @@ -@@ -561,4 +561,10 @@ int bnxt_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id) +@@ -552,4 +552,10 @@ int bnxt_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)