From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2536C41D52 for ; Thu, 23 Feb 2023 16:07:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2145A4326C; Thu, 23 Feb 2023 16:07:51 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3BC7E4326A for ; Thu, 23 Feb 2023 16:07:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677164867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/zXCwUI8VmVqb4D4P49kzdk3yuO4hyxRhfcMYkxx2p4=; b=RWSJrzpu/k9yDAdKrJZ4e0mzkuLf3dV/bM8AZcq9d5qdA2bnx2C89cWnfXxlK4WYzJxzx9 jYEO0x4B/QQhN7icBuw3daFdF5YL9eI3JkzIn3yL62181P1JKHtRUXVZCATRSpLAXqtEZM WsPoCPfcDOG/frt1GnMcPiHeze06vmQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-437-QScazV-lM-yDvTiOfqO8Mw-1; Thu, 23 Feb 2023 10:07:42 -0500 X-MC-Unique: QScazV-lM-yDvTiOfqO8Mw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3724E18E0055; Thu, 23 Feb 2023 15:07:32 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1286D2166B29; Thu, 23 Feb 2023 15:07:30 +0000 (UTC) From: Kevin Traynor To: Mike Baucom Cc: Somnath Kotur , Kishore Padmanabha , Randy Schacher , Ajit Khaparde , dpdk stable Subject: patch 'net/bnxt: fix Rx queue stats after queue stop and start' has been queued to stable release 21.11.4 Date: Thu, 23 Feb 2023 15:05:26 +0000 Message-Id: <20230223150631.723699-35-ktraynor@redhat.com> In-Reply-To: <20230223150631.723699-1-ktraynor@redhat.com> References: <20230223150631.723699-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/28/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/20189c4886d0a3f08b1627289df6cef81ceedb5a Thanks. Kevin --- >From 20189c4886d0a3f08b1627289df6cef81ceedb5a Mon Sep 17 00:00:00 2001 From: Mike Baucom Date: Wed, 1 Feb 2023 09:50:13 +0530 Subject: [PATCH] net/bnxt: fix Rx queue stats after queue stop and start [ upstream commit 0180d3040e4a7734dc9987ff6c49ec1daedcdf8c ] The Rx queue stats are being reported incorrectly due to a workaround for ring counters sometimes being reported as zero. When a queue is stopped and started, the ring counter is reset to zero. The workaround interprets the zero as incorrect, and sets the reported ring count as the previously read value (from before the queue being restared). This shows up as negative counters in testpmd's "show fwd stats" command. The fix clears the prev counter for the queue when the queue is started. Fixes: 219842b9990c ("net/bnxt: workaround spurious zero stats in Thor") Signed-off-by: Mike Baucom Reviewed-by: Somnath Kotur Reviewed-by: Kishore Padmanabha Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 4f2e0e7376..c38be2f348 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -473,4 +473,10 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) } + /* reset the previous stats for the rx_queue since the counters + * will be cleared when the queue is started. + */ + memset(&bp->prev_rx_ring_stats[rx_queue_id], 0, + sizeof(struct bnxt_ring_stats)); + /* Set the queue state to started here. * We check the status of the queue while posting buffer. -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 14:46:24.682344415 +0000 +++ 0035-net-bnxt-fix-Rx-queue-stats-after-queue-stop-and-sta.patch 2023-02-23 14:46:23.755235914 +0000 @@ -1 +1 @@ -From 0180d3040e4a7734dc9987ff6c49ec1daedcdf8c Mon Sep 17 00:00:00 2001 +From 20189c4886d0a3f08b1627289df6cef81ceedb5a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0180d3040e4a7734dc9987ff6c49ec1daedcdf8c ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index fabbbd4560..99758dd304 100644 +index 4f2e0e7376..c38be2f348 100644 @@ -30 +31 @@ -@@ -472,4 +472,10 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) +@@ -473,4 +473,10 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)