From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B30DD41D52 for ; Thu, 23 Feb 2023 16:07:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E491843283; Thu, 23 Feb 2023 16:07:54 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4BD4643277 for ; Thu, 23 Feb 2023 16:07:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677164873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3rHsPKoB3jj7g92b4p+CIvn1qaXOLDnA9Np0XCQDr2E=; b=f5+fVt5bdMcpuwsosK/R9Fnc+xmwkVqsObZvXKmUU/Kf4sFBf9AlK7+Um2q/2UeAvudJHn CQgf5pfuRQxCy/neYokCXQaOEsvIu5DsCbK3sU2pspag753Gi/Sg6R5oMRn9CTrlQz4gkY S3cExemGbMU/Vrml6UgF3oPFZlJgh+0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-186-hmKJhfucPbCfxlGSxm-PxA-1; Thu, 23 Feb 2023 10:07:46 -0500 X-MC-Unique: hmKJhfucPbCfxlGSxm-PxA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9389438149B5; Thu, 23 Feb 2023 15:07:39 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id E420F2166B29; Thu, 23 Feb 2023 15:07:38 +0000 (UTC) From: Kevin Traynor To: Chengwen Feng Cc: Bruce Richardson , dpdk stable Subject: patch 'telemetry: fix repeat display when callback don't init dict' has been queued to stable release 21.11.4 Date: Thu, 23 Feb 2023 15:05:33 +0000 Message-Id: <20230223150631.723699-42-ktraynor@redhat.com> In-Reply-To: <20230223150631.723699-1-ktraynor@redhat.com> References: <20230223150631.723699-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/28/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/bb9295b2f3e8a81220f609014b03eb91d2d9e132 Thanks. Kevin --- >From bb9295b2f3e8a81220f609014b03eb91d2d9e132 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 9 Feb 2023 01:25:33 +0000 Subject: [PATCH] telemetry: fix repeat display when callback don't init dict [ upstream commit ff50c4f9136781bae9089c596e0a12d113e1d474 ] When a telemetry callback doesn't initialize the telemetry data structure and returns a non-negative number, the telemetry will repeat to display the last result. This patch zero the data structure to avoid the problem. Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") Signed-off-by: Chengwen Feng Reviewed-by: Bruce Richardson --- lib/telemetry/telemetry.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c index e5ccfe47f7..9ff0def182 100644 --- a/lib/telemetry/telemetry.c +++ b/lib/telemetry/telemetry.c @@ -329,5 +329,5 @@ static void perform_command(telemetry_cb fn, const char *cmd, const char *param, int s) { - struct rte_tel_data data; + struct rte_tel_data data = {0}; int ret = fn(cmd, param, &data); -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 14:46:24.837857880 +0000 +++ 0042-telemetry-fix-repeat-display-when-callback-don-t-ini.patch 2023-02-23 14:46:23.762235938 +0000 @@ -1 +1 @@ -From ff50c4f9136781bae9089c596e0a12d113e1d474 Mon Sep 17 00:00:00 2001 +From bb9295b2f3e8a81220f609014b03eb91d2d9e132 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ff50c4f9136781bae9089c596e0a12d113e1d474 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 655191bcf1..7bceadcee7 100644 +index e5ccfe47f7..9ff0def182 100644 @@ -24 +25 @@ -@@ -334,5 +334,5 @@ static void +@@ -329,5 +329,5 @@ static void