From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24CEC41D52 for ; Thu, 23 Feb 2023 16:07:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 204144327B; Thu, 23 Feb 2023 16:07:58 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7E36743277 for ; Thu, 23 Feb 2023 16:07:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677164876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OoD/khNd0Kn4Il5dlQhx9kgOw6LxWCSDNS8FD7yLGY0=; b=LfTZE1nsvvznCJkf8ELwp3PBQa2/1OHHbisyTIIwbtgtl/PBsx9yu/cTGJuNk0wqTBXks5 5wfk2unG9bJQ6bMQssCsAbxL7EeZ8MAjw+SxWxdNNitDIaQSuGG0TXpJy5ag/gnjspfYTz eAfrmUI+xewxJNQbSaSVOC/R642QhDg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-314-O-zvzXN8OISvNIikR-m_zg-1; Thu, 23 Feb 2023 10:07:54 -0500 X-MC-Unique: O-zvzXN8OISvNIikR-m_zg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2C89D18E0059; Thu, 23 Feb 2023 15:07:44 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 092372166B29; Thu, 23 Feb 2023 15:07:42 +0000 (UTC) From: Kevin Traynor To: Maxime Coquelin Cc: Chenbo Xia , Kevin Traynor , dpdk stable Subject: patch 'vhost: decrease log level for unimplemented requests' has been queued to stable release 21.11.4 Date: Thu, 23 Feb 2023 15:05:37 +0000 Message-Id: <20230223150631.723699-46-ktraynor@redhat.com> In-Reply-To: <20230223150631.723699-1-ktraynor@redhat.com> References: <20230223150631.723699-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/28/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/f05708ea45fc7511b70590df16155574445955a5 Thanks. Kevin --- >From f05708ea45fc7511b70590df16155574445955a5 Mon Sep 17 00:00:00 2001 From: Maxime Coquelin Date: Mon, 6 Feb 2023 16:07:33 +0100 Subject: [PATCH] vhost: decrease log level for unimplemented requests [ upstream commit 43ccd55fdd6ab34b55060045594cc21aefa74383 ] This patch changes VHOST_USER_SET_VRING_ERR and VHOST_USER_SET_LOG_FD "not implemented" log levels from INFO to DEBUG, as implementing these requests is not mandatory. Having them being displayed at INFO level may induce some confusion to the end-user. Fixes: fd29c33b651a ("vhost: handle unsupported message types in functions") Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Acked-by: Kevin Traynor --- lib/vhost/vhost_user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c index 2b45e35d4a..76c3c27fc1 100644 --- a/lib/vhost/vhost_user.c +++ b/lib/vhost/vhost_user.c @@ -1848,5 +1848,5 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev __rte_unused, if (!(msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK)) close(msg->fds[0]); - VHOST_LOG_CONFIG(INFO, "not implemented\n"); + VHOST_LOG_CONFIG(DEBUG, "not implemented\n"); return RTE_VHOST_MSG_RESULT_OK; @@ -2379,5 +2379,5 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused, close(msg->fds[0]); - VHOST_LOG_CONFIG(INFO, "not implemented.\n"); + VHOST_LOG_CONFIG(DEBUG, "not implemented.\n"); return RTE_VHOST_MSG_RESULT_OK; -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 14:46:24.927731072 +0000 +++ 0046-vhost-decrease-log-level-for-unimplemented-requests.patch 2023-02-23 14:46:23.769235962 +0000 @@ -1 +1 @@ -From 43ccd55fdd6ab34b55060045594cc21aefa74383 Mon Sep 17 00:00:00 2001 +From f05708ea45fc7511b70590df16155574445955a5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 43ccd55fdd6ab34b55060045594cc21aefa74383 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 8c1d60b76b..b4236820a2 100644 +index 2b45e35d4a..76c3c27fc1 100644 @@ -26,5 +27,5 @@ -@@ -1819,5 +1819,5 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev, - if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK)) - close(ctx->fds[0]); -- VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n"); -+ VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n"); +@@ -1848,5 +1848,5 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev __rte_unused, + if (!(msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK)) + close(msg->fds[0]); +- VHOST_LOG_CONFIG(INFO, "not implemented\n"); ++ VHOST_LOG_CONFIG(DEBUG, "not implemented\n"); @@ -33 +34 @@ -@@ -2341,5 +2341,5 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev, +@@ -2379,5 +2379,5 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused, @@ -35,3 +36,3 @@ - close(ctx->fds[0]); -- VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented.\n"); -+ VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented.\n"); + close(msg->fds[0]); +- VHOST_LOG_CONFIG(INFO, "not implemented.\n"); ++ VHOST_LOG_CONFIG(DEBUG, "not implemented.\n");