From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF53841D52 for ; Thu, 23 Feb 2023 16:08:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DBDE243282; Thu, 23 Feb 2023 16:08:04 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E4A604327B for ; Thu, 23 Feb 2023 16:08:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677164881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HE2NVm/dp4FxDQ68l5LRf63AZPRtFsMp/9qBzOZp3ac=; b=cVT7p4HSUGAkL8WnWnkylfYrCgnO9Vi1bRdhGtlv20/od/c7M/RrX7P5sRXdrdtjImeFYl uNi4qKRgon/Dfo8V9+wHKCiVgfM070TwjVY20mYXxbHV5ExidXZdpUmV31OOnPqfFYzRaB WdMPIH5Es2GQJ/USoJVgI5hvuWNTcQQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-526-cGlH-31hPPujz2vYJNinZg-1; Thu, 23 Feb 2023 10:08:00 -0500 X-MC-Unique: cGlH-31hPPujz2vYJNinZg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6B7EF100F92D; Thu, 23 Feb 2023 15:07:55 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id D7B972166B29; Thu, 23 Feb 2023 15:07:54 +0000 (UTC) From: Kevin Traynor To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/txgbe: fix interrupt loss' has been queued to stable release 21.11.4 Date: Thu, 23 Feb 2023 15:05:46 +0000 Message-Id: <20230223150631.723699-55-ktraynor@redhat.com> In-Reply-To: <20230223150631.723699-1-ktraynor@redhat.com> References: <20230223150631.723699-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/28/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/489a1c2580f82b2e11878a659d3972c691a4b38f Thanks. Kevin --- >From 489a1c2580f82b2e11878a659d3972c691a4b38f Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Thu, 2 Feb 2023 17:21:31 +0800 Subject: [PATCH] net/txgbe: fix interrupt loss [ upstream commit a4315c1434b6bf78a9e04bf5fa34d02e9b3afd35 ] Disable interrupt in the interrupt handling process will sometimes cause interrupts to be lost. Fixes: 2fc745e6b606 ("net/txgbe: add interrupt operation") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index c229736d85..af2bf00ebd 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -2940,7 +2940,4 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev, wr32(hw, TXGBE_PX_INTA, 1); - /* clear all cause mask */ - txgbe_disable_intr(hw); - /* read-on-clear nic registers here */ eicr = ((u32 *)hw->isb_mem)[TXGBE_ISB_MISC]; @@ -2965,4 +2962,6 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev, intr->flags |= TXGBE_FLAG_PHY_INTERRUPT; + ((u32 *)hw->isb_mem)[TXGBE_ISB_MISC] = 0; + return 0; } -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 14:46:25.138666790 +0000 +++ 0055-net-txgbe-fix-interrupt-loss.patch 2023-02-23 14:46:23.790236036 +0000 @@ -1 +1 @@ -From a4315c1434b6bf78a9e04bf5fa34d02e9b3afd35 Mon Sep 17 00:00:00 2001 +From 489a1c2580f82b2e11878a659d3972c691a4b38f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a4315c1434b6bf78a9e04bf5fa34d02e9b3afd35 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index ce7cf2506d..6e939b8ce3 100644 +index c229736d85..af2bf00ebd 100644 @@ -21 +22 @@ -@@ -2973,7 +2973,4 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev, +@@ -2940,7 +2940,4 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev, @@ -29,2 +30,2 @@ -@@ -3001,4 +2998,6 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev, - intr->flags |= TXGBE_FLAG_OVERHEAT; +@@ -2965,4 +2962,6 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev, + intr->flags |= TXGBE_FLAG_PHY_INTERRUPT;