From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D8E341D52 for ; Thu, 23 Feb 2023 16:08:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 086ED4329B; Thu, 23 Feb 2023 16:08:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B3A0043297 for ; Thu, 23 Feb 2023 16:08:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677164892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ytaGvZ/iiBm2cqeE5mWf6QYTW2dQoYwms/OECop4axI=; b=iFhoKEdKKn90n6UyhRu8me8Iia9uxr1wZ50/mZIhEYd525aQYRBZRl9V0U1DoTijHljFXR Bh+LYtOBf2NKHos0yxa8zIhDF31Ua60WEuV+YOtNNqqss9Aybq1/8Nc1V8sfEHG2fcV4hE BljiwYYach59UxK3DyYPTBnGjZ3F4CQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-275-TO9CulptMk6bdZTHENFXJg-1; Thu, 23 Feb 2023 10:08:10 -0500 X-MC-Unique: TO9CulptMk6bdZTHENFXJg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 35B6A811E9C; Thu, 23 Feb 2023 15:08:10 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 76AC42166B29; Thu, 23 Feb 2023 15:08:09 +0000 (UTC) From: Kevin Traynor To: Huisong Li Cc: Dongdong Liu , dpdk stable Subject: patch 'net/hns3: remove debug condition for Tx prepare' has been queued to stable release 21.11.4 Date: Thu, 23 Feb 2023 15:05:59 +0000 Message-Id: <20230223150631.723699-68-ktraynor@redhat.com> In-Reply-To: <20230223150631.723699-1-ktraynor@redhat.com> References: <20230223150631.723699-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/28/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/483243b873c38cb4a348ceaebad4e322e04761ec Thanks. Kevin --- >From 483243b873c38cb4a348ceaebad4e322e04761ec Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Sat, 11 Feb 2023 17:18:27 +0800 Subject: [PATCH] net/hns3: remove debug condition for Tx prepare [ upstream commit a8d240786e1af129fdf789391d574bf4a7fe60e6 ] The Tx prepare in driver is always needed if RTE_LIBRTE_ETHDEV_DEBUG is defined. But it doesn't matter with this macro. Let's remove it. Fixes: d7ec2c076579 ("net/hns3: select Tx prepare based on Tx offload") Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rxtx.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index b51d64e4de..5c7de80e7b 100644 --- a/drivers/net/hns3/hns3_rxtx.c +++ b/drivers/net/hns3/hns3_rxtx.c @@ -4315,9 +4315,4 @@ static bool hns3_get_tx_prep_needed(struct rte_eth_dev *dev) { -#ifdef RTE_LIBRTE_ETHDEV_DEBUG - RTE_SET_USED(dev); - /* always perform tx_prepare when debug */ - return true; -#else #define HNS3_DEV_TX_CSKUM_TSO_OFFLOAD_MASK (\ RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | \ @@ -4337,5 +4332,4 @@ hns3_get_tx_prep_needed(struct rte_eth_dev *dev) return false; -#endif } -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 14:46:25.448932404 +0000 +++ 0068-net-hns3-remove-debug-condition-for-Tx-prepare.patch 2023-02-23 14:46:23.825236158 +0000 @@ -1 +1 @@ -From a8d240786e1af129fdf789391d574bf4a7fe60e6 Mon Sep 17 00:00:00 2001 +From 483243b873c38cb4a348ceaebad4e322e04761ec Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a8d240786e1af129fdf789391d574bf4a7fe60e6 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 2524f4c3c2..921d72d69d 100644 +index b51d64e4de..5c7de80e7b 100644 @@ -22 +23 @@ -@@ -4312,9 +4312,4 @@ static bool +@@ -4315,9 +4315,4 @@ static bool @@ -32 +33 @@ -@@ -4334,5 +4329,4 @@ hns3_get_tx_prep_needed(struct rte_eth_dev *dev) +@@ -4337,5 +4332,4 @@ hns3_get_tx_prep_needed(struct rte_eth_dev *dev)