From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D05041D52 for ; Thu, 23 Feb 2023 16:08:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28C294328D; Thu, 23 Feb 2023 16:08:17 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0727A43282 for ; Thu, 23 Feb 2023 16:08:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677164895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XrqaxEN3DWRnofC4TyTZxZV3wwI0hqwVQBw83PRkN6o=; b=fp4GqrpC2O6mZRsqh2ol4ydQh1WWg11A0+L5hDfxTpxVMxSZ+6DGuKhRs/3touygcJ7cat 9Y9izLOAH6/+9wxFcA20zvMVNo/2G/uw+zSmGl+icRT1jPQR+xY5hhSy41dvPmeoxOdDla DfHpb/nFySlws1zmxkX/0HzywHMR3B0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-382-9R0b3csCP0OLWJHd4ctuIA-1; Thu, 23 Feb 2023 10:08:14 -0500 X-MC-Unique: 9R0b3csCP0OLWJHd4ctuIA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F3E3E817077; Thu, 23 Feb 2023 15:08:13 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 544F52166B29; Thu, 23 Feb 2023 15:08:13 +0000 (UTC) From: Kevin Traynor To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/txgbe: fix Rx buffer size in config register' has been queued to stable release 21.11.4 Date: Thu, 23 Feb 2023 15:06:02 +0000 Message-Id: <20230223150631.723699-71-ktraynor@redhat.com> In-Reply-To: <20230223150631.723699-1-ktraynor@redhat.com> References: <20230223150631.723699-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/28/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/190d16fb4c5307cae6b08c6aed78219956ff07b9 Thanks. Kevin --- >From 190d16fb4c5307cae6b08c6aed78219956ff07b9 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Wed, 15 Feb 2023 10:00:56 +0800 Subject: [PATCH] net/txgbe: fix Rx buffer size in config register [ upstream commit 8a3ef4b89e6dd0247355fdf3a77ff7ec1db28d8d ] When round up buffer size to 1K, to configure the register, hardware will receive packets exceeding the buffer size in LRO mode. It will cause a segment fault in the receive function. Fixes: be797cbf4582 ("net/txgbe: add Rx and Tx init") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c index 4c63a82fd6..28e5a78cc9 100644 --- a/drivers/net/txgbe/txgbe_rxtx.c +++ b/drivers/net/txgbe/txgbe_rxtx.c @@ -4393,5 +4393,5 @@ txgbe_dev_rx_init(struct rte_eth_dev *dev) buf_size = (uint16_t)(rte_pktmbuf_data_room_size(rxq->mb_pool) - RTE_PKTMBUF_HEADROOM); - buf_size = ROUND_UP(buf_size, 0x1 << 10); + buf_size = ROUND_DOWN(buf_size, 0x1 << 10); srrctl |= TXGBE_RXCFG_PKTLEN(buf_size); -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 14:46:25.520600985 +0000 +++ 0071-net-txgbe-fix-Rx-buffer-size-in-config-register.patch 2023-02-23 14:46:23.836236196 +0000 @@ -1 +1 @@ -From 8a3ef4b89e6dd0247355fdf3a77ff7ec1db28d8d Mon Sep 17 00:00:00 2001 +From 190d16fb4c5307cae6b08c6aed78219956ff07b9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8a3ef4b89e6dd0247355fdf3a77ff7ec1db28d8d ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 021f281fbb..427f8b82ac 100644 +index 4c63a82fd6..28e5a78cc9 100644