From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91F4841D52 for ; Thu, 23 Feb 2023 16:08:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E27E432AE; Thu, 23 Feb 2023 16:08:29 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DE8FC432AA for ; Thu, 23 Feb 2023 16:08:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677164906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uQg//WsAdRSnIA94g7TudIoHP/Vv5f2WbUkGF6tb7+E=; b=CrYeJJKjN0/rdHmLQO9dUDoKhZHS9Hxy+CMaexRQCJnS36Sq5XZH22ULhXBiWBqyYbQZLl nosP8HUzjRBvoLOSpsOKbeiZxlo+q1amME7rGo/wJ5hSKaCICUSYXXvrUSDlWrGsQRn5tv ES5i21Dky7ozFxK1TuvdzZISNTJFkhM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-342-Xik0j_cuNzyBu8WY1mFoYA-1; Thu, 23 Feb 2023 10:08:25 -0500 X-MC-Unique: Xik0j_cuNzyBu8WY1mFoYA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DC79987A9E9; Thu, 23 Feb 2023 15:08:24 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id E3BB92166B2E; Thu, 23 Feb 2023 15:08:23 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Qi Zhang , dpdk stable Subject: patch 'net/iavf: protect insertion in flow list' has been queued to stable release 21.11.4 Date: Thu, 23 Feb 2023 15:06:12 +0000 Message-Id: <20230223150631.723699-81-ktraynor@redhat.com> In-Reply-To: <20230223150631.723699-1-ktraynor@redhat.com> References: <20230223150631.723699-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/28/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a6aba6b291f31457ca378e0c7ca251b01ca9da9a Thanks. Kevin --- >From a6aba6b291f31457ca378e0c7ca251b01ca9da9a Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 5 Jan 2023 14:57:43 +0100 Subject: [PATCH] net/iavf: protect insertion in flow list [ upstream commit d79c3b264e31465695bc4c6279381522060a22f6 ] Add missing lock acquire. Fixes: ff2d0c345c3b ("net/iavf: support generic flow API") Signed-off-by: David Marchand Acked-by: Qi Zhang --- drivers/net/iavf/iavf_generic_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_generic_flow.c b/drivers/net/iavf/iavf_generic_flow.c index 2befa125ac..01e7b8724d 100644 --- a/drivers/net/iavf/iavf_generic_flow.c +++ b/drivers/net/iavf/iavf_generic_flow.c @@ -2221,9 +2221,10 @@ iavf_flow_create(struct rte_eth_dev *dev, flow->engine = engine; + rte_spinlock_lock(&vf->flow_ops_lock); TAILQ_INSERT_TAIL(&vf->flow_list, flow, node); + rte_spinlock_unlock(&vf->flow_ops_lock); PMD_DRV_LOG(INFO, "Succeeded to create (%d) flow", engine->type); free_flow: - rte_spinlock_unlock(&vf->flow_ops_lock); return flow; } -- 2.39.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-23 14:46:25.763037314 +0000 +++ 0081-net-iavf-protect-insertion-in-flow-list.patch 2023-02-23 14:46:23.864236293 +0000 @@ -1 +1 @@ -From d79c3b264e31465695bc4c6279381522060a22f6 Mon Sep 17 00:00:00 2001 +From a6aba6b291f31457ca378e0c7ca251b01ca9da9a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d79c3b264e31465695bc4c6279381522060a22f6 ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index f33c764764..6f6e95fc45 100644 +index 2befa125ac..01e7b8724d 100644 @@ -21 +22 @@ -@@ -2279,9 +2279,10 @@ iavf_flow_create(struct rte_eth_dev *dev, +@@ -2221,9 +2221,10 @@ iavf_flow_create(struct rte_eth_dev *dev,