patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
	dpdk stable <stable@dpdk.org>
Subject: patch 'examples/qos_sched: fix Tx port config when link down' has been queued to stable release 21.11.4
Date: Thu, 23 Feb 2023 15:06:30 +0000	[thread overview]
Message-ID: <20230223150631.723699-99-ktraynor@redhat.com> (raw)
In-Reply-To: <20230223150631.723699-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/28/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/74f84c75584a043cbc7f983579083f01f8b7d225

Thanks.

Kevin

---
From 74f84c75584a043cbc7f983579083f01f8b7d225 Mon Sep 17 00:00:00 2001
From: Bruce Richardson <bruce.richardson@intel.com>
Date: Fri, 3 Feb 2023 10:05:30 +0000
Subject: [PATCH] examples/qos_sched: fix Tx port config when link down

[ upstream commit 665b49c51639a10c553433bc2bcd85c7331c631e ]

The Tx port config will fail if the port is not up,
so wait 10 seconds on startup for it to start.

Fixes: de3cfa2c9823 ("sched: initial import")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 examples/qos_sched/init.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c
index e912ca4f6c..3a7e7d80a1 100644
--- a/examples/qos_sched/init.c
+++ b/examples/qos_sched/init.c
@@ -394,4 +394,6 @@ int app_init(void)
 		uint32_t socket = rte_lcore_to_socket_id(qos_conf[i].rx_core);
 		struct rte_ring *ring;
+		struct rte_eth_link link = {0};
+		int retry_count = 100, retry_delay = 100; /* try every 100ms for 10 sec */
 
 		snprintf(ring_name, MAX_NAME_LEN, "ring-%u-%u", i, qos_conf[i].rx_core);
@@ -424,4 +426,12 @@ int app_init(void)
 		app_init_port(qos_conf[i].tx_port, qos_conf[i].mbuf_pool);
 
+		rte_eth_link_get(qos_conf[i].tx_port, &link);
+		if (link.link_status == 0)
+			printf("Waiting for link on port %u\n", qos_conf[i].tx_port);
+		while (link.link_status == 0 && retry_count--) {
+			rte_delay_ms(retry_delay);
+			rte_eth_link_get(qos_conf[i].tx_port, &link);
+		}
+
 		qos_conf[i].sched_port = app_init_sched_port(qos_conf[i].tx_port, socket);
 	}
-- 
2.39.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-02-23 14:46:26.174589816 +0000
+++ 0099-examples-qos_sched-fix-Tx-port-config-when-link-down.patch	2023-02-23 14:46:23.889236381 +0000
@@ -1 +1 @@
-From 665b49c51639a10c553433bc2bcd85c7331c631e Mon Sep 17 00:00:00 2001
+From 74f84c75584a043cbc7f983579083f01f8b7d225 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 665b49c51639a10c553433bc2bcd85c7331c631e ]
+
@@ -10 +11,0 @@
-Cc: stable@dpdk.org
@@ -19 +20 @@
-index d28350e14a..7a27c03b64 100644
+index e912ca4f6c..3a7e7d80a1 100644
@@ -22 +23 @@
-@@ -329,4 +329,6 @@ int app_init(void)
+@@ -394,4 +394,6 @@ int app_init(void)
@@ -29 +30 @@
-@@ -359,4 +361,12 @@ int app_init(void)
+@@ -424,4 +426,12 @@ int app_init(void)


      parent reply	other threads:[~2023-02-23 15:09 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23 15:04 patch 'kni: fix build on RHEL 9.1' " Kevin Traynor
2023-02-23 15:04 ` patch 'hash: fix GFNI implementation build with GCC 12' " Kevin Traynor
2023-02-23 15:04 ` patch 'doc: fix dependency setup in l2fwd-cat example guide' " Kevin Traynor
2023-02-23 15:04 ` patch 'devtools: fix escaped space in grep pattern' " Kevin Traynor
2023-02-23 15:04 ` patch 'app/crypto-perf: fix number of segments' " Kevin Traynor
2023-02-23 15:04 ` patch 'app/crypto-perf: fix SPI zero' " Kevin Traynor
2023-02-23 15:04 ` patch 'app/crypto-perf: fix IPsec direction' " Kevin Traynor
2023-02-23 15:04 ` patch 'eventdev/eth_tx: fix devices loop' " Kevin Traynor
2023-02-23 15:05 ` patch 'crypto/qat: fix stream cipher direction' " Kevin Traynor
2023-02-23 15:05 ` patch 'fbarray: fix metadata dump' " Kevin Traynor
2023-02-23 15:05 ` patch 'gpudev: fix deadlocks when registering callback' " Kevin Traynor
2023-02-23 15:05 ` patch 'graph: fix node shrink' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/nfp: fix firmware name derived from PCI name' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/hns3: fix inaccurate RTC time to read' " Kevin Traynor
2023-02-23 15:05 ` patch 'app/testpmd: fix interactive mode with no ports' " Kevin Traynor
2023-02-23 15:05 ` patch 'telemetry: move include after guard' " Kevin Traynor
2023-02-23 15:05 ` patch 'ethdev: fix telemetry data truncation' " Kevin Traynor
2023-02-23 15:05 ` patch 'mempool: " Kevin Traynor
2023-02-23 15:05 ` patch 'cryptodev: " Kevin Traynor
2023-02-23 15:05 ` patch 'mem: " Kevin Traynor
2023-02-23 15:05 ` patch 'examples/qos_sched: fix debug mode' " Kevin Traynor
2023-02-23 15:05 ` patch 'app/dumpcap: fix storing port identifier' " Kevin Traynor
2023-02-23 15:05 ` patch 'vdpa/ifc: fix argument compatibility check' " Kevin Traynor
2023-02-23 15:05 ` patch 'vdpa/ifc: fix reconnection in SW-assisted live migration' " Kevin Traynor
2023-02-23 15:05 ` patch 'vhost: fix net header settings in datapath' " Kevin Traynor
2023-02-23 15:05 ` patch 'baseband/acc: fix memory leak on acc100 close' " Kevin Traynor
2023-02-23 15:05 ` patch 'baseband/acc: fix acc100 iteration counter in TB' " Kevin Traynor
2023-02-23 15:05 ` patch 'crypto/ccp: remove some printf' " Kevin Traynor
2023-02-23 15:05 ` patch 'crypto/ccp: remove some dead code for UIO' " Kevin Traynor
2023-02-23 15:05 ` patch 'crypto/ccp: fix IOVA handling' " Kevin Traynor
2023-02-23 15:05 ` patch 'test/crypto: fix typo in AES test' " Kevin Traynor
2023-02-23 15:05 ` patch 'test/crypto: add missing MAC-I to PDCP vectors' " Kevin Traynor
2023-02-23 15:05 ` patch 'compressdev: fix end of driver list' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/bnxt: fix Tx queue stats after queue stop and start' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/bnxt: fix Rx " Kevin Traynor
2023-02-23 15:05 ` patch 'net/bnxt: fix RSS hash in mbuf' " Kevin Traynor
2023-02-23 15:05 ` patch 'event/cnxk: wait for CPT flow control on WQE path' " Kevin Traynor
2023-02-23 15:05 ` patch 'event/cnxk: fix burst timer arm' " Kevin Traynor
2023-02-23 15:05 ` patch 'event/cnxk: fix timer operations in secondary process' " Kevin Traynor
2023-02-23 15:05 ` patch 'mem: fix hugepage info mapping' " Kevin Traynor
2023-02-23 15:05 ` patch 'raw/ifpga/base: fix init with multi-process' " Kevin Traynor
2023-02-23 15:05 ` patch 'telemetry: fix repeat display when callback don't init dict' " Kevin Traynor
2023-02-23 15:05 ` patch 'eal/linux: fix hugetlbfs sub-directories discovery' " Kevin Traynor
2023-02-23 15:05 ` patch 'test/mbuf: fix mbuf reset test' " Kevin Traynor
2023-02-23 15:05 ` patch 'eventdev/timer: fix overflow' " Kevin Traynor
2023-02-23 15:05 ` patch 'vhost: decrease log level for unimplemented requests' " Kevin Traynor
2023-02-23 15:05 ` patch 'vhost: fix possible FD leaks on truncation' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/virtio-user: fix device starting failure handling' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/hns3: declare flow rule keeping capability' " Kevin Traynor
2023-02-23 15:05 ` patch 'doc: fix description of L2TPV2 flow item' " Kevin Traynor
2023-02-23 15:05 ` patch 'app/testpmd: fix forwarding stats for Tx dropped' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/txgbe: fix default signal quality value for KX/KX4' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/txgbe: fix packet type to parse from offload flags' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/ngbe: " Kevin Traynor
2023-02-23 15:05 ` patch 'net/txgbe: fix interrupt loss' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/hns3: fix log about indirection table size' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/hns3: extract common function to query device' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/hns3: refactor set RSS hash algorithm and key interface' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/hns3: fix clearing RSS configuration' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/hns3: use RSS filter list to check duplicated rule' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/hns3: remove useless code when destroy valid RSS " Kevin Traynor
2023-02-23 15:05 ` patch 'net/hns3: fix warning on flush or destroy " Kevin Traynor
2023-02-23 15:05 ` patch 'net/hns3: fix config struct used for conversion' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/hns3: fix duplicate RSS rule check' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/sfc: export pick transfer proxy callback to representors' " Kevin Traynor
2023-02-23 15:05 ` patch 'app/testpmd: fix link check condition on port start' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/hns3: add debug info for Rx/Tx dummy function' " Kevin Traynor
2023-02-23 15:05 ` patch 'net/hns3: remove debug condition for Tx prepare' " Kevin Traynor
2023-02-23 15:06 ` patch 'net/sfc: fix MAC address entry leak in transfer flow parsing' " Kevin Traynor
2023-02-23 15:06 ` patch 'net/sfc: enforce fate action in transfer flow rules' " Kevin Traynor
2023-02-23 15:06 ` patch 'net/txgbe: fix Rx buffer size in config register' " Kevin Traynor
2023-02-23 15:06 ` patch 'net/mlx5: fix flow sample with ConnectX-5' " Kevin Traynor
2023-02-23 15:06 ` patch 'net/mlx5: fix error CQE dumping for vectorized Rx' " Kevin Traynor
2023-02-23 15:06 ` patch 'net/mlx5: ignore non-critical syndromes for Rx queue' " Kevin Traynor
2023-02-23 15:06 ` patch 'net/mlx5: check compressed CQE opcode in vectorized Rx' " Kevin Traynor
2023-02-23 15:06 ` patch 'net/i40e: reduce interrupt interval in multi-driver mode' " Kevin Traynor
2023-02-23 15:06 ` patch 'net/ixgbe: fix firmware version consistency' " Kevin Traynor
2023-02-23 15:06 ` patch 'net/iavf: add lock for VF commands' " Kevin Traynor
2023-02-23 15:06 ` patch 'net/i40e: fix validation of flow transfer attribute' " Kevin Traynor
2023-02-23 15:06 ` patch 'net/ice: " Kevin Traynor
2023-02-23 15:06 ` patch 'net/iavf: protect insertion in flow list' " Kevin Traynor
2023-02-23 15:06 ` patch 'net/iavf: fix building data desc' " Kevin Traynor
2023-02-23 15:06 ` patch 'net/ixgbe: enable IPv6 mask in flow rules' " Kevin Traynor
2023-02-23 15:06 ` patch 'net/iavf: fix VLAN offload with AVX2' " Kevin Traynor
2023-02-23 15:06 ` patch 'app/compress-perf: fix some typos' " Kevin Traynor
2023-02-23 15:06 ` patch 'app/compress-perf: fix testing single operation' " Kevin Traynor
2023-02-23 15:06 ` patch 'net/bnxt: fix link state change interrupt config' " Kevin Traynor
2023-02-23 15:06 ` patch 'app/testpmd: fix crash on cleanup' " Kevin Traynor
2023-02-23 15:06 ` patch 'sched: fix alignment of structs in subport' " Kevin Traynor
2023-02-23 15:06 ` patch 'eal/freebsd: fix lock in alarm callback' " Kevin Traynor
2023-02-23 15:06 ` patch 'dma/ioat: fix device stop if no copies done' " Kevin Traynor
2023-02-23 15:06 ` patch 'dma/ioat: fix indexes after restart' " Kevin Traynor
2023-02-23 15:06 ` patch 'dma/ioat: fix error reporting on " Kevin Traynor
2023-02-23 15:06 ` patch 'reorder: invalidate buffer from ready queue in drain' " Kevin Traynor
2023-02-23 15:06 ` patch 'test/reorder: fix double free of drained buffers' " Kevin Traynor
2023-02-23 15:06 ` patch 'build: fix toolchain definition' " Kevin Traynor
2023-02-23 15:06 ` patch 'eal: use same atomic intrinsics for GCC and clang' " Kevin Traynor
2023-02-23 15:06 ` patch 'examples/cmdline: fix build with GCC 12' " Kevin Traynor
2023-02-23 15:06 ` Kevin Traynor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230223150631.723699-99-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).