From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 180F241D8D for ; Mon, 27 Feb 2023 08:16:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F31B410EE; Mon, 27 Feb 2023 08:16:56 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2056.outbound.protection.outlook.com [40.107.244.56]) by mails.dpdk.org (Postfix) with ESMTP id 5FA9040ED6 for ; Mon, 27 Feb 2023 08:16:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gWrDo73QzPasV073JO5z7WbEuVdjfZfJd0nZPx1uqm6uiztIDNWUabb86HdgmD/yIt6plb51l/Ftkrx9I4ruylm2C3w5kFI8svbB6RdtVskW8nxeCtcqOnyBpx4wKLfDmkWsTutpY8BPUdeqCz65zgr4nXuCMU8znXD0YS+3POnuw3KnCBijr2VBSqQwef1PuoT4UmhXcfX9hl8uZN+BMPAnhfBkdfB/z9EwQM43HYrVO9O2svSE/Khpz2aUzJHjBaIzfuvTw2kBtQ8tvw6EntWSryGWSqlJNXbYDyvRxEh/2CLCTy0+9C84bbmMn2VBZcidBRxE3GST3PegWcbCqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cdFb5rlsejUiOCTalTX1y7kPnbyq1DZkj8fn3/7jv4I=; b=M7i5rzcJFRAeqL5unPLusk1OYboEK7Zh/3ldB/ImdxPu1cCNLrUPWQdDqA7gSHpYKKZg76NgxZkYADcXekbZiVM6hDEaAnsVOSjIgj6wlisMZ03NLZ93znU7pzNWqYv0EAXNg+It/UOnUhvRxXjnSINcgDMYj9kxK+4YtH+rTet3XGWMoTN3UX/y1t0FJbljFQJgj/m4kVhcz4UBHqW1ZOnJrAaR0vWDSc1jbMAQ8GRXiMgJlhvCFp/yFkxCYDCg1dCsMNGLfyIOsEdNfnVtzVHr5gi5euYMn/fiEwMhrYj8Hipf5vPp/f6oWP1F8i18mPW511WMMYqEwfjz1ncwKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=6wind.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cdFb5rlsejUiOCTalTX1y7kPnbyq1DZkj8fn3/7jv4I=; b=k+qPv64x1zr1rDMuwwjHP2NkIM+8nrFHvt5eYgMpCfH4GjVX6hdqh28fg4N/c5zj9LW5so9CvAE8exgs9QcPrqxk+sVdtdcUDnbT2UUEPGhoLXuQl2romn74cMtU7aThgqzJ22FiOnpeVyt3gFvwzkqbZRgBbLKQ0b6Ah6TzTS74zHGgBfpXNEQUQRa8hWqjvsrecee1i4/RMstAb0JrqxxgKzpjjngcRYUjJogWYxRUcH2T6k4nWy/GgQacQsIw/Z+EwEH3hfBwfOn7gA8OQ0fuoZzijJBEEqf4ZE3tYvbjfcrt/aae/vyRVRX2g98hcLiM0zp1WbAseoPhDdsypQ== Received: from BLAPR05CA0008.namprd05.prod.outlook.com (2603:10b6:208:36e::11) by SN7PR12MB6713.namprd12.prod.outlook.com (2603:10b6:806:273::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 07:16:52 +0000 Received: from BL02EPF00010209.namprd05.prod.outlook.com (2603:10b6:208:36e:cafe::74) by BLAPR05CA0008.outlook.office365.com (2603:10b6:208:36e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.16 via Frontend Transport; Mon, 27 Feb 2023 07:16:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF00010209.mail.protection.outlook.com (10.167.241.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.12 via Frontend Transport; Mon, 27 Feb 2023 07:16:51 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 26 Feb 2023 23:16:37 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 26 Feb 2023 23:16:34 -0800 From: Xueming Li To: Edwin Brossette CC: Somnath Kotur , Ajit Khaparde , dpdk stable Subject: patch 'net/bnxt: fix link state change interrupt config' has been queued to stable release 22.11.2 Date: Mon, 27 Feb 2023 15:00:53 +0800 Message-ID: <20230227070107.15664-145-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230227070107.15664-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230227070107.15664-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00010209:EE_|SN7PR12MB6713:EE_ X-MS-Office365-Filtering-Correlation-Id: 78eb492e-86d0-4a59-54b2-08db1892996f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hEd4WAI6S9Cnv71AbRbiKikqg6mgK2a6O19JnnRY3lO2dIKDEOANBSusv/dgCz/tOEX3c62is3RSeMYYAOgRYfF45yqzYkTXPS9iSSvzknnc/VIj3MRQ8a1l9c8bw9Ho8FcV5TH+2E+2VyWQWALRDP4XzHmyVsrBCP+6oRVvRBewcNSt+mhOnUovmR8aSEWeeHD5dLLtYlpWw0WgiiQeIgfs23lHjRwK9NsLwBvPId+uSSl5phfeHDUipdRhRouXosyK8rd0MdY8oWzaLEAC88P3+2HU/qxjLG7fxhlL7BeNqMPfxOhOuoBPK8hW3MHAL3apAMvorn4a5B/tCrlgWlt9j9o+47VEYqDgaAauLYF9pJXzqAqwtxMeM1kltHDnvdPC1/2g2t22DAR7wv6ybbioL/LdxinlffZFzDTS99ZTg1ypa03qYk0Bv3s4BRQqi6opUThUwXRKAn25mnbMo4huWTODT0x0UKzQdAcm+L5uXfzWR8h5KCim2wYlfG2wLIkUCUMamt8J1uVPR5cLeXUR0A5HNP3gXIWzI07/e9lIEJje+uJqlib7K4bhmailfvi4sk2Wr1ob87UzrPuAVGIMLURHtqMZsxR72DSak7Tv37MI7d/yPocmQ7Jvn6aB7EbU+sl/ZEz7k3Q+TXrq5cSh0ms0WqAZ1j9fDnWw8usEhzvIP7+pM2EJ7B6W9roqep/CwmUJ0EL4ChcLbHLfOqODBRTE/MaiPhDq56LcDxpuFAeNGwW7JGntb489Sg9hv/KbTs1/o/eQpzptw58Zaf4tjgPwy5kBLuSElQfDknQ= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199018)(36840700001)(46966006)(40470700004)(336012)(47076005)(426003)(316002)(54906003)(36756003)(40460700003)(40480700001)(86362001)(55016003)(356005)(82740400003)(7636003)(36860700001)(82310400005)(1076003)(6666004)(53546011)(83380400001)(16526019)(186003)(26005)(6286002)(2616005)(5660300002)(7696005)(8936002)(2906002)(966005)(478600001)(41300700001)(6916009)(4326008)(8676002)(70586007)(70206006); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 07:16:51.9526 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 78eb492e-86d0-4a59-54b2-08db1892996f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00010209.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6713 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/01/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=8cdbec0d75920660a7d528b3e4e48d792cfa8104 Thanks. Xueming Li --- >From 8cdbec0d75920660a7d528b3e4e48d792cfa8104 Mon Sep 17 00:00:00 2001 From: Edwin Brossette Date: Mon, 6 Feb 2023 18:11:13 +0100 Subject: [PATCH] net/bnxt: fix link state change interrupt config Cc: Xueming Li [ upstream commit 60653f4a25bd87a32bc148461f32566af997da8b ] When getting the device's info via bnxt_dev_info_get_op(), the device enables interrupts on link state changes because of the following line: eth_dev->data->dev_conf.intr_conf.lsc = 1; Enabling this mode might not be wanted by the user. The flag RTE_ETH_DEV_INTR_LSC can be used to inform the above application that LSC interrupts are supported. Thus, checking this flag, the user can decide whether or not to enable these interrupts. Since there is no reason for a function meant to display config to actually modify it, remove this line. In addition, raise the dev_flag associated with this state on the device's initialization to show the device supports link state change interrupts. Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification") Signed-off-by: Edwin Brossette Acked-by: Somnath Kotur Acked-by: Ajit Khaparde --- .mailmap | 1 + drivers/net/bnxt/bnxt_ethdev.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index c5ee0741b7..42a169ca18 100644 --- a/.mailmap +++ b/.mailmap @@ -339,6 +339,7 @@ Dzmitry Sautsa Ed Czeck Eduard Serra Edward Makarov +Edwin Brossette Eelco Chaudron Elad Nachman Elad Persiko diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index b3de490d36..753e86b4b2 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1017,7 +1017,6 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev, .tx_free_thresh = 32, .tx_rs_thresh = 32, }; - eth_dev->data->dev_conf.intr_conf.lsc = 1; dev_info->rx_desc_lim.nb_min = BNXT_MIN_RING_DESC; dev_info->rx_desc_lim.nb_max = BNXT_MAX_RX_RING_DESC; @@ -5859,6 +5858,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused) rte_eth_copy_pci_info(eth_dev, pci_dev); eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS; + eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC; bp = eth_dev->data->dev_private; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-27 14:08:45.524195900 +0800 +++ 0146-net-bnxt-fix-link-state-change-interrupt-config.patch 2023-02-27 14:08:40.949237000 +0800 @@ -1 +1 @@ -From 60653f4a25bd87a32bc148461f32566af997da8b Mon Sep 17 00:00:00 2001 +From 8cdbec0d75920660a7d528b3e4e48d792cfa8104 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 60653f4a25bd87a32bc148461f32566af997da8b ] @@ -23 +25,0 @@ -Cc: stable@dpdk.org @@ -34 +36 @@ -index e111e05bc2..a9f4f28fba 100644 +index c5ee0741b7..42a169ca18 100644