From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A45541D8D for ; Mon, 27 Feb 2023 08:17:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12F05410D3; Mon, 27 Feb 2023 08:17:59 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2079.outbound.protection.outlook.com [40.107.237.79]) by mails.dpdk.org (Postfix) with ESMTP id 7508E40ED6 for ; Mon, 27 Feb 2023 08:17:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ji+ZG8S/QIDdgOI3OXgnoh7D4qjymmm5LyM22bik3FXlKqYELDsNPzw3aIKRYOuWGyIbiftqEyT6q49WFfCMDp880OiJwRUfZf4PDWEWLEwjDXGG87BtRpu31inXARoAkATyEQASepLJZcd83OzogVXkq3ie1tfmsYLa0D7WvzxYBQIRW9fPJ9sjjbO2s4QIsBeiZHyhWPjYl8q++AlrUdeyLpAuQh1TUKe7VQInQaDyQKlHhlPTxU7yB+d+Bc3/g5wNS9pVYD2K6qvDpXto8jDIfkOkAEXDdGoquaPVP+bZzQglPrui39a7fo0ThFHT3+MpaW0GkvcNctDGs3W55g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=usihzf7OaxjFdLXDpyTz/bafLRSF16jUQBomzfp8SM8=; b=K03SLE8DcvnIhaAG42JlEXyrJ9aal8octNleh1H2O4+Fj0blTW+JheuQ9QASRinTNtxE00On08FbMdLFOOH4r2SVjgSi13vaTkB8fisPLjA7MInF1GJfa7NQDz7DMPfTc1nh0NaNY5WkwdtE5ss6iUoUyrqvULkG9gHe9Z8UAS/f/80X05hlSsFLaRQVRcyTUHzVZaW/S8YogYNeLgoldRCowsDpAWDlFMl2jd+IeClNappdQpDTcbGNkQ3t2YdLtHs87AzTAtGOg3+tAVRiz1r1d9Kwy3+yHKYOcYlgXlCB5YofLNIDOwRWcjpasgD9tCNLDrFt+gfMOu0fXA/hVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=usihzf7OaxjFdLXDpyTz/bafLRSF16jUQBomzfp8SM8=; b=htkQ0Ddq0NVmSgnXnOIZNTz0V/bKqDClSvwV5brVuiYsOXYcCE/T/wFpEltlE9HdIwM8O2tUgjnaAbiZzgiN8aHzx9sADKpGD/BbL/KUY4uw6FfS34TwMyfPm16kK8SD/fuF4U7Du8gf+t0gDfecJC6z3+w58bQSxq4SXWyPaWqQC9AhO1+gXFYriZA8SScs+Sob2WQFYxNz/5FXRLILKMqerLOPNcPrnk+9Kr2O2oDSsd46BaKITlcVmVoIFFELJv6yN31ci+xbfdEnk3iLq3iYWYtdS4Hiy7OEqHkfBNOJGqFJghMrPo8DURuSE/w5bwRIF59L55fFtvV6mdxTbg== Received: from BL1PR13CA0143.namprd13.prod.outlook.com (2603:10b6:208:2bb::28) by DS0PR12MB8247.namprd12.prod.outlook.com (2603:10b6:8:f5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.28; Mon, 27 Feb 2023 07:17:56 +0000 Received: from BL02EPF00010208.namprd05.prod.outlook.com (2603:10b6:208:2bb:cafe::89) by BL1PR13CA0143.outlook.office365.com (2603:10b6:208:2bb::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.16 via Frontend Transport; Mon, 27 Feb 2023 07:17:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF00010208.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.12 via Frontend Transport; Mon, 27 Feb 2023 07:17:56 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 26 Feb 2023 23:17:41 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 26 Feb 2023 23:17:38 -0800 From: Xueming Li To: Volodymyr Fialko CC: Stephen Hemminger , dpdk stable Subject: patch 'test/reorder: fix double free of drained buffers' has been queued to stable release 22.11.2 Date: Mon, 27 Feb 2023 15:01:03 +0800 Message-ID: <20230227070107.15664-155-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230227070107.15664-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230227070107.15664-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00010208:EE_|DS0PR12MB8247:EE_ X-MS-Office365-Filtering-Correlation-Id: 86d846c0-349b-4e37-ad0e-08db1892bfb6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d+NsFJ3BLu9Ugk15UnZc5m8f1EeHPiNI/iVM4yQZ2vzdFG8GaXjP6ZuCdqeIagMbqfkJO5E+g8qYfDY/qAY2zcxq0mmFQqh54G1Yn2i7EMbgn8pbE/UB/EEoHJLtdq0nfU5p42/+g8MmX/3Q3M+Ze+zjCOQjjAeNV4NPTHoJ8J5sQon9ggTcyAgq0uA49o/uNsLjW3Ee7O5pi1/8RMQzri9/LDR3oquXqJDpXYQJkkk2at36CJoUk54xrMyG750KvOiOo55g3R3SxbEZgFBa0zRU4Pl0wiDbtRFFZuny9I6JWcLPhk2/lq0/6pwWlfwQYqkHENcLkQqx0lXWB2stf9GIkHGgPSogD9vW2AmcmCNSaYdKBJLLpkEWkIXnSpVGDS8O8EWgi3TxCGeNPRopcVBtETktDApBrnM12JXunGwMLqAN7lxbVxF4s3G7Ox34/kBklrseCY7oZnPWm0hiJO3yfDJz1gsVBolqYhSTZxIuoGNQs3y/J/li6AIwr8K1/k8z98EuIy3MeOqkSM9COmQy4eIyT7hS1HWuOEszyw0/Xzs8YVhXQBEQqw0heW94258C65S+bTouIhXxN6jeMDy9VAYAVPsF2Tg+oSiZdlTj5p1Syx4m+iyise5Q1l8heMxeSf3jQ7j+SG+IFbNbGqpuV+GIf7NBaa96hCFur7dUlyYz6FCko3wf7IJV+73mVkgO41QgqJdxRzyaMonG8QseHKB5D3yQdHRSphXHQTtt1tYM7DYwiIU8KOA29cqVFmJE+YGn8RDYINMAZipjzq4e6feEyvAExfppd9QUsSPvBn13FbZ3U+MHOUISatKqz4OFZLL7DF6wzT7ZH1Evng== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(346002)(136003)(396003)(376002)(39860400002)(451199018)(36840700001)(40470700004)(46966006)(5660300002)(40460700003)(36756003)(86362001)(55016003)(40480700001)(8936002)(478600001)(83380400001)(2616005)(336012)(82310400005)(47076005)(426003)(6666004)(7696005)(966005)(16526019)(186003)(26005)(6286002)(1076003)(70206006)(70586007)(41300700001)(53546011)(8676002)(6916009)(4326008)(54906003)(356005)(36860700001)(82740400003)(7636003)(316002)(2906002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 07:17:56.1581 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86d846c0-349b-4e37-ad0e-08db1892bfb6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00010208.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8247 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/01/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=15ae43b33a3fe1ecff7af0202db6091617435727 Thanks. Xueming Li --- >From 15ae43b33a3fe1ecff7af0202db6091617435727 Mon Sep 17 00:00:00 2001 From: Volodymyr Fialko Date: Sat, 7 Jan 2023 16:19:39 +0100 Subject: [PATCH] test/reorder: fix double free of drained buffers Cc: Xueming Li [ upstream commit d51955ea93fba1873e9c2b86a911e114787bdd4d ] Set to zero array of drained buffers after free, to prevent freeing them one more time. Discovered with enabled `RTE_LIBRTE_MEMPOOL_DEBUG`. Fixes: ecd867faa860 ("test/reorder: fix freeing mbuf twice") Signed-off-by: Volodymyr Fialko Acked-by: Stephen Hemminger --- app/test/test_reorder.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test/test_reorder.c b/app/test/test_reorder.c index f0714a5c18..7b5e590bac 100644 --- a/app/test/test_reorder.c +++ b/app/test/test_reorder.c @@ -278,6 +278,7 @@ test_reorder_drain(void) goto exit; } rte_pktmbuf_free(robufs[0]); + memset(robufs, 0, sizeof(robufs)); /* Insert more packets * RB[] = {NULL, NULL, NULL, NULL} @@ -313,6 +314,7 @@ test_reorder_drain(void) for (i = 0; i < 3; i++) { rte_pktmbuf_free(robufs[i]); } + memset(robufs, 0, sizeof(robufs)); /* * RB[] = {NULL, NULL, NULL, NULL} -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-27 14:08:45.817987600 +0800 +++ 0156-test-reorder-fix-double-free-of-drained-buffers.patch 2023-02-27 14:08:40.959237000 +0800 @@ -1 +1 @@ -From d51955ea93fba1873e9c2b86a911e114787bdd4d Mon Sep 17 00:00:00 2001 +From 15ae43b33a3fe1ecff7af0202db6091617435727 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit d51955ea93fba1873e9c2b86a911e114787bdd4d ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org