From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5CCF41D8C for ; Mon, 27 Feb 2023 08:03:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1C5B40A84; Mon, 27 Feb 2023 08:03:14 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2066.outbound.protection.outlook.com [40.107.223.66]) by mails.dpdk.org (Postfix) with ESMTP id 20F9840A7D for ; Mon, 27 Feb 2023 08:03:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=biA15z3kDv4OGv+SUP0iMLkckMch5Q1r+NbW2aTqlP/A0ykYrPsgp7mgplXmFTi8BeSIauKR8j9LLFwJ9HcIFPxorhb2inx34fs1uJbhRWMvKnItqx37CrAOfLJpVJDSBJgNoLrOsUALKqWvy69DyyKXD9Vea8/WAlrZ2N2vOvMnzGM+8dQRSz+RhS/T75jSd3oRTxU5PbLlBN9+1Tbnx58T51jDuuFyaL4pbJ+OALcl78Wy7qi2AWz4MumlcRY0UvSbvMDAIOLealIfz2QQKMd5RTfv78i8MN42z49zXuU60XapIm+Gy2F0BKR5y+HTv27WZZULs3v+IyrFIGJ0MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N9Y1F0vsT8/FJJv0MZ0G3yfUmb2SdwPi1J3qa2PBlBU=; b=jvsH0wWeCvtTMp7tHjOZICC75qvIp04lCs7S8IZjP1zEYaDvM5zEXXUbJbSDFqjYtg5a/TslKcdgAMVHEjBlNXQ6urXAJ1LcEuLwGQHysbqSJLByRZJn8zL9qmwVLrEngVsrwg19QVc3jfQlwCgdgemnN7F+/GA3RJfrJT+BdeHKLfYpfZmjzQfXKCgOTSy16+/tf2Yq8IA4d2LJj6nGdvCpz9+18vkfRPKcAnlaFkRIw1DwpSdb6yxWcE9woBynn/P6aSO1ZOeZ9dZDkoL6xWI5EhXQ2BvTAH80kQISe2EVx/Xx5vGVPjMmpcDXzcpBBTcnTP3XDty6fsurKIfgZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N9Y1F0vsT8/FJJv0MZ0G3yfUmb2SdwPi1J3qa2PBlBU=; b=gfzdyjseY/nrg9fCIlLSL7bclznnWvZPmlp6ggZBD2u6YF+Fj6m66PLXph6btE0o2bdw9Cxl3R83z7J/uu5ZCgE6fkPm+sWTpcl+4/q6wvHKV1c98C8/ZQFw3+0BXBirvYhNgKMo80yWHMvRP+Kourk7tnzSfFgtVbeA0RFVYw1F9WOT7x9gd7uFr7SxCos3IVIAdz+Vg78mpsEiIfxgwLbhv78d4XSKnJK75TGRDpZraQQ7WPyPOc02E4J9+2x5gFFaV0WwFVG+aC6hRzs8ldKDlK3TvIGj3JhE7jEwq0TJEtIb7QtWvSBn4reYWfsmF97u6NvGJf6Nep9DPIeVIw== Received: from BL1PR13CA0219.namprd13.prod.outlook.com (2603:10b6:208:2bf::14) by IA1PR12MB7661.namprd12.prod.outlook.com (2603:10b6:208:426::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 07:03:10 +0000 Received: from BL02EPF000108EB.namprd05.prod.outlook.com (2603:10b6:208:2bf:cafe::2b) by BL1PR13CA0219.outlook.office365.com (2603:10b6:208:2bf::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.16 via Frontend Transport; Mon, 27 Feb 2023 07:03:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF000108EB.mail.protection.outlook.com (10.167.241.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.12 via Frontend Transport; Mon, 27 Feb 2023 07:03:09 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 26 Feb 2023 23:03:03 -0800 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 26 Feb 2023 23:03:01 -0800 From: Xueming Li To: Naga Harish K S V CC: dpdk stable Subject: patch 'eventdev/eth_tx: fix devices loop' has been queued to stable release 22.11.2 Date: Mon, 27 Feb 2023 14:58:44 +0800 Message-ID: <20230227070107.15664-16-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230227070107.15664-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230227070107.15664-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF000108EB:EE_|IA1PR12MB7661:EE_ X-MS-Office365-Filtering-Correlation-Id: 35da080e-121a-4e5a-f1b8-08db1890af61 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RrhY4PJP1nEZ/R7JPYR0IUtoHHSXotXgMFbv804uWpRKR/I8mSHu1aW9M+0QRgFPitpiBVCh79uCzjY3BZRIOpt+Z6eyi4FrVILNDFW8S5/TrzS/WdiTxe7DrcsYA6WFmfyDrGSzb6M2W/I1r4vE3c4R6AN2uDlDPnT08IkQNxkDbUAGap0uZk6qnQcgaNYMNiAPapmqYW/fN/VwmxfPtZ7Cwc9lJqPz4Xjqph164z0aO/0makvsjo0/X0J35tsTHY5yfLoDwozYpndWGkWue8/QMXSo99m0U66d4qG0g11Gq0UCikJkehWpGApfA8dZ6KRePvosZrGsZU6GkMDEHQL922GlSjBVW7gl4VJJ9u2vBZ29jXvwbHq/BJMPN1AbsWgPObKeLcBYJTl2EKI3qs/zhZ4iCG6aUFkXlIYOgIkxX38TqF8cYbDVrqs6o/quz73omHkrDTZKYBCjt1I6xOsejIoDltBV27SuU/Wa3LUIUClDia4bFTjy2TOCEgw9SpbkkoyAZ9DoMAkz4FkjQed5dJtX/ZzP0Ty+i1paqcyhlaUXfHQMYBVfkQ/JMxT0tGHlQuI1BoKi7jBtEsBYfVGc/nZZfZLQf+o/mZ+XOEm9gIx1pLe5MvltrV+5cny5VOk21hHrGq/UmoEYBQS9Z3R8sXgBz9LqMflW4u+wC+TxPEye0u1JocKbWTXb5OhuraCn2xmQ7GQG0OovfNvRRELdl5JXEPfvLtS+pP6x8HaXsmYKPawaSdmuWmKMh/pTV9aiczPQVuBP3w4/BBaWT909804xZcB3t2fA+/NLln0= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(136003)(396003)(376002)(346002)(451199018)(40470700004)(36840700001)(46966006)(40460700003)(36756003)(316002)(966005)(478600001)(8936002)(5660300002)(2906002)(7696005)(8676002)(70206006)(70586007)(6916009)(4326008)(41300700001)(7636003)(82740400003)(36860700001)(356005)(86362001)(55016003)(40480700001)(6286002)(186003)(26005)(16526019)(2616005)(6666004)(53546011)(83380400001)(82310400005)(1076003)(336012)(47076005)(426003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 07:03:09.7815 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 35da080e-121a-4e5a-f1b8-08db1890af61 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF000108EB.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7661 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/01/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=478bec21d0b46f3dd243e4d028f596d7cde7d733 Thanks. Xueming Li --- >From 478bec21d0b46f3dd243e4d028f596d7cde7d733 Mon Sep 17 00:00:00 2001 From: Naga Harish K S V Date: Sat, 7 Jan 2023 10:40:58 -0600 Subject: [PATCH] eventdev/eth_tx: fix devices loop Cc: Xueming Li [ upstream commit a870c7e863a5996eb842befa30c6a7d3f9729fcf ] Adapter service function is using RTE_ETH_FOREACH_DEV() macro for looping through all available eth devices and flushing any pending buffered packets. When Traffic Management nodes (vports) are added and deleted dynamically, there is a possibility of accessing the device info memory beyond the allocated limit which can result in segfaults. Fixed the logic to prevent illegal memory access. Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation") Signed-off-by: Naga Harish K S V --- lib/eventdev/rte_event_eth_tx_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c index 88309d2aaa..ba7a1c7f1b 100644 --- a/lib/eventdev/rte_event_eth_tx_adapter.c +++ b/lib/eventdev/rte_event_eth_tx_adapter.c @@ -676,7 +676,7 @@ txa_service_func(void *args) RTE_ETH_FOREACH_DEV(i) { uint16_t q; - if (i == txa->dev_count) + if (i >= txa->dev_count) break; dev = tdi[i].dev; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-27 14:08:41.525170700 +0800 +++ 0017-eventdev-eth_tx-fix-devices-loop.patch 2023-02-27 14:08:40.729237000 +0800 @@ -1 +1 @@ -From a870c7e863a5996eb842befa30c6a7d3f9729fcf Mon Sep 17 00:00:00 2001 +From 478bec21d0b46f3dd243e4d028f596d7cde7d733 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit a870c7e863a5996eb842befa30c6a7d3f9729fcf ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org @@ -24 +26 @@ -index c780ee1264..6e9bcb1b79 100644 +index 88309d2aaa..ba7a1c7f1b 100644 @@ -27 +29 @@ -@@ -678,7 +678,7 @@ txa_service_func(void *args) +@@ -676,7 +676,7 @@ txa_service_func(void *args)