From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6921C41D8D for ; Mon, 27 Feb 2023 08:04:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6600B4114B; Mon, 27 Feb 2023 08:04:26 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2067.outbound.protection.outlook.com [40.107.94.67]) by mails.dpdk.org (Postfix) with ESMTP id 7C93940A7D for ; Mon, 27 Feb 2023 08:04:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=APsyqOP0JvfmWLOd6gHj3JPMqMsxGuya96hYWJ9qOsf66iunHEFmWgI4IBcl+yFiquGsnTlJjTyugXnsvbBH0PwIHyFokyK58Y5rwqJ+7vgBbN5q57eSYO3UIbtL6au9WmxmG7R5U05Fn/NikVTDUOpl1FJjmRyBDPg1P6HBK/zL+RA/hUd+iQVvNPavc+vM0YMAueentrTB9XfYiEJyfgUtr79uAFWsmaezH0zKyJFtzzgW9bzdvAu3T+4yV31/3dpLNt/G+2UOTD10afjHfXp5vvLtDHtjz5lNBvCFAPjyfe/vKyXRyTrRXZa3p1he9P3wNXgMoR2qrtc2KKDoNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NLXXd4O1hq+aZHCskI/cvqBKWUCIeZ+UNRQLBJtsPNQ=; b=OXY5P8LoqeMKHceG+2uzbAF7QJ/WtHgG+uCuoCB9bEqy1TUYaXsIWO1DkC3NoESmj9Uel1O+hD6aisz5n5M64W1NgFf6RBtxC1x8hmgG9UGVdcX3UiUcQLDivQ5YqtMtJENhwpQzU09QVdtQWkNxlM2uC9g6Q2r0AFXiWWnUhoPfvSVJO3aKLWQuYRiM3QOpoNJBkHR40EnGqvvFo5JxcYaNHZKhbii5/iqDq7BxstHGxOt7nNVWo2DjP9wNLaBYTj71/t7OIssevVyKi8gYsKa+CjyFw5R0RIrrYY0y1tlpO8lEQ+oQqg3LmWf/w8aHbu0j1LG96paOt2hsXdZNhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NLXXd4O1hq+aZHCskI/cvqBKWUCIeZ+UNRQLBJtsPNQ=; b=mBacM5z3zG9nq/zFN63fxhfQ3TK8RuPmUXCIf6WDASEPknmbd+PS/dm8upu42RCT5XI3j59WG72WHKrkl0WYVuYTUhgCleZzP/kWDk/2RuvcMnYRqKsFqS1AmthfsdJyTz3WhqyW0C64yMQPWnI8W0ky6CHvChnq6q8+76ZLVBLQVSMcTo4fgvXk88AarjLYmBV1Tc+B0sBi7VqStesBOGjSb8AKJBVeLKn01CvS9IMujYRrmI/XK8cjiYgIx8c+Ic2fI33pwabW/pyVrfK2B9/xNVLI7zeJxq30sorUJDlFFfGhQfPUeFi9+FhCnRDCW45Ylk5nlrgX45ujlV1Kjw== Received: from BL1PR13CA0240.namprd13.prod.outlook.com (2603:10b6:208:2bf::35) by BY5PR12MB4067.namprd12.prod.outlook.com (2603:10b6:a03:212::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 07:04:23 +0000 Received: from BL02EPF000108EB.namprd05.prod.outlook.com (2603:10b6:208:2bf:cafe::16) by BL1PR13CA0240.outlook.office365.com (2603:10b6:208:2bf::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.15 via Frontend Transport; Mon, 27 Feb 2023 07:04:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF000108EB.mail.protection.outlook.com (10.167.241.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.12 via Frontend Transport; Mon, 27 Feb 2023 07:04:22 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 26 Feb 2023 23:04:11 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 26 Feb 2023 23:04:08 -0800 From: Xueming Li To: David Marchand CC: Fan Zhang , dpdk stable Subject: patch 'net/ena: fix deadlock in RSS RETA update' has been queued to stable release 22.11.2 Date: Mon, 27 Feb 2023 14:58:55 +0800 Message-ID: <20230227070107.15664-27-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230227070107.15664-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230227070107.15664-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF000108EB:EE_|BY5PR12MB4067:EE_ X-MS-Office365-Filtering-Correlation-Id: 63311193-6b00-4a77-ed47-08db1890dad1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sbgI2gqxcgG3JOGBWGGyXlDsqkVp5h2YUhpyKS4/Ss9QhE8xV3P/7V8b3D71B7FL7mAhQOkEpISO5h7LMGXARmysJxDuPkHxabqt8Vve0wRk9TE1+4+A1s2ihCBgsXJLN0oBTxEj+libT2r1+2IdItQGHozMV0KivlyXxzxtAPhaZB2+yOQH+wSEljUp4eLrJC8ZhDuT3666KsoscJKEjtLL/9aX6d9NHTdmK2GSeurouJP93irHAyOLMjMC56uE0O0WmuFRODeiV5BzP//1QkyAaScYltsq652Cdnf4w3oR2SHZTF9d7nmyPnx30hReVquu0cQZKOz3FW6GcZTGmC9mgybrvYXixEuhDvf3YOnsks9iExiC+t+yFn4szAR1FDBdt8JIELWys9a2yiMKLH/siRUWe2DrhAmwaUqqIcgGbfl8QqjviHr6KT9apiRIyvVgD7OyYTukxJDo0Dsvwl30Cm6KxFckvz0D4hyGb2vuuwncF+H/n+Ddo/tEqNcQ/vkILSokViN4/r3khcvkLOJMXWVNx3zkTcdoCj9DtCSAV6IN10ZKiqikWTvALTX22kosk4gmbOm8N28nIB4zP1zIuHLcmw2EZKC1qCphS+uXFNSptt6o6K6kYLQN2t4WGcQDIsDGmziSNUKrWeHTJWgZqZpNdNhyBAuPX4xcOGDIsjos9QMZj7kie2QnFEATNjLwMQRjbbnq5OWFbO6Z6A0cAXt0iGlPb/0lTPTleTD7c80xJWe8vJwZZlfHDjnY X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(346002)(396003)(136003)(376002)(39850400004)(451199018)(36840700001)(46966006)(26005)(186003)(6286002)(16526019)(1076003)(53546011)(6666004)(82310400005)(36860700001)(426003)(47076005)(83380400001)(356005)(86362001)(40480700001)(7636003)(82740400003)(36756003)(55016003)(2616005)(336012)(41300700001)(70206006)(70586007)(4326008)(6916009)(8676002)(15650500001)(2906002)(8936002)(5660300002)(966005)(7696005)(478600001)(316002)(54906003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 07:04:22.6574 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 63311193-6b00-4a77-ed47-08db1890dad1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF000108EB.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4067 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/01/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=36ec039309e62ddc9b22bdb50a4f96929df5ee1e Thanks. Xueming Li --- >From 36ec039309e62ddc9b22bdb50a4f96929df5ee1e Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 5 Jan 2023 14:57:33 +0100 Subject: [PATCH] net/ena: fix deadlock in RSS RETA update Cc: Xueming Li [ upstream commit 195e0f2497ad608a68b46b279e87b68adfd9fe23 ] Add missing lock release in case of internal failure. Fixes: e3595539e0e0 ("net/ena: proxy AQ calls to primary process") Signed-off-by: David Marchand Acked-by: Fan Zhang --- drivers/net/ena/ena_rss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ena/ena_rss.c b/drivers/net/ena/ena_rss.c index b682d01c20..d0ba9d5c0a 100644 --- a/drivers/net/ena/ena_rss.c +++ b/drivers/net/ena/ena_rss.c @@ -105,6 +105,7 @@ int ena_rss_reta_update(struct rte_eth_dev *dev, if (unlikely(rc != 0)) { PMD_DRV_LOG(ERR, "Cannot fill indirection table\n"); + rte_spinlock_unlock(&adapter->admin_lock); return rc; } } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-27 14:08:41.842114000 +0800 +++ 0028-net-ena-fix-deadlock-in-RSS-RETA-update.patch 2023-02-27 14:08:40.739237000 +0800 @@ -1 +1 @@ -From 195e0f2497ad608a68b46b279e87b68adfd9fe23 Mon Sep 17 00:00:00 2001 +From 36ec039309e62ddc9b22bdb50a4f96929df5ee1e Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 195e0f2497ad608a68b46b279e87b68adfd9fe23 ] @@ -9 +11,0 @@ -Cc: stable@dpdk.org