From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57BD441D8D for ; Mon, 27 Feb 2023 08:04:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52DEA40A84; Mon, 27 Feb 2023 08:04:58 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2045.outbound.protection.outlook.com [40.107.94.45]) by mails.dpdk.org (Postfix) with ESMTP id 0809640A84 for ; Mon, 27 Feb 2023 08:04:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h5l3kIzgmJEV9V4u2iqNSuOfvPI+v1Ye2+vcnU3cPGzNjc37mMvF2+XtS+m3Sw1X7d+gtEx54mRBmuasCMg6iU8Eg6D27OfGX4ofivHrVZqd+U6fylIv7GXJkp+R1KDssW8Dpww6rjMfNMPIq1yQxM8AF4Yy9ArGhq9oHIZBQJReqVN2SDiQF4cKCNLDje0h2BvqBZB6PB5Iq2NUzYn7xIoA50a0Pbx69NoVOevflvCRXkyRLkxkHGWfbaKLi+Nn8Z2hrLJaXo5hADAC041uW5ENtpaSvWxPW6FXjhE+JaPmWaP6Fn/Bt4T1ryNIJl4WWCWeUuCES+n5rDXbRaEK1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8gFppZeLKhfHL/TcSG/owlwcXYfYwpAm5cYGHZWedHM=; b=dE5Hvfh7xPeeu9/q1ZFMjFPElBz/PGw2C9u0NoieY43X7iQNx74CE97yWOCi0K8t/2iu1C2CUPyd0z8yXU2yAp/9ZftcI6fBPlpt7EQqloSLNoGj38c2UO7J9vUpiIBN12vQ/zbSca0IvpM6UzWT2yZUvtCEPpskf6G16wAfRzg1BtkyExtLwuyHfwpsctc4/OkWzAB1P09i7lFThGX9PaQSWYJDrzPchd4yzWeQK1p9id3uQRRi7MuFpuoCy5/gIQWPGlpj+KuEFcKEFZrsVXkBgjrqjczDb3TXY4VzvN51AFhWBAXenE5t5sb2SVpMr6cjmBHEC8cOF5NMueVo5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=amd.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8gFppZeLKhfHL/TcSG/owlwcXYfYwpAm5cYGHZWedHM=; b=jkmXxzDL7X/n1drqCaMPJ21F2cox7ug0de9jcpNaGOeWObk99N6yI+7di3KxLKQx38s3644t62i6f9dAhZKpTfG/mvTYHFYMIDamEsjkkkRacmYHyQzMq1cCqYLic4R2+eP4neJDc4s8KhGAK3ulq0Jx3Rl2RRmYKFBS+xJvBRGoNXeiYx/nd9dbk2R3dKuvnJk96eknhtGq+G94AvcwH7aRoKaQuBsRBHnMF7Azgi9JipM7yiHYkvkB+51Eekb6nCWq76infFoetwNLJGb2W5GUnAG4WQqI9hhvOBtSmmMyUoeIF3WJDINlVfaZD4fXo2qas66hzkuOL8hyTuUHaA== Received: from BN1PR12CA0029.namprd12.prod.outlook.com (2603:10b6:408:e1::34) by SA3PR12MB7879.namprd12.prod.outlook.com (2603:10b6:806:306::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.26; Mon, 27 Feb 2023 07:04:54 +0000 Received: from BL02EPF000108EA.namprd05.prod.outlook.com (2603:10b6:408:e1:cafe::79) by BN1PR12CA0029.outlook.office365.com (2603:10b6:408:e1::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29 via Frontend Transport; Mon, 27 Feb 2023 07:04:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF000108EA.mail.protection.outlook.com (10.167.241.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.12 via Frontend Transport; Mon, 27 Feb 2023 07:04:53 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 26 Feb 2023 23:04:39 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 26 Feb 2023 23:04:37 -0800 From: Xueming Li To: Gregory Etelson CC: Ferruh Yigit , dpdk stable Subject: patch 'app/testpmd: fix interactive mode with no ports' has been queued to stable release 22.11.2 Date: Mon, 27 Feb 2023 14:58:59 +0800 Message-ID: <20230227070107.15664-31-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230227070107.15664-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230227070107.15664-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF000108EA:EE_|SA3PR12MB7879:EE_ X-MS-Office365-Filtering-Correlation-Id: f29a0e32-0099-4e27-4e0e-08db1890ed79 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9UIjVRqBfdoDMd6Jzm6yjCSmhEq9seKQrGSKhMuLO8ZxrrTE2EOLJtDvY0/M9kObc1Yl/wUQC1UH3sefomo9GTa6gUpvK/JVz6az5xNAlSob7N3fD6V4fSYABkvbn2WW2oZ4F3pPaK6t1A4xJom6lk6O0YrjW9VJwt3b0sLDK7T93zTgXqqI0pz2bzm0pNDjFgHO914DjbqHkxufNYcLZSIwHwzvLETlCDIFpXtcTUjLClWVPGnj1Lt3DVZwqZyk2ZgLVBE9tdYG7r44ZqCm8Oy4dm9w7sNOQgKWh6qBZXk8U6bLqp+sr65cGvur3U3aokeLuKwwP2TKWy5CkHS78X1jmesrvgCf42zbcdw4W0MVwWJCM5ER2kKvnwvUNGwXpOqNHvOjV6DK+ISJc95atocOMBmtUthTXjPJipARrk9oy7SbuQiXEgt/S5d5rHG10++Dm+5and2Ddm67Qa7SxKEqryTfxhGijyiwKZLJhOscscbOmrFT7QJ+IUsMEzkF1ys7TpmA1MjfXJV8VBA3/NSdVUxjjtEkC3Ny53zYedYrda/drq6bnblm0GVdTgELj0kEcO2WxPzqy+L0nWiLc5JlxoBMIX537qdsaL18RVLp9exT8TZRMaOTWn6X6R3EGu422hfucS+jJ+vZV3oMhgeRePtY9aJnI144JdN8zIPQHSGb/Yv/L6m4QB9y8MGmdIkCg2ZSN+/ZsrxaDSlEhYE0E/XyUGi+aHBItyx+miXnnBGLWvYfn8g9x4aKLMUyOx7sJLCuXWe68ZcwlfRYl/OnIQUriqfBYuPZNyQnMrw= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199018)(40470700004)(46966006)(36840700001)(6636002)(316002)(54906003)(37006003)(36756003)(82310400005)(86362001)(966005)(336012)(16526019)(6286002)(40460700003)(186003)(5660300002)(41300700001)(36860700001)(1076003)(8936002)(8676002)(4326008)(70206006)(70586007)(426003)(47076005)(478600001)(2616005)(53546011)(6862004)(6666004)(55016003)(7696005)(26005)(40480700001)(2906002)(7636003)(82740400003)(356005)(83380400001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 07:04:53.9376 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f29a0e32-0099-4e27-4e0e-08db1890ed79 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF000108EA.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7879 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/01/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=8ab731497d62848d74a06e6f80ad41e2da5ff54c Thanks. Xueming Li --- >From 8ab731497d62848d74a06e6f80ad41e2da5ff54c Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Thu, 19 Jan 2023 19:45:59 +0200 Subject: [PATCH] app/testpmd: fix interactive mode with no ports Cc: Xueming Li [ upstream commit 7e40372522c5a129da616d1420ff582968b81b46 ] Testpmd terminated unconditionally if it failed to start all ports. The patch allows testpmd to get into the command line, if the interactive mode was requested. Fixes: 6937d2103e22 ("app/testpmd: add option to not start device") Signed-off-by: Gregory Etelson Acked-by: Ferruh Yigit --- app/test-pmd/testpmd.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 134d79a555..e366f81a0f 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -4483,8 +4483,13 @@ main(int argc, char** argv) } } - if (!no_device_start && start_port(RTE_PORT_ALL) != 0) - rte_exit(EXIT_FAILURE, "Start ports failed\n"); + if (!no_device_start && start_port(RTE_PORT_ALL) != 0) { + if (!interactive) { + rte_eal_cleanup(); + rte_exit(EXIT_FAILURE, "Start ports failed\n"); + } + fprintf(stderr, "Start ports failed\n"); + } /* set all ports to promiscuous mode by default */ RTE_ETH_FOREACH_DEV(port_id) { -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-27 14:08:41.957126300 +0800 +++ 0032-app-testpmd-fix-interactive-mode-with-no-ports.patch 2023-02-27 14:08:40.749237000 +0800 @@ -1 +1 @@ -From 7e40372522c5a129da616d1420ff582968b81b46 Mon Sep 17 00:00:00 2001 +From 8ab731497d62848d74a06e6f80ad41e2da5ff54c Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 7e40372522c5a129da616d1420ff582968b81b46 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org