From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4176D41D8D for ; Mon, 27 Feb 2023 08:05:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C8B840A84; Mon, 27 Feb 2023 08:05:35 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2055.outbound.protection.outlook.com [40.107.92.55]) by mails.dpdk.org (Postfix) with ESMTP id 403FF40A7D for ; Mon, 27 Feb 2023 08:05:34 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RWqBJGaQT3YpInZBSFT45CWY6ZbpdsLALSZ4l9cPdCJstVquyVGI4iNvpvq3YXzr5DJ1/RmP2wjE5i8CwPbVGp+iCtxBTBB2/d9DVHU8PE2O2ZLg/ZwDmtEZBeUXdvlkJiaB4RdOssVs4lYqkq53lydjXzmE2q2MhAiHyWX0/LgQKWDfiMBhGCyJ3AfFuILcRFRJOIH7z2IbgNZdBbSH5eZSbOjn8FaZ+0Ei7wEDRDavMigjwRuCpJ8IEJHLOYcPLAc/DQgItvn98J5huKKhoNQoipJM5bl51FGYbkZdOowg9rv4aHC78JJVP27v6bajvYXhVv2lOVk7bxltF06VCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fSB6yE1UXYJVAsJBhC0mmd4JRbxzUSJTVXjnViix3qc=; b=lFi5e6MSsLhHRIXFbtnbYEItuTcfwEHEf3lElO+WIJd8xbyeQZlxw2gjCcLk5axr73kUD0hN+Of221Uo/UdrfrkOV7MuTHyGB4IbsDtyIvmbqj92by0Jv+nW2kKdpY1kyKM8wkVt04lW0JDNhivbfm8vX6lrycaI4VbWj4sqGAqWtkP384COafKzNqLOah+PXddv60+x2G4F722t6f7nzcDgfbSd61cs2c5+WOyvmk2jbj8KdWu8kaZ3SuQlPOIkB2gkuR3P56fzUFGXJr+qqhqEM3V8Fx7ChO3ILpUTE5nVSbFI+g9Gq2QjMV+tfwG1DYcOZ0jFP+Ox73ewEY/2Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fSB6yE1UXYJVAsJBhC0mmd4JRbxzUSJTVXjnViix3qc=; b=UIn+rRzEtrryH4ME87pTrtmLmKh0YFavTZivbelZWMH2baDpQ0QuaY5/o/wDAwJzvuWbYx7wEwPRLud2BmKpZkGxrJDtoQcUAYzGfora1MRJLuwKDAxSPfmpmsSXqoaSDzuWPrjUZIjOZPBUCamMFzNik8lUYZM8c+9WhAIyhERgmMR7Yze+1nYUCW7dKYRdQdMz1sNPfDi80eYzjAhCoB+2Kz0+S0ITIKJw1N30WoRswEvj6zLh76C3zstfNxCvjY9TcHtJUk1ZFksKOhFZ0o5g1s9oHGyPO56nMEXqYA5xCPzbdR6vew/Yw8g3auatzF3T7w8BeEhGhD3/zplcTw== Received: from BN0PR08CA0005.namprd08.prod.outlook.com (2603:10b6:408:142::20) by SJ0PR12MB7035.namprd12.prod.outlook.com (2603:10b6:a03:47c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Mon, 27 Feb 2023 07:05:32 +0000 Received: from BN8NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:408:142:cafe::7b) by BN0PR08CA0005.outlook.office365.com (2603:10b6:408:142::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29 via Frontend Transport; Mon, 27 Feb 2023 07:05:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT047.mail.protection.outlook.com (10.13.177.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.14 via Frontend Transport; Mon, 27 Feb 2023 07:05:31 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 26 Feb 2023 23:05:16 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 26 Feb 2023 23:05:13 -0800 From: Xueming Li To: Megha Ajmera CC: Cristian Dumitrescu , dpdk stable Subject: patch 'examples/qos_sched: fix debug mode' has been queued to stable release 22.11.2 Date: Mon, 27 Feb 2023 14:59:05 +0800 Message-ID: <20230227070107.15664-37-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230227070107.15664-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230227070107.15664-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT047:EE_|SJ0PR12MB7035:EE_ X-MS-Office365-Filtering-Correlation-Id: 8931e803-210a-47a4-29b3-08db189103ea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xXtv7JsHDc6DOFv6xIHpNm3lYdfwLT7vRZnixC9PbyGreHQfPQvmrMsGk6g+n3iwebPBShn7KpLTmXln24LOK2Fc1KQSxrzoRh0ub4oFIyzOeS9W4bEzv6QrI952og7LX2MBjudyGiy6uZrDMgQictQb0FrvhHwAgLX6C8ahFxepeyPkstBvDjvPOaS5R9ZTJaoxFCLj2qWMtR/eamnB2ATYzYcUQSgxAp4iNQDAc9v420YEAglXvGxXObQ8RLg9UV3ivz9UUjUjPkUdMXPwamNltkrRuLuE31TodVYFzBudRDhWNGuEW6Ie6pxx9eb5Un1x44oDg6x0cazlEglS97SWj+zEvO9rM0eJ1xspCfRKP75w6zvZ/QF4FXVQf3Ixs9+zJ1UKDGE3NH5tpy569c0RZZd4aksvFsCYL8iUwXCd4VQxCclMZV5k9ua9LXv1YP140ppK9jfBZhUWW9qan0Ib7wCxGiQzDqEEgsMj83D5PinEk2auQPPvsR1qlk3GCPVjFGxA5mZP0YTnK+9CRBmw23htOAjAsGhHnFH+UURMCwTCWQTquXE/yzlMYkQqhYPVGy87uhUpM0zSEoyVjzSlnuvnNoIMJHr8YgTgC4g70K+LSAZ4rtJqkDbGovR7mKSQtCVJ72helqCqix4aBOqRinN57xntZv6Ag58QxEpZHFofDkaAV9ssTNiKM3nLyqO2DMAa7b/Xp95/SeeD3+7yTmnQvrsuY5SvOSX6ZGtbsuPt7eue0gSsrUPChnHUweT4PK2golv6yNo5hgqiTTkVJSS5uI+aS9cR7zVVLbebZ273oXsk8J6+MXx+eoqk X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(136003)(376002)(346002)(396003)(451199018)(46966006)(40470700004)(36840700001)(7636003)(54906003)(8936002)(316002)(82740400003)(336012)(16526019)(8676002)(6286002)(36756003)(186003)(26005)(478600001)(53546011)(82310400005)(40460700003)(356005)(86362001)(7696005)(966005)(1076003)(6666004)(55016003)(2906002)(40480700001)(2616005)(5660300002)(83380400001)(34020700004)(70586007)(70206006)(4326008)(6916009)(426003)(47076005)(41300700001)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 07:05:31.6028 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8931e803-210a-47a4-29b3-08db189103ea X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7035 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/01/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=cb3c0ba47e45f4ae2dd395c3c3291cfb15a73970 Thanks. Xueming Li --- >From cb3c0ba47e45f4ae2dd395c3c3291cfb15a73970 Mon Sep 17 00:00:00 2001 From: Megha Ajmera Date: Thu, 5 Jan 2023 12:28:53 +0000 Subject: [PATCH] examples/qos_sched: fix debug mode MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit af13b8711aa43a851d2c12e5d3f8f87dd047307e ] This issue is happening due to non-initialization of some fields in “rte_eth_rxconf” structure in our application. Doing a memset to zero before initialization in HQoS application. Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-by: Megha Ajmera Acked-by: Cristian Dumitrescu --- examples/qos_sched/init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index 0709aec10c..d28350e14a 100644 --- a/examples/qos_sched/init.c +++ b/examples/qos_sched/init.c @@ -79,6 +79,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) if (app_inited_port_mask & (1u << portid)) return 0; + memset(&rx_conf, 0, sizeof(struct rte_eth_rxconf)); rx_conf.rx_thresh.pthresh = rx_thresh.pthresh; rx_conf.rx_thresh.hthresh = rx_thresh.hthresh; rx_conf.rx_thresh.wthresh = rx_thresh.wthresh; @@ -86,6 +87,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) rx_conf.rx_drop_en = 0; rx_conf.rx_deferred_start = 0; + memset(&tx_conf, 0, sizeof(struct rte_eth_txconf)); tx_conf.tx_thresh.pthresh = tx_thresh.pthresh; tx_conf.tx_thresh.hthresh = tx_thresh.hthresh; tx_conf.tx_thresh.wthresh = tx_thresh.wthresh; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-27 14:08:42.131667400 +0800 +++ 0038-examples-qos_sched-fix-debug-mode.patch 2023-02-27 14:08:40.749237000 +0800 @@ -1 +1 @@ -From af13b8711aa43a851d2c12e5d3f8f87dd047307e Mon Sep 17 00:00:00 2001 +From cb3c0ba47e45f4ae2dd395c3c3291cfb15a73970 Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit af13b8711aa43a851d2c12e5d3f8f87dd047307e ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org