From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF91541D8C for ; Mon, 27 Feb 2023 08:01:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB6E1410DC; Mon, 27 Feb 2023 08:01:58 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2075.outbound.protection.outlook.com [40.107.243.75]) by mails.dpdk.org (Postfix) with ESMTP id 3770140A7D for ; Mon, 27 Feb 2023 08:01:57 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N7pYgthDBq2rDj330nbQIVvyeYKNI8Vhzo8ANk8nlZHCOAC+mpnBoUNU+LODBT6IU1M3b3E5YwT5bTvtnPl+40rZq1gD7jK7aSWXm8HBAGFWMxFWZ2RhGRo567nWnSEPkHpgKVYfKSK2RfC4CauC0PMtfJ6HXMFXjiwkwQNzMOnk+r0BmSL+GCJeapW0EHDV7tfWm2FnYhHkbyDfiKpUif90RKjwjUTAxTrxmw5lNK2jTjoQVMY5m4rUwweEoCbNEUs4XxdBUTnRI0dTtwlap2Z4lhY71FnFsn/xFU2KkMs8P4bZbQBNJ9+6RmucAWNsTYu35aSOlwX296gtaT2/IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TAz/RF8a3b59opzvO3BFK21g7df0xSX4cqfF/OSIldQ=; b=WKbEEMizzpgeMvDru8jYz0VLifwS7hXpd/BfxCmtk3UiKFB7KR+nXEDOz/g0yXdJynzxes+a6Ct8p+cBN3Ju8GHPNSFsl/mG8tsuXumSD4rX+GTCVXsb+dsHcl/kka7yuInusXY57EpuPQqE2JIFMGqL8aXHPYNgOqfkGoaa+Cvdry6qNxAz3x0hFlHibfVIbpDo2Yqzl3s50TTywouovS4B5ONOVZc8oCvb4u5DN03M9chbsdvlxwOU6lAhqpDuqvLrlLPT9TwErYYsghHyq24Z67EORabd6dI63VIONiT4KAk3RJNbjUioZHK5JolUuuFB1TQizRAVEgVnwVc6dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TAz/RF8a3b59opzvO3BFK21g7df0xSX4cqfF/OSIldQ=; b=L2ahCxqsHVafaC8hCca/dLqyYrHLAcJj0gkUVuQHBLyCJT6XspuWHFoQZ/JpL7aJ9QDCSBJNjnVMCApPyyySxmMzqOhRJZcsslWF9PgXwW35sSVBciF/XK4S9kICP48fANFiBdHblbXxkcSvgYosG/81KYlviFWXR3+vKSW847IN1jtX+xGxhkR5dKUFd+9zkLxaB5CLckJBlXDGs2O3TaioEAY8887j915pScElow0Fxzw1XiYLMd54v6QOqNjkSvoKzlLLtH9IAaF/pma6f+YVyKmWCzrbrKsYQqxXppawPfwlmQ+GQHKPtrcDR322zdhSTDoJL7uxdB7jqC07lw== Received: from BN9PR03CA0244.namprd03.prod.outlook.com (2603:10b6:408:ff::9) by IA1PR12MB6043.namprd12.prod.outlook.com (2603:10b6:208:3d5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.21; Mon, 27 Feb 2023 07:01:55 +0000 Received: from BL02EPF000108EA.namprd05.prod.outlook.com (2603:10b6:408:ff:cafe::f5) by BN9PR03CA0244.outlook.office365.com (2603:10b6:408:ff::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29 via Frontend Transport; Mon, 27 Feb 2023 07:01:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF000108EA.mail.protection.outlook.com (10.167.241.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.12 via Frontend Transport; Mon, 27 Feb 2023 07:01:55 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 26 Feb 2023 23:01:37 -0800 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 26 Feb 2023 23:01:30 -0800 From: Xueming Li To: David Marchand CC: Bruce Richardson , dpdk stable Subject: patch 'hash: fix GFNI implementation build with GCC 12' has been queued to stable release 22.11.2 Date: Mon, 27 Feb 2023 14:58:32 +0800 Message-ID: <20230227070107.15664-4-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230227070107.15664-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230227070107.15664-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF000108EA:EE_|IA1PR12MB6043:EE_ X-MS-Office365-Filtering-Correlation-Id: bf03755e-a218-4f34-f6b8-08db189082d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bLo1WGTn1HIK57cQfOVPT5OZCCifv7KHlJi6NfRfH99TU5CP02+N2Zw/msLAZlqsY1/501kkwSu8GquBmqS6ZwSmzzHdA9f1ubyp33AoKfeQHNfN0ZyviFMlvo1vH7Do+XZnLNv2NNWulZaOJ70IEeh7GygNOg7Jdw8dgDe3jNFkkX3IW3sFzJiMkcejJTkx/dkVmutxWOyMS5mF3mfc0l2NwN40THcoQdr6eRBhAS9q03BUK6P7cYScxosQ29o75RlC1w4wpVNC+WumhUDAvXRtmPnWJ8icqdxL38vya7E2owkwo2tZz/g0lr6mN5XQaMuLj750H3+hhRkrtdFcg5bnJwio3a26Ony1orLw5tGFktZROmP1b9B2vk9ZmD+UsXb95V/UUWvB5xKMMhQRgDsCf3x5888rU+A/gNKSdioBWK+apWjjZikKA25Xrkz2j7QCJAZf6XVcJx/2R2AnSeETOEZtPCs6cF2pBVkYfFWCjz7OGsgnGAtmubE2JyqU07LBqgehzskfErbadz6WyUDbQrUMLH6gsj4sqZunH6gO9Q+mzasQyxUnifq0GIwyyMbQBWJPWXwRjv5/T8eDELkiNdiZZVAiHCE83NHfsEFkH8wEwqQo4DFxKEkwSbLOu7DzI3eQFZ/qxq1z1GddJuHt+G82ZrruIq1FSVi3sHlWiseDSWfbqTAmWHazatER4knxpxH3K63XTh8Z8j4lkvdUhH3u61Ew0CfHcC0H45LESnQzLwkUSd2elS9D9CB8neQJEkE8iPSch0cVuRQ8Cj02W7lFhda6Fd3OfPA6jJc= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(136003)(346002)(396003)(376002)(39860400002)(451199018)(40470700004)(36840700001)(46966006)(41300700001)(8936002)(26005)(1076003)(16526019)(186003)(5660300002)(2906002)(53546011)(55016003)(40480700001)(6286002)(426003)(336012)(36756003)(54906003)(966005)(86362001)(478600001)(316002)(7696005)(4326008)(6916009)(8676002)(70206006)(70586007)(2616005)(82310400005)(36860700001)(40460700003)(83380400001)(47076005)(7636003)(82740400003)(356005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 07:01:55.0287 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bf03755e-a218-4f34-f6b8-08db189082d5 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF000108EA.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6043 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/01/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=760cf7543c59ce255a2f6a914ecd539654b52518 Thanks. Xueming Li --- >From 760cf7543c59ce255a2f6a914ecd539654b52518 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Mon, 9 Jan 2023 11:03:37 +0100 Subject: [PATCH] hash: fix GFNI implementation build with GCC 12 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit fe2c18a0a8b22703dec3add385a371ad819d7872 ] On a system that has AVX512F and GFNI, compiling fails with: In file included from /usr/lib/gcc/x86_64-redhat-linux/12/include/immintrin.h:71, from /usr/lib/gcc/x86_64-redhat-linux/12/include/x86intrin.h:32, from ../../../git/pub/dpdk.org/main/lib/eal/x86/include/rte_vect.h:31, from ../../../git/pub/dpdk.org/main/lib/eal/x86/include/rte_memcpy.h:17, from ../../../git/pub/dpdk.org/main/lib/mempool/rte_mempool.h:48, from ../../../git/pub/dpdk.org/main/lib/mbuf/rte_mbuf.h:38, from ../../../git/pub/dpdk.org/main/lib/net/rte_ip.h:33, from ../../../git/pub/dpdk.org/main/lib/hash/rte_thash.h:25, from ../../../git/pub/dpdk.org/main/lib/hash/rte_thash.c:7: In function ‘_mm512_mask_permutexvar_epi8’, inlined from ‘__rte_thash_gfni’ at ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:142:17, inlined from ‘rte_thash_gfni’ at ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:182:20, inlined from ‘rte_thash_adjust_tuple’ at ../../../git/pub/dpdk.org/main/lib/hash/rte_thash.c:784:11: /usr/lib/gcc/x86_64-redhat-linux/12/include/avx512vbmiintrin.h:97:20: error: ‘tuple_bytes’ may be used uninitialized [-Werror=maybe-uninitialized] 97 | return (__m512i) __builtin_ia32_permvarqi512_mask ((__v64qi) __B, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 98 | (__v64qi) __A, | ~~~~~~~~~~~~~~ 99 | (__v64qi) __W, | ~~~~~~~~~~~~~~ 100 | (__mmask64) __M); | ~~~~~~~~~~~~~~~~ And: In file included from ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_gfni.h:17, from ../../../git/pub/dpdk.org/main/lib/hash/rte_thash.h:27: ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h: In function ‘rte_thash_adjust_tuple’: ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:91:33: note: ‘tuple_bytes’ was declared here 91 | __m512i vals, matrixes, tuple_bytes, tuple_bytes_2; | ^~~~~~~~~~~ In function ‘_mm512_mask_permutexvar_epi8’, inlined from ‘__rte_thash_gfni’ at ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:142:17, inlined from ‘rte_thash_gfni’ at ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:182:20, inlined from ‘rte_thash_adjust_tuple’ at ../../../git/pub/dpdk.org/main/lib/hash/rte_thash.c:784:11: /usr/lib/gcc/x86_64-redhat-linux/12/include/avx512vbmiintrin.h:97:20: error: ‘permute_mask’ may be used uninitialized [-Werror=maybe-uninitialized] 97 | return (__m512i) __builtin_ia32_permvarqi512_mask ((__v64qi) __B, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 98 | (__v64qi) __A, | ~~~~~~~~~~~~~~ 99 | (__v64qi) __W, | ~~~~~~~~~~~~~~ 100 | (__mmask64) __M); | ~~~~~~~~~~~~~~~~ ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h: In function ‘rte_thash_adjust_tuple’: ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:92:30: note: ‘permute_mask’ was declared here 92 | __mmask64 load_mask, permute_mask, permute_mask_2; | ^~~~~~~~~~~~ cc1: all warnings being treated as errors Set those variables to 0. Fixes: 4fd8c4cb0de1 ("hash: add new Toeplitz hash implementation") Signed-off-by: David Marchand Acked-by: Bruce Richardson --- lib/hash/rte_thash_x86_gfni.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/hash/rte_thash_x86_gfni.h b/lib/hash/rte_thash_x86_gfni.h index 880739b710..7bb76ac1bb 100644 --- a/lib/hash/rte_thash_x86_gfni.h +++ b/lib/hash/rte_thash_x86_gfni.h @@ -88,8 +88,10 @@ __rte_thash_gfni(const uint64_t *mtrx, const uint8_t *tuple, const __m512i shift_8 = _mm512_set1_epi8(8); __m512i xor_acc = _mm512_setzero_si512(); __m512i perm_bytes = _mm512_setzero_si512(); - __m512i vals, matrixes, tuple_bytes, tuple_bytes_2; - __mmask64 load_mask, permute_mask, permute_mask_2; + __m512i vals, matrixes, tuple_bytes_2; + __m512i tuple_bytes = _mm512_setzero_si512(); + __mmask64 load_mask, permute_mask_2; + __mmask64 permute_mask = 0; int chunk_len = 0, i = 0; uint8_t mtrx_msk; const int prepend = 3; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-27 14:08:41.168700100 +0800 +++ 0005-hash-fix-GFNI-implementation-build-with-GCC-12.patch 2023-02-27 14:08:40.719237000 +0800 @@ -1 +1 @@ -From fe2c18a0a8b22703dec3add385a371ad819d7872 Mon Sep 17 00:00:00 2001 +From 760cf7543c59ce255a2f6a914ecd539654b52518 Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit fe2c18a0a8b22703dec3add385a371ad819d7872 ] @@ -76 +78,0 @@ -Cc: stable@dpdk.org